Re: [Spice-devel] [PATCH spice-gtk 1/2] Be more tolerant on NULL arrays

2012-03-29 Thread Hans de Goede
ACK series. Regards, Hans On 03/29/2012 09:32 PM, Marc-André Lureau wrote: 2 places where we should be more carreful with NULL arrays, and we can avoid potential crashes. --- gtk/spice-session.c |3 ++- gtk/usb-device-widget.c |3 +++ 2 files changed, 5 insertions(+), 1 deleti

Re: [Spice-devel] [PATCH spice-common] Bypass certicate verification failure if PUBKEY check only

2012-03-29 Thread Hans de Goede
Ack. On 03/29/2012 09:28 PM, Marc-André Lureau wrote: During switch-host migration, only PUBKEY verification is required. Couldn't it just load the certificate again for the new session? perhaps, but that's they way the code used to work until I introduced a regression in spice commit d46f9d3f4e

Re: [Spice-devel] Read data out of the Virtqueue

2012-03-29 Thread Charles . Tsai-蔡清海-研究發展部
Alon, It is a bug that I modified for printing channel. BTW, can a spice channel be brought up or down based on a request from a spice client? The reason that I am asking for such a question is because the printing channel might be brought up based on a configuration policy. I would like to know

Re: [Spice-devel] [PATCH spice-common] ssl-verify: improve logging report in case of errors

2012-03-29 Thread Alon Levy
On Thu, Mar 29, 2012 at 08:02:12PM +0200, Marc-André Lureau wrote: > Use the log.h system, and report a bit more information in the debug level ACK. > --- > common/ssl_verify.c | 72 ++ > 1 files changed, 43 insertions(+), 29 deletions(-) > > di

Re: [Spice-devel] Read data out of the Virtqueue

2012-03-29 Thread Alon Levy
On Thu, Mar 29, 2012 at 09:42:32AM +, Charles.Tsai-蔡清海-研究發展部 wrote: > Alon, > > Forget my previous mail. When I dig into the vdservice, I found there was one > bug to check the overlay I/O status after calling the VirtIO write function. > After I fixed the bug, I can see more printing raw dat

[Spice-devel] [PATCH spice-gtk 2/2] session: take pubkey reference in setter

2012-03-29 Thread Marc-André Lureau
The session assumed it owned a reference to it. But it didn't get it, and that lead to invalid memory access. --- gtk/spice-session.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gtk/spice-session.c b/gtk/spice-session.c index ea1a0f3..d30d089 100644 --- a/gtk/spice-se

[Spice-devel] [PATCH spice-gtk 1/2] Be more tolerant on NULL arrays

2012-03-29 Thread Marc-André Lureau
2 places where we should be more carreful with NULL arrays, and we can avoid potential crashes. --- gtk/spice-session.c |3 ++- gtk/usb-device-widget.c |3 +++ 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/gtk/spice-session.c b/gtk/spice-session.c index e9c8b94..ea1a0f

[Spice-devel] [PATCH spice-common] Bypass certicate verification failure if PUBKEY check only

2012-03-29 Thread Marc-André Lureau
During switch-host migration, only PUBKEY verification is required. Couldn't it just load the certificate again for the new session? perhaps, but that's they way the code used to work until I introduced a regression in spice commit d46f9d3f4e006d3bca9b99fac25169b17e7ac803. --- common/ssl_verify.c

[Spice-devel] [PATCH spice-common] ssl-verify: improve logging report in case of errors

2012-03-29 Thread Marc-André Lureau
Use the log.h system, and report a bit more information in the debug level --- common/ssl_verify.c | 72 ++ 1 files changed, 43 insertions(+), 29 deletions(-) diff --git a/common/ssl_verify.c b/common/ssl_verify.c index 236fa01..354e0e6 100644 ---

Re: [Spice-devel] [PATCH spice-gtk] usb-device-widget: Call set_active on the toggle_button, not the alignment

2012-03-29 Thread Marc-André Lureau
ack - Mensaje original - > Since the gnome HIG-ifying of usb-device-widget.c, the vbox contains > alignments, which in turn contain a toggle_button, so calling > gtk_toggle_button_set_active directly on the vbox-containers > childdren is > wrong. > > Signed-off-by: Hans de Goede > --- >

[Spice-devel] [PATCH spice-gtk] usb-device-widget: Call set_active on the toggle_button, not the alignment

2012-03-29 Thread Hans de Goede
Since the gnome HIG-ifying of usb-device-widget.c, the vbox contains alignments, which in turn contain a toggle_button, so calling gtk_toggle_button_set_active directly on the vbox-containers childdren is wrong. Signed-off-by: Hans de Goede --- gtk/usb-device-widget.c |6 -- 1 file chang

[Spice-devel] [ spice-devel : spice-gtk ] Compilation error

2012-03-29 Thread nicolas prochazka
hello, latest git tree of spice-gtk does not compile : ./autogen.sh '--prefix=/usr' '--with-gtk=2.0' '--with-x11' '--enable-smartcard=no' --enable-usbredir=yes channel-usbredir.c: In function 'usbredir_alloc_lock': channel-usbredir.c:510:13: error: invalid application of 'sizeof' to incomplete

Re: [Spice-devel] Alternate platform exploration

2012-03-29 Thread Jeremy White
> And there are already pretty good vnc js clients, > so why not use that combination, this also enables > using a native (so non js) client on many more > machines as there is a vnc client available for > quite a few platforms. Sure, but the belief is that the spice protocol is fundamentally supe

Re: [Spice-devel] Alternate platform exploration

2012-03-29 Thread Hans de Goede
Hi, Sorry for jumping in in the middle of the thread, but the whole discussion about a js/html5 client triggered me to put in my 2 cents: It already is possible to configure a qemu vm with both spice and vnc external displays (which will be mirrors of each other). Not sure if libvirt allows this

Re: [Spice-devel] Alternate platform exploration

2012-03-29 Thread Jeremy White
> To be most broadly useful, a HTML5 tunnelled version of SPICE would really > want to be architected as a proxy, rather than directly in the QEMU SPICE > server. Isn't this sort of proxy a well solved problem? That is, can't we safely presume that we can use an existing proxy or slightly modify

Re: [Spice-devel] Alternate platform exploration

2012-03-29 Thread Daniel P. Berrange
On Thu, Mar 29, 2012 at 03:58:17PM +0200, Attila Sukosd wrote: > Hi Guys, > > I've also been contemplating an alternative html5/js client, and as far as > I remember, Alon proposed an extension to spice-server to actually contain > a http server to serve the content to the browser. > But it seems

Re: [Spice-devel] Alternate platform exploration

2012-03-29 Thread Attila Sukosd
Hi Guys, I've also been contemplating an alternative html5/js client, and as far as I remember, Alon proposed an extension to spice-server to actually contain a http server to serve the content to the browser. But it seems like a too big project to take on alone :) Best Regards, Attila --

[Spice-devel] spicy USB redirection option

2012-03-29 Thread flooding Controlled
Hi all: Does spicy have the spicy USB redirection option by command line not by GUI.For exmple , I want to load automatically lload the USB device which is plugined into my client. Thanks a lot! Yours Flooding. ___ Spice-devel mailing list Spice-dev

Re: [Spice-devel] [PATCH] usb-acl-helper: add a missing "break"

2012-03-29 Thread Hans de Goede
Good one, ack! Regards, Hans On 03/29/2012 12:43 PM, Uri Lublin wrote: --- gtk/usb-acl-helper.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/gtk/usb-acl-helper.c b/gtk/usb-acl-helper.c index 12596d0..a3ba14d 100644 --- a/gtk/usb-acl-helper.c +++ b/gtk/usb-acl-he

[Spice-devel] [PATCH] usb-acl-helper: add a missing "break"

2012-03-29 Thread Uri Lublin
--- gtk/usb-acl-helper.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/gtk/usb-acl-helper.c b/gtk/usb-acl-helper.c index 12596d0..a3ba14d 100644 --- a/gtk/usb-acl-helper.c +++ b/gtk/usb-acl-helper.c @@ -135,6 +135,7 @@ static gboolean cb_out_watch(GIOChannel*channel,

Re: [Spice-devel] Read data out of the Virtqueue

2012-03-29 Thread Charles . Tsai-蔡清海-研究發展部
Alon, Forget my previous mail. When I dig into the vdservice, I found there was one bug to check the overlay I/O status after calling the VirtIO write function. After I fixed the bug, I can see more printing raw data inside the Qemu now. Although I still find some issues, hopefully I can fix it

Re: [Spice-devel] Building windows client

2012-03-29 Thread Christophe Fergeau
On Wed, Mar 28, 2012 at 05:56:08PM -0600, Noel Van Hook wrote: > I'm trying to build the Windows client from source. I'm using Visual > Studio 2008. > I am getting an errror in red_channel.cpp that 'sys/time.h' is not found. > > Any clue what is going on? Why would the windows build want > 'sys/