Re: [Spice-devel] [PATCH 0/2] server: listen on a pre-opened file descriptor

2012-03-09 Thread Hans de Goede
Hi, Thanks for the patches! Series looks good, ack! I would like one other spice developer more familiar with the server to look at it and ack it too and then I (or that other developer) will push it to our git master. Regards, Hans On 03/09/2012 06:26 PM, Nahum Shalman wrote: With thanks t

Re: [Spice-devel] Access local network printer from guest OS

2012-03-09 Thread Charles . Tsai-蔡清海-研究發展部
Alon, I am implementing the code for the printing redirection for spice client. In the windows client, I know how to do it. Basically, I just follow the footprint of the playbackchannel. However, I still have a question regarding how my virtual printer driver delivers the printing r

Re: [Spice-devel] Can we cross compile SPICE client on arm?

2012-03-09 Thread Alon Levy
On Fri, Mar 09, 2012 at 12:10:16AM +0800, WangZhiqiang wrote: >Hi All, >  >Can we cross compile SPICE client on arm? >  The server side I never tried, the client works last time I checked but it needed some questionable patche to nop the atomic inc/dec. >Thanks a lot! >Wan

Re: [Spice-devel] Resolution still remains when windowed mode is switched to Full-screen mode

2012-03-09 Thread Alon Levy
On Fri, Mar 09, 2012 at 06:47:04AM -0800, Naga Mohan Pothula wrote: >Hi Alon, >I'm getting the same error "ASSERT(_process_loop && >!_process_loop->is_same_thread(pthread_self()));" even I >defined ResolutionChangeEvent class at red_client.cpp. >I called "_client.send_agent_moni

Re: [Spice-devel] [PATCH 2/2] server: listen on a pre-opened file descriptor

2012-03-09 Thread David Mansfield
On 03/09/2012 12:26 PM, Nahum Shalman wrote: Allow applications to pre-open a file descriptor and have spice listen on it. Thanks to Daniel Berrange for his comments --- server/reds.c| 21 + server/spice-server.syms |1 + server/spice.h |

[Spice-devel] [PATCH spice-xpi] ~/.spicec is no longer needed

2012-03-09 Thread Marc-André Lureau
Don't attempt to create an unused directory See also: https://bugzilla.redhat.com/show_bug.cgi?id=801871 --- SpiceXPI/src/plugin/plugin.cpp |5 - SpiceXPI/src/plugin/plugin.h |1 - 2 files changed, 0 insertions(+), 6 deletions(-) diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXP

Re: [Spice-devel] [PATCH 1/2] server: don't fail on ENOPROTOOPT from setsockopt

2012-03-09 Thread Daniel P. Berrange
On Fri, Mar 09, 2012 at 12:26:50PM -0500, Nahum Shalman wrote: > If we allow listening on arbitrary sockets like unix sockets, > we can get ENOPROTOOPT errors from setsockopt calls that set TCP > specific options. This should be allowed to happen. > --- > server/inputs_channel.c |2 +- > serv

[Spice-devel] [PATCH 1/2] server: don't fail on ENOPROTOOPT from setsockopt

2012-03-09 Thread Nahum Shalman
If we allow listening on arbitrary sockets like unix sockets, we can get ENOPROTOOPT errors from setsockopt calls that set TCP specific options. This should be allowed to happen. --- server/inputs_channel.c |2 +- server/spicevmc.c |2 +- 2 files changed, 2 insertions(+), 2 deletion

[Spice-devel] [PATCH 2/2] server: listen on a pre-opened file descriptor

2012-03-09 Thread Nahum Shalman
Allow applications to pre-open a file descriptor and have spice listen on it. Thanks to Daniel Berrange for his comments --- server/reds.c| 21 + server/spice-server.syms |1 + server/spice.h |1 + 3 files changed, 23 insertions(+), 0 deletions(

[Spice-devel] [PATCH 0/2] server: listen on a pre-opened file descriptor

2012-03-09 Thread Nahum Shalman
With thanks to Daniel Berrange for his guidance, this is a redo of my previous pair of patches. Listening on a unix socket was hitting ENOPROTOOPT, so I'm now allowing that error. I've also generalized the naming per Daniel's suggestion since this could be flexibly used in lots of different scena

Re: [Spice-devel] [PATCH 2/2] server: support listening on a UNIX socket

2012-03-09 Thread Daniel P. Berrange
On Fri, Mar 09, 2012 at 10:39:22AM -0500, Nahum Shalman wrote: > We leave all the hard work of setting up the socket to qemu. > This will cause all of the TCP setsockopt calls to return ENOSUP > but that is okay. > --- > server/reds.c| 21 + > server/spice-server.

Re: [Spice-devel] [PATCH 1/2] server: don't fail on ENOSUP from setsockopt calls

2012-03-09 Thread Nahum Shalman
On 03/09/2012 11:15 AM, Daniel P. Berrange wrote: Huh. This code already avoids failure when you get ENOTSUP. You're removing the code path where the errno is *not* ENOTSUP You're right. I need to go back and figure out which error we were getting. Thank you. -Nahum _

Re: [Spice-devel] [PATCH 1/2] server: don't fail on ENOSUP from setsockopt calls

2012-03-09 Thread Daniel P. Berrange
On Fri, Mar 09, 2012 at 10:39:21AM -0500, Nahum Shalman wrote: > These are the only instances in the code base where functions fail as a > result of setsockopt calls returning ENOSUP. > Those calls will always return ENOSUP when we are listening on a UNIX > socket rather than a TCP port. > We'd pre

[Spice-devel] [PATCH 1/2] server: don't fail on ENOSUP from setsockopt calls

2012-03-09 Thread Nahum Shalman
These are the only instances in the code base where functions fail as a result of setsockopt calls returning ENOSUP. Those calls will always return ENOSUP when we are listening on a UNIX socket rather than a TCP port. We'd prefer not to fail. --- server/inputs_channel.c |1 - server/spicevmc.c

[Spice-devel] [PATCH 0/2] server: support listening on a UNIX socket

2012-03-09 Thread Nahum Shalman
These patches are to allow listening on a UNIX socket rather than a TCP port. Support is needed in QEMU. Example QEMU patches (against a different QEMU tree) can be found at https://github.com/nshalman/illumos-kvm-cmd Feedback requested! Nahum Shalman (2): server: don't fail on ENOSUP from se

[Spice-devel] [PATCH 2/2] server: support listening on a UNIX socket

2012-03-09 Thread Nahum Shalman
We leave all the hard work of setting up the socket to qemu. This will cause all of the TCP setsockopt calls to return ENOSUP but that is okay. --- server/reds.c| 21 + server/spice-server.syms |1 + server/spice.h |1 + 3 files changed, 23 inser

Re: [Spice-devel] Resolution still remains when windowed mode is switched to Full-screen mode

2012-03-09 Thread Naga Mohan Pothula
Hi Alon, I'm getting the same error "ASSERT(_process_loop && !_process_loop->is_same_thread(pthread_self()));" even I defined ResolutionChangeEvent class at red_client.cpp. I called "_client.send_agent_monitors_config();" in "response virtual function of  ResolutionChangeEvent class" This error

Re: [Spice-devel] Spice agent for XSpice

2012-03-09 Thread Hans de Goede
Hi, On 03/09/2012 11:57 AM, Alon Levy wrote: On Fri, Mar 09, 2012 at 10:46:50AM +0100, Hans de Goede wrote: Hi Eike, Alon, On 03/08/2012 08:33 PM, Eike Hein wrote: Hi, I recently sent a mail to Marc-André Lureau, inquiring about clipboard sharing support in his virt-viewer builds for Win- d

Re: [Spice-devel] Spice agent for XSpice

2012-03-09 Thread Alon Levy
On Fri, Mar 09, 2012 at 10:46:50AM +0100, Hans de Goede wrote: > Hi Eike, Alon, > > On 03/08/2012 08:33 PM, Eike Hein wrote: > > > >Hi, > > > >I recently sent a mail to Marc-André Lureau, inquiring about > >clipboard sharing support in his virt-viewer builds for Win- > >dows. It turned out that th

Re: [Spice-devel] Problem about qxl and vmc

2012-03-09 Thread Alon Levy
On Fri, Mar 09, 2012 at 09:01:06AM +0800, wangfeng wangfeng wrote: > Hi, thank you for your patience. > > The whole info qtree: > *bus: main-system-bus* [snip] > * dev: virtio-serial-pci, id "virtio-serial0"* > *dev-prop: ioeventfd = on* > *dev-prop: vectors = 32* > *d

Re: [Spice-devel] Spice agent for XSpice

2012-03-09 Thread Hans de Goede
Hi, On 03/09/2012 10:49 AM, suyi wang wrote: Hi all: I am now trying to*cross compile* spice-gtk-0.11 on my development machine(Fedora 16 i386) for ARM11. According to the README file in spice-gtk-0.11/ , the build dependencies are as follows: gtk3-devel spice-protocol intltool celt051

Re: [Spice-devel] Spice agent for XSpice

2012-03-09 Thread suyi wang
Hi all: I am now trying to* cross compile* spice-gtk-0.11 on my development machine(Fedora 16 i386) for ARM11. According to the README file in spice-gtk-0.11/ , the build dependencies are as follows: gtk3-devel spice-protocol intltool celt051-devel openssl-devel pulseaudio-libs-devel pixman-

Re: [Spice-devel] Spice agent for XSpice

2012-03-09 Thread Hans de Goede
Hi Eike, Alon, On 03/08/2012 08:33 PM, Eike Hein wrote: Hi, I recently sent a mail to Marc-André Lureau, inquiring about clipboard sharing support in his virt-viewer builds for Win- dows. It turned out that the reason clipboard sharing doesn't work is because Xspice does not yet spawn an agent