[Spice-devel] Vioserial of Windows guest OS on Qemu 0.15

2012-01-13 Thread Charles . Tsai-蔡清海-研究發展部
Alon, I tested Qemu 0.15 for Windows XP guest OS. But I found that the Virtual Serial I/O driver failed in driver initialization. The root cause of this problem is because the hardware resources(I/O in this device) is not allocated to the virtual serial I/O. When I debugg

[Spice-devel] Technical Teleconference...

2012-01-13 Thread Naga Mohan Pothula
Hi, I wish to attend technical teleconferences on Spice.  Is there any possibility for the persons other than RedHat employees to attend teleconferences on SPICE? Thanks, Naga.___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists

[Spice-devel] Error compiling Spice Client on ARM

2012-01-13 Thread Nicolas Antonio Corrarello
Guys, Being well aware that spice server only works on x64-64, I'm trying to compile the spice client in ARM, but I'm bumping into the following: make all-am make[1]: Entering directory `/root/spice-0.10.0/client' CXXforeign_menu.o foreign_menu.cpp: In constructor 'ForeignMenu::ForeignMenu(

Re: [Spice-devel] [Spice-commits] 2 commits - client/x11 server/smartcard.c

2012-01-13 Thread Christophe Fergeau
On Fri, Jan 13, 2012 at 07:18:37AM -0800, Hans de Goede wrote: > client/x11/images/alt_image.c |4 ++-- > client/x11/images/red_icon.c |4 ++-- > server/smartcard.c|2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > New commits: > commit 0ac13ecbc4c20d322b1c4993

Re: [Spice-devel] [PATCH 01/11] client/Makefile.am: mingw32 fixes

2012-01-13 Thread Christophe Fergeau
On Fri, Jan 13, 2012 at 04:54:25PM +0200, Alon Levy wrote: > On Fri, Jan 13, 2012 at 01:42:41PM +0100, Christophe Fergeau wrote: > > On Fri, Jan 13, 2012 at 01:35:44PM +0200, Alon Levy wrote: > > > + > > > +spicec_resource_ldadd = windows/redc.o > > > > Why in lower case? ACK otherwise > > > > I

Re: [Spice-devel] spice-protocol "mess"

2012-01-13 Thread Alon Levy
On Fri, Jan 13, 2012 at 01:17:26PM +0100, Hans de Goede wrote: > Hi, > > On 01/13/2012 12:17 PM, Alon Levy wrote: > >On Thu, Jan 12, 2012 at 05:52:15PM +0100, Hans de Goede wrote: > >>Hi, > >> > >>While looking at spice-protocol git, to see if we should > >>do a spice-protocol-0.10.1 too, I notice

Re: [Spice-devel] [00/17] Misc code style cleanups & adding 'syntax-check' make rule

2012-01-13 Thread Alon Levy
On Fri, Jan 13, 2012 at 01:40:35PM +, Daniel P. Berrange wrote: > On Fri, Jan 13, 2012 at 01:30:42PM +, Daniel P. Berrange wrote: > > On Tue, Jan 10, 2012 at 03:58:21PM +, Daniel P. Berrange wrote: > > > In libvirt we use GNULIB, which provides a useful extra make rule > > > 'syntax-che

Re: [Spice-devel] [PATCH 01/11] client/Makefile.am: mingw32 fixes

2012-01-13 Thread Alon Levy
On Fri, Jan 13, 2012 at 02:35:02PM +0100, Hans de Goede wrote: > Hi, > > Ack series, although I agree with Christophe that it would > be good to make the ldadd in patch 1 be caps. > > Regards, > > Hans > I'll change it (and see it doesn't break anything), then push, to both 0.10 and master. >

Re: [Spice-devel] [PATCH 01/11] client/Makefile.am: mingw32 fixes

2012-01-13 Thread Alon Levy
On Fri, Jan 13, 2012 at 01:42:41PM +0100, Christophe Fergeau wrote: > On Fri, Jan 13, 2012 at 01:35:44PM +0200, Alon Levy wrote: > > * build resource file with windres > > * include client/windows and not client/x11 > > * use CXIMAGE_CFLAGS (it's already set to -DDISABLE_CXIMAGE correctly) > > ---

Re: [Spice-devel] [PATCH spice 1/2] smartcard handling: Fix compilation when ASSERT-s are turned on

2012-01-13 Thread Alon Levy
On Fri, Jan 13, 2012 at 03:28:15PM +0100, Hans de Goede wrote: > Signed-off-by: Hans de Goede ACK both. > --- > server/smartcard.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/server/smartcard.c b/server/smartcard.c > index 08ba3da..43ca1ac 100644 > --- a/serv

[Spice-devel] [PATCH spice 2/2] client-x11: Fix building with gcc-4.7

2012-01-13 Thread Hans de Goede
Without this change gcc says: x11/res.cpp:31:1: error: narrowing conversion of ‘(((unsigned int)_alt_image.::width) * 4u)’ from ‘unsigned int’ to ‘int’ inside { } is ill-formed in C++11 [-Werror=narrowing] x11/res.cpp:61:1: error: narrowing conversion of ‘_red_icon.::width’ from ‘const uint32_t {

[Spice-devel] [PATCH spice 1/2] smartcard handling: Fix compilation when ASSERT-s are turned on

2012-01-13 Thread Hans de Goede
Signed-off-by: Hans de Goede --- server/smartcard.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/smartcard.c b/server/smartcard.c index 08ba3da..43ca1ac 100644 --- a/server/smartcard.c +++ b/server/smartcard.c @@ -453,7 +453,7 @@ static int smartcard_channel_h

Re: [Spice-devel] [00/17] Misc code style cleanups & adding 'syntax-check' make rule

2012-01-13 Thread Daniel P. Berrange
On Fri, Jan 13, 2012 at 01:30:42PM +, Daniel P. Berrange wrote: > On Tue, Jan 10, 2012 at 03:58:21PM +, Daniel P. Berrange wrote: > > In libvirt we use GNULIB, which provides a useful extra make rule > > 'syntax-check' for validating all sorts of common code style bugs. > > This keeps the c

Re: [Spice-devel] [PATCH 01/11] client/Makefile.am: mingw32 fixes

2012-01-13 Thread Hans de Goede
Hi, Ack series, although I agree with Christophe that it would be good to make the ldadd in patch 1 be caps. Regards, Hans On 01/13/2012 12:35 PM, Alon Levy wrote: * build resource file with windres * include client/windows and not client/x11 * use CXIMAGE_CFLAGS (it's already set to -DDISAB

Re: [Spice-devel] [00/17] Misc code style cleanups & adding 'syntax-check' make rule

2012-01-13 Thread Daniel P. Berrange
On Tue, Jan 10, 2012 at 03:58:21PM +, Daniel P. Berrange wrote: > In libvirt we use GNULIB, which provides a useful extra make rule > 'syntax-check' for validating all sorts of common code style bugs. > This keeps the code looking sane & detects certain real bugs and/or > redundant coding patte

Re: [Spice-devel] [PATCH 02/11] client/common.h: mingw32 fix

2012-01-13 Thread Christophe Fergeau
ACK On Fri, Jan 13, 2012 at 01:35:45PM +0200, Alon Levy wrote: > define PACKAGE_VERSION only ifndef __GNUC__ > Since it is defined by autoconf and so it kinda comes with using the GNU > compilers. > --- > client/common.h |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --g

Re: [Spice-devel] [PATCH 01/11] client/Makefile.am: mingw32 fixes

2012-01-13 Thread Christophe Fergeau
On Fri, Jan 13, 2012 at 01:35:44PM +0200, Alon Levy wrote: > * build resource file with windres > * include client/windows and not client/x11 > * use CXIMAGE_CFLAGS (it's already set to -DDISABLE_CXIMAGE correctly) > --- > client/Makefile.am | 15 ++- > 1 files changed, 14 insertions

Re: [Spice-devel] spice-protocol "mess"

2012-01-13 Thread Hans de Goede
Hi, On 01/13/2012 12:17 PM, Alon Levy wrote: On Thu, Jan 12, 2012 at 05:52:15PM +0100, Hans de Goede wrote: Hi, While looking at spice-protocol git, to see if we should do a spice-protocol-0.10.1 too, I noticed a few unregularities: 1) the 0.10 branch has a commit from Alon called: "add opus

[Spice-devel] [PATCH 11/11] common/ssl_verify: special case to WIN32 that isn't MINGW32

2012-01-13 Thread Alon Levy
--- common/ssl_verify.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/common/ssl_verify.h b/common/ssl_verify.h index 8235c13..b8306f3 100644 --- a/common/ssl_verify.h +++ b/common/ssl_verify.h @@ -19,7 +19,7 @@ #ifndef SSL_VERIFY_H #define SSL_VERIFY_H -#ifdef WIN3

[Spice-devel] [PATCH 10/11] common/bitops: mingw32: reorder so __GNUC__ define is checked first

2012-01-13 Thread Alon Levy
--- common/bitops.h | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/common/bitops.h b/common/bitops.h index 449409b..bdd862a 100644 --- a/common/bitops.h +++ b/common/bitops.h @@ -27,7 +27,20 @@ extern "C" { #endif -#if defined(WIN32) && !d

[Spice-devel] [PATCH 09/11] common/backtrace: for mingw32 no pipe/wait_pid, just disable

2012-01-13 Thread Alon Levy
--- common/backtrace.c | 25 ++--- common/backtrace.h |2 +- 2 files changed, 23 insertions(+), 4 deletions(-) diff --git a/common/backtrace.c b/common/backtrace.c index 650dc1d..6fabdf0 100644 --- a/common/backtrace.c +++ b/common/backtrace.c @@ -26,8 +26,12 @@ #includ

[Spice-devel] [PATCH 08/11] client/windows: fix several assigned but not used errors

2012-01-13 Thread Alon Levy
--- client/windows/red_window.cpp |3 +-- common/gdi_canvas.c | 24 +--- 2 files changed, 10 insertions(+), 17 deletions(-) diff --git a/client/windows/red_window.cpp b/client/windows/red_window.cpp index 981fe9a..89a33c9 100644 --- a/client/windows/red_window.

[Spice-devel] [PATCH 07/11] client/windows: arraysize(inf.bmiColors) == 1 in mingw32

2012-01-13 Thread Alon Levy
--- client/windows/red_pixmap_gdi.cpp |3 +++ client/windows/red_pixmap_sw.cpp |3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/client/windows/red_pixmap_gdi.cpp b/client/windows/red_pixmap_gdi.cpp index 4336f46..2d93113 100644 --- a/client/windows/red_pixmap_gdi.cp

[Spice-devel] [PATCH 06/11] client/windows: fix typo, make error messages unique

2012-01-13 Thread Alon Levy
--- client/windows/platform_utils.cpp |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/windows/platform_utils.cpp b/client/windows/platform_utils.cpp index b57e921..a4405c1 100644 --- a/client/windows/platform_utils.cpp +++ b/client/windows/platform_utils.cpp @@

[Spice-devel] [PATCH 05/11] client/windows/main: mingw32 provides PACKAGE_VERSION

2012-01-13 Thread Alon Levy
--- client/windows/main.cpp |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/client/windows/main.cpp b/client/windows/main.cpp index 6204498..46af699 100644 --- a/client/windows/main.cpp +++ b/client/windows/main.cpp @@ -41,6 +41,13 @@ static void init_winsock()

[Spice-devel] [PATCH 04/11] client/common: mingw32: workaround HAVE_STDLIB_H redefined in jconfig.h

2012-01-13 Thread Alon Levy
--- client/red_gdi_canvas.cpp |3 +++ common/gdi_canvas.c |3 +++ common/sw_canvas.c|3 +++ 3 files changed, 9 insertions(+), 0 deletions(-) diff --git a/client/red_gdi_canvas.cpp b/client/red_gdi_canvas.cpp index ed091af..6ac2e8a 100644 --- a/client/red_gdi_canvas.cpp +

[Spice-devel] [PATCH 03/11] client: mingw32 build needs the jpeg_boolean define

2012-01-13 Thread Alon Levy
--- client/jpeg_decoder.cpp |2 +- client/jpeg_decoder.h|2 +- client/mjpeg_decoder.cpp |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/client/jpeg_decoder.cpp b/client/jpeg_decoder.cpp index 4bc4f18..19d22e3 100644 --- a/client/jpeg_decoder.cpp +++ b/client/

[Spice-devel] [PATCH 02/11] client/common.h: mingw32 fix

2012-01-13 Thread Alon Levy
define PACKAGE_VERSION only ifndef __GNUC__ Since it is defined by autoconf and so it kinda comes with using the GNU compilers. --- client/common.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/client/common.h b/client/common.h index 8b4e39d..e9572bd 100644 --- a/clie

[Spice-devel] [PATCH 01/11] client/Makefile.am: mingw32 fixes

2012-01-13 Thread Alon Levy
* build resource file with windres * include client/windows and not client/x11 * use CXIMAGE_CFLAGS (it's already set to -DDISABLE_CXIMAGE correctly) --- client/Makefile.am | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/client/Makefile.am b/client/Makefile.

Re: [Spice-devel] spice-protocol "mess"

2012-01-13 Thread Alon Levy
On Thu, Jan 12, 2012 at 05:52:15PM +0100, Hans de Goede wrote: > Hi, > > While looking at spice-protocol git, to see if we should > do a spice-protocol-0.10.1 too, I noticed a few > unregularities: > > 1) the 0.10 branch has a commit from Alon called: > "add opus playback and record cap", which i

Re: [Spice-devel] Intend to release spice-0.10.1

2012-01-13 Thread Alon Levy
On Thu, Jan 12, 2012 at 05:44:23PM +0100, Hans de Goede wrote: > Hi, > > I intend to release a spice-0.10.1 soon to get the > accumulated assorted fixes out there. I intend to > go over the commits in master and cherry pick > all commits which are clear and simple fixes. > > If you've something y