On Tue, Jan 10, 2012 at 03:58:21PM +0000, Daniel P. Berrange wrote: > In libvirt we use GNULIB, which provides a useful extra make rule > 'syntax-check' for validating all sorts of common code style bugs. > This keeps the code looking sane & detects certain real bugs and/or > redundant coding patterns. Although SPICE doesn't use GNULIB it is > trivial to copy the make rules into other projects. > > This patch series cleans up 15 different types of flaw, and then > finally adds the syntax-check rules. Just type 'make syntax-check' > to run it. The idea is that any patch submitter should run a > syntax-check on the code before submission, and ideally any > automated builds should run it too. > > It is possible to add project specific syntax checks by editing > the cfg.mk file at will. > > I have enabled the most commonly useful checks, but there are others > that might be useful to SPICE, which I leave as an exercise for other > motivated people. There should be no functional change from this > patch series.
FYI I have pushed this series to the 'syntax-check' branch here: git://gitorious.org/~berrange/virt-tools/berrange-spice.git to make it easier to test/merge as desired Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| _______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
