Re: [Spice-devel] Virt-manager and spice

2011-11-16 Thread David Jaša
Scott Dowdle píše v St 16. 11. 2011 v 12:03 -0500: > Greetings, > > - Original Message - > > I think you need to see this: > > https://bugzilla.redhat.com/show_bug.cgi?id=694694 > > And in particular this link inside the bugzilla (not tested myself > > yet...): > > > > http://koji.fedorap

Re: [Spice-devel] [PATCH spice-gtk 1/8] Correct Since tag for SpiceSession:enable-usbredir:

2011-11-16 Thread Marc-André Lureau
ack, wondering how this one went unnoticed.. -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH spice-gtk 4/5] Add a suid root helper to open usb device nodes

2011-11-16 Thread Hans de Goede
Hi, First of all, since I think I forgot to say so yesterday: Many thanks for the review! On 11/16/2011 01:53 PM, Marc-André Lureau wrote: Hi +priv->result = result; +priv->acl_helper = spice_usb_acl_helper_new(); They should be closed&disposed in dispose imho. The

[Spice-devel] USB acl helper patchset v2

2011-11-16 Thread Hans de Goede
Hi, Here is the second revision of my USB acl helper patchset, changes since the previous version: - 3 New cleanup / small fixes patches as preperation patches for the rest: [PATCH spice-gtk 1/8] Correct Since tag for SpiceSession:enable-usbredir: [PATCH spice-gtk 2/8] channel-usbredir: Fixup and

[Spice-devel] [PATCH spice-gtk 7/8] Add a suid root helper to open usb device nodes

2011-11-16 Thread Hans de Goede
spice-client needs to be able to open the device nodes under /dev/bus/usb to be able to redirect a usb device to the guest. Normally opening these nodes is only allowed by root. This patch adds a suid root helper which asks policykit if it is ok to grant raw usb device access, and if policykit says

[Spice-devel] [PATCH spice-gtk 5/8] usb-device-manager: Make spice_usb_device_manager_connect_device async

2011-11-16 Thread Hans de Goede
With the (upcoming) introduction of the usb device node acl helper, which uses policykit, spice_usbredir_channel_connect() may take a long time as it will be waiting for the helper, which will be waiting for policykit which may be interacting with the user. So spice_usbredir_channel_connect() will

[Spice-devel] [PATCH spice-gtk 6/8] channel-usbredir: Make spice_usbredir_channel_connect async

2011-11-16 Thread Hans de Goede
With the (upcoming) introduction of the usb device node acl helper, which uses policykit, spice_usbredir_channel_connect() may take a long time as it will be waiting for the helper, which will be waiting for policykit which may be interacting with the user -> Make spice_usbredir_channel_connect() a

[Spice-devel] [PATCH spice-gtk 8/8] Release our keyboard grab when we're going to invoke the usb acl helper

2011-11-16 Thread Hans de Goede
The usb acl helper asks policykit, which may want to interact with the user through the policykit agent, which wants to grab the keyboard, if we then have the keyboard grabbed, the agent says authentication has failed, policykit rejects the helper opening up the acl and usbredir won't work. Unfort

[Spice-devel] [PATCH spice-gtk 2/8] channel-usbredir: Fixup and simplify #ifdef USE_USBREDIR handling

2011-11-16 Thread Hans de Goede
glib does not like it when objects have a private data size of 0, so don't declare any private data when compiling without USE_USBREDIR set. Signed-off-by: Hans de Goede --- gtk/channel-usbredir.c | 45 + 1 files changed, 21 insertions(+), 24 deletio

[Spice-devel] [PATCH spice-gtk 4/8] channel-usbredir: Move usb device opening into a helper function

2011-11-16 Thread Hans de Goede
This is a preparation patch for adding the usb device node acl helper Signed-off-by: Hans de Goede --- gtk/channel-usbredir.c | 44 +--- 1 files changed, 29 insertions(+), 15 deletions(-) diff --git a/gtk/channel-usbredir.c b/gtk/channel-usbredir.c inde

[Spice-devel] [PATCH spice-gtk 3/8] channel-usbredir: Do disconnect from dispose instead of from finalize

2011-11-16 Thread Hans de Goede
Signed-off-by: Hans de Goede --- gtk/channel-usbredir.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/gtk/channel-usbredir.c b/gtk/channel-usbredir.c index a070c22..9ded4a1 100644 --- a/gtk/channel-usbredir.c +++ b/gtk/channel-usbredir.c @@ -66,7 +66,7 @@ stru

[Spice-devel] [PATCH spice-gtk 1/8] Correct Since tag for SpiceSession:enable-usbredir:

2011-11-16 Thread Hans de Goede
This was introduced post 0.7, and given the major changes done in git sofar the next release will be 0.8 rather then 0.7.1 Signed-off-by: Hans de Goede --- gtk/spice-session.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gtk/spice-session.c b/gtk/spice-session.c inde

Re: [Spice-devel] Virt-manager and spice

2011-11-16 Thread Todd And Margo Chester
On 11/16/2011 09:23 AM, Gianluca Cecchi wrote: On Wed, Nov 16, 2011 at 5:53 PM, Gianluca Cecchi wrote: It seems that the packages on koji are missing (deleted) Probably if you download rh el 6.2 beta iso (not found individual packages available) you will find it to try... Donna about its dep

Re: [Spice-devel] Virt-manager and spice

2011-11-16 Thread Gianluca Cecchi
On Wed, Nov 16, 2011 at 5:53 PM, Gianluca Cecchi wrote: > It seems that the packages on koji are missing (deleted) > Probably if you download rh el 6.2 beta iso (not found individual > packages available) you will find it to try... > Donna about its dependencies and influence on pre-existing rh

Re: [Spice-devel] Virt-manager and spice

2011-11-16 Thread Scott Dowdle
Greetings, - Original Message - > I think you need to see this: > https://bugzilla.redhat.com/show_bug.cgi?id=694694 > And in particular this link inside the bugzilla (not tested myself > yet...): > > http://koji.fedoraproject.org/koji/taskinfo?taskID=3096144 I just tested virt-manager o

Re: [Spice-devel] Virt-manager and spice

2011-11-16 Thread Gianluca Cecchi
On Wed, Nov 16, 2011 at 5:36 PM, Gianluca Cecchi wrote: >> Any know of a source for these RPM's for RHEL 6? >> > > I think you need to see this: > https://bugzilla.redhat.com/show_bug.cgi?id=694694 > And in particular this link inside the bugzilla (not tested myself yet...): > > http://koji.fedora

Re: [Spice-devel] Virt-manager and spice

2011-11-16 Thread Gianluca Cecchi
On Wed, Nov 16, 2011 at 5:24 PM, Todd And Margo Chester wrote: > > Oh no!  Can not find RPM's for spice-gtk, even at pbone.net, for > RHEL 6.x.  Pbone dose have FC15, but there are too many broken > dependencies. > > Any know of a source for these RPM's for RHEL 6? > I think you need to see this:

Re: [Spice-devel] Virt-manager and spice

2011-11-16 Thread Todd And Margo Chester
On 11/15/2011 01:47 AM, Alon Levy wrote: On Mon, Nov 14, 2011 at 11:13:40AM -0800, Todd And Margo Chester wrote: Hi All, My virt-manager tells me it does not have a Spice plugin to view my (spice graphics) guests, which is not a problem as I view with SPICEc. Just out of curiosity, is there a

Re: [Spice-devel] [PATCH vdagent-win 3/3] vdlog: change log times to human readable date & time rhbz#672828

2011-11-16 Thread Yaniv Kaul
On 11/16/2011 02:46 PM, David Jaša wrote: Arnon Gilboa píše v St 16. 11. 2011 v 14:20 +0200: Alon Levy wrote: On Wed, Nov 16, 2011 at 12:16:37PM +0200, Arnon Gilboa wrote: ifndef USE_DATE_TIME, use system time instead of secs from system startup Why do we want to keep the old behavior? Fo

Re: [Spice-devel] [PATCH spice-gtk 4/5] Add a suid root helper to open usb device nodes

2011-11-16 Thread Marc-André Lureau
Hi On Tue, Nov 15, 2011 at 10:20 PM, Hans de Goede wrote: > Ah, so you want to just make it a mandatory dep for usb-redir. The problem > with > that is that usbredir should work on mac os x too (without any changes, not > tested), > and with some more work on windows as well, and neither will hav

Re: [Spice-devel] [PATCH vdagent-win 3/3] vdlog: change log times to human readable date & time rhbz#672828

2011-11-16 Thread David Jaša
Arnon Gilboa píše v St 16. 11. 2011 v 14:20 +0200: > Alon Levy wrote: > > On Wed, Nov 16, 2011 at 12:16:37PM +0200, Arnon Gilboa wrote: > > > >> ifndef USE_DATE_TIME, use system time instead of secs from system startup > >> > > > > Why do we want to keep the old behavior? > > > For users

Re: [Spice-devel] [PATCH vdagent-win 3/3] vdlog: change log times to human readable date & time rhbz#672828

2011-11-16 Thread Arnon Gilboa
Alon Levy wrote: On Wed, Nov 16, 2011 at 12:16:37PM +0200, Arnon Gilboa wrote: ifndef USE_DATE_TIME, use system time instead of secs from system startup Why do we want to keep the old behavior? For users & qa, human readable date & time (hh:mm:ss) is nicer. For debugging, having fi

Re: [Spice-devel] [PATCH vdagent-win 1/3] vdservice: fix vdagent connection & termination handling rhbz#750037

2011-11-16 Thread Arnon Gilboa
Alon Levy wrote: On Wed, Nov 16, 2011 at 12:16:35PM +0200, Arnon Gilboa wrote: ACK A few comments / questions below. -#define VD_AGENT_TIMEOUT3000 +#define VD_AGENT_TIMEOUT1 Is this required? Do we want to make it configurable? It's way above what encountered

Re: [Spice-devel] [PATCH vdagent-win 3/3] vdlog: change log times to human readable date & time rhbz#672828

2011-11-16 Thread Alon Levy
On Wed, Nov 16, 2011 at 12:16:37PM +0200, Arnon Gilboa wrote: > ifndef USE_DATE_TIME, use system time instead of secs from system startup Why do we want to keep the old behavior? > --- > common/vdlog.h | 23 --- > 1 files changed, 20 insertions(+), 3 deletions(-) > > diff

Re: [Spice-devel] [PATCH vdagent-win 2/3] vdagent: release clipboard ownership on agent stop & desktop switch rhbz#731628

2011-11-16 Thread Alon Levy
On Wed, Nov 16, 2011 at 12:16:36PM +0200, Arnon Gilboa wrote: > -use event queue for agent stop & desktop switch > -exit gracefully on session end ACK > --- > vdagent/vdagent.cpp | 86 ++ > 1 files changed, 65 insertions(+), 21 deletions(-) > >

Re: [Spice-devel] [PATCH vdagent-win 1/3] vdservice: fix vdagent connection & termination handling rhbz#750037

2011-11-16 Thread Alon Levy
On Wed, Nov 16, 2011 at 12:16:35PM +0200, Arnon Gilboa wrote: ACK A few comments / questions below. > -extend vdagent wait timeouts > -timeout occured when connecting during windows startup, using wan emulator > with > 1Mbps bandwith, and only when qxl driver is installed. It might be due to >

[Spice-devel] [PATCH vdagent-win 3/3] vdlog: change log times to human readable date & time rhbz#672828

2011-11-16 Thread Arnon Gilboa
ifndef USE_DATE_TIME, use system time instead of secs from system startup --- common/vdlog.h | 23 --- 1 files changed, 20 insertions(+), 3 deletions(-) diff --git a/common/vdlog.h b/common/vdlog.h index bb2eb28..995e9d3 100644 --- a/common/vdlog.h +++ b/common/vdlog.h @@ -2

[Spice-devel] [PATCH vdagent-win 1/3] vdservice: fix vdagent connection & termination handling rhbz#750037

2011-11-16 Thread Arnon Gilboa
-extend vdagent wait timeouts -timeout occured when connecting during windows startup, using wan emulator with 1Mbps bandwith, and only when qxl driver is installed. It might be due to spice commands window control which in this case indirectly affects windows startup timings (needs further investi

[Spice-devel] [PATCH vdagent-win 2/3] vdagent: release clipboard ownership on agent stop & desktop switch rhbz#731628

2011-11-16 Thread Arnon Gilboa
-use event queue for agent stop & desktop switch -exit gracefully on session end --- vdagent/vdagent.cpp | 86 ++ 1 files changed, 65 insertions(+), 21 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index 646afed..f0f5243 1006

[Spice-devel] [PATCH vdagent-win 0/3] fix 3 annoying vdagent issues

2011-11-16 Thread Arnon Gilboa
Arnon Gilboa (3): vdservice: fix vdagent connection & termination handling rhbz#750037 vdagent: release clipboard ownership on agent stop & desktop switch rhbz#731628 vdlog: change log times to human readable date & time rhbz#672828 common/vdlog.h | 23 +++-- vdagent/