Re: [Spice-devel] [PATCH 1/2] fix harmless typo in InputsChannel::handle_modifiers

2011-08-16 Thread Alon Levy
On Tue, Aug 16, 2011 at 02:53:47PM +0200, Christophe Fergeau wrote: I can't comment about the second patch except it looks great to drop 15 lines for 2, so ACK both. > InputsChannel::handle_modifiers converts _modifiers which is a > bitflag of SPICE_KEYBOARD_MODIFIER_FLAGS_* to a Platform::*_MOD

Re: [Spice-devel] changing the timing of spice client linking in migration (RHBZ #725009)

2011-08-16 Thread Alon Levy
On Tue, Aug 16, 2011 at 06:54:58PM -0400, Marc-André Lureau wrote: > Hi > > I am also unfamiliar with the migration code, in particular the qemu -> qemu > part. It seems to me that no spice transmission occurs, but only guest > memory. Is that correct? How is state of the channel restored? Perha

[Spice-devel] spice-gtk git repository checkout error

2011-08-16 Thread Liang Guo
Hi, When clone spice-gtk git repository, I get following error: $ git clone http://gitorious.org/spice-gtk/spice-gtk Cloning into spice-gtk... fatal: http://gitorious.org/spice-gtk/spice-gtk/info/refs not found: did you run git update-server-info on the server? checkout spice-gtk successfully

Re: [Spice-devel] changing the timing of spice client linking in migration (RHBZ #725009)

2011-08-16 Thread Marc-André Lureau
Hi I am also unfamiliar with the migration code, in particular the qemu -> qemu part. It seems to me that no spice transmission occurs, but only guest memory. Is that correct? How is state of the channel restored? Perhaps it doesn't need any state transmission, and the connection of a client to

Re: [Spice-devel] changing the timing of spice client linking in migration (RHBZ #725009)

2011-08-16 Thread Christophe Fergeau
Hey Yonit, I've carefully read the bug report and your email, and looked a bit at the code, but I'm totally unfamiliar with migration stuff :-/ Your plan sounds good to me, hopefully changing the client the way you describe won't be too hard. I had one question though, see below On Tue, Aug 16, 2

Re: [Spice-devel] libvirt multifunction problem

2011-08-16 Thread Gerd Hoffmann
On 08/12/11 16:18, Christophe Fergeau wrote: On Fri, Aug 12, 2011 at 04:53:04PM +0300, Alon Levy wrote: I don't know when libvirt started adding mf=on. For what it's worth, this was added in [ adding libvirt list to cc: ] commit 9f8baf646ea44aa2de47cba5002af39a7ab1ac08 Author: Wen Congyang

[Spice-devel] [xf86 qxl PATCH] Use async I/O commands.

2011-08-16 Thread Gerd Hoffmann
Use the non-blocking versions of the I/O commands when available. --- src/qxl.h |8 src/qxl_driver.c | 49 + src/qxl_surface.c |4 ++-- 3 files changed, 55 insertions(+), 6 deletions(-) diff --git a/src/qxl.h b/src/qxl.h

[Spice-devel] [PATCH 2/2] use Xkb to get keyboard modifier mask

2011-08-16 Thread Christophe Fergeau
To be able to enable/disable keyboard leds on X11, we need to query the X server for which mask correspond to which led (NumLock, CapsLock). So far this was done using XKeysymToKeycode and iterating over X modifier mapping. Xkb provides XkbKeysymToModifiers for this purpose, and since we're using X

[Spice-devel] [PATCH 1/2] fix harmless typo in InputsChannel::handle_modifiers

2011-08-16 Thread Christophe Fergeau
InputsChannel::handle_modifiers converts _modifiers which is a bitflag of SPICE_KEYBOARD_MODIFIER_FLAGS_* to a Platform::*_MODIFIER bitflag, which is what Platform::set_keyboard_lock_modifiers expects. However, it's called with _modifiers, and the bitflag that this function computes is never used.

Re: [Spice-devel] changing the timing of spice client linking in migration (RHBZ #725009)

2011-08-16 Thread Yonit Halperin
On 08/16/2011 12:53 PM, Yonit Halperin wrote: Hi, Today, we handle migration in the client side by disconnecting from the source and connecting to the target. The disconnection and reconnection occur in response to SPICE_MSG_MAIN_MIGRATE_SWITCH_HOST, which is sent from the source when migration e

Re: [Spice-devel] palette id: not found.

2011-08-16 Thread Songwen Liao
Hi,Marian, You are right.it's the same problem. l look the code yesterday,find that the exception was thrown by the get() or remove() function in the cache.hpp or shared_cache.hpp. the code in the red_channel.cpp: RedChannel::run() catch the exception,and then q

[Spice-devel] changing the timing of spice client linking in migration (RHBZ #725009)

2011-08-16 Thread Yonit Halperin
Hi, Today, we handle migration in the client side by disconnecting from the source and connecting to the target. The disconnection and reconnection occur in response to SPICE_MSG_MAIN_MIGRATE_SWITCH_HOST, which is sent from the source when migration ends. In order to solve RHBZ #725009, i.e., t