Re: [Spice-devel] Traces of performance issues

2011-07-24 Thread Yonit Halperin
On 07/25/2011 07:32 AM, John A. Sullivan III wrote: On Sun, 2011-07-24 at 08:33 +0300, Yonit Halperin wrote: On 07/22/2011 02:33 PM, John A. Sullivan III wrote: As mentioned in my last email, I have taken several traces revealing performance issues, BSOD, and lost mouse scroll events. Performa

Re: [Spice-devel] Win7 Guest system hangs while doing shutdown...

2011-07-24 Thread Yaniv Kaul
The latest source for upstream virtio-* drivers is at http://git.kernel.org/?p=virt/kvm/kvm-guest-drivers-windows.git;a=summary I do not know if it's the very latest for virtio-serial or not. I can ask. Y. On 07/25/2011 06:04 AM, Naga Mohan Pothula wrote: Can you please give your response on b

Re: [Spice-devel] Traces of performance issues

2011-07-24 Thread John A. Sullivan III
On Sun, 2011-07-24 at 08:33 +0300, Yonit Halperin wrote: > On 07/22/2011 02:33 PM, John A. Sullivan III wrote: > > As mentioned in my last email, I have taken several traces revealing > > performance issues, BSOD, and lost mouse scroll events. > > > > Performance still seems to be a function of ba

Re: [Spice-devel] Win7 Guest system hangs while doing shutdown...

2011-07-24 Thread Naga Mohan Pothula
Can you please give your response on below mail? ~Mohan. From: Naga Mohan Pothula To: Lubos Kocman ; Yaniv Kaul Cc: "spice-devel@lists.freedesktop.org" Sent: Friday, July 22, 2011 10:42 AM Subject: Re: [Spice-devel] Win7 Guest system hangs while doing shutdow

Re: [Spice-devel] Dual head issues with Win7 Guests...

2011-07-24 Thread Naga Mohan Pothula
Hi, I'm eagerly looking for your suggestions on below issues. Tested with Spice v0.8.1 and Spice-protocol v0.8.0 1.) Currently, Spice Agent/QXL driver doesn't handle Dual head to Single head roaming(ie., Spice client should detect physical monitors and pass info to Vdservice      and this to Q

[Spice-devel] [PATCH 2/2] Fix typo: treshold -> threshold

2011-07-24 Thread Liang Guo
--- client/x11/record.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/x11/record.cpp b/client/x11/record.cpp index d799e5a..017a94d 100644 --- a/client/x11/record.cpp +++ b/client/x11/record.cpp @@ -182,7 +182,7 @@ bool WaveRecorder::init(uint32_t sampels_per_s

[Spice-devel] [PATCH 1/2] Fix typo: seperator -> separator

2011-07-24 Thread Liang Guo
--- client/cmd_line_parser.cpp| 34 +- client/cmd_line_parser.h |8 client/windows/red_window.cpp |6 +++--- 3 files changed, 24 insertions(+), 24 deletions(-) diff --git a/client/cmd_line_parser.cpp b/client/cmd_line_parser.cpp index 2f

Re: [Spice-devel] [PATCH vdagent-win v3 1/6] vdservice: add control events RHBZ #719140 #722980

2011-07-24 Thread Alon Levy
On Sun, Jul 24, 2011 at 06:16:53PM +0300, Arnon Gilboa wrote: > -prevent race between service control manager (SCM) & the service main thread. > -use events for stop, logon, agent restart. > -thread-safe control command queue > --- ACK series. > vdservice/vdservice.cpp | 83 >

[Spice-devel] [PATCH vdagent-win v3 1/6] vdservice: add control events RHBZ #719140 #722980

2011-07-24 Thread Arnon Gilboa
-prevent race between service control manager (SCM) & the service main thread. -use events for stop, logon, agent restart. -thread-safe control command queue --- vdservice/vdservice.cpp | 83 +++ 1 files changed, 55 insertions(+), 28 deletions(-) diff

Re: [Spice-devel] [PATCH vdagent-win 1/6] vdservice: add control events RHBZ #719140 #722980 (v2)

2011-07-24 Thread Arnon Gilboa
Arnon Gilboa wrote: NAK -prevent race between service control manager (SCM) & the service main thread. -use events for stop, logon, agent restart. -thread-safe control command queue ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org htt

[Spice-devel] [PATCH vdagent-win 6/6] vdagent: add casting

2011-07-24 Thread Arnon Gilboa
--- vdagent/desktop_layout.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vdagent/desktop_layout.cpp b/vdagent/desktop_layout.cpp index 9bd1852..0eada52 100644 --- a/vdagent/desktop_layout.cpp +++ b/vdagent/desktop_layout.cpp @@ -67,7 +67,7 @@ void DesktopLayout::get

[Spice-devel] [PATCH vdagent-win 5/6] vdagent: remove whitespaces

2011-07-24 Thread Arnon Gilboa
--- vdagent/vdagent.cpp |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index 1ebf1e4..646afed 100644 --- a/vdagent/vdagent.cpp +++ b/vdagent/vdagent.cpp @@ -565,11 +565,11 @@ bool VDAgent::handle_clipboard(VDAgentClipboard*

[Spice-devel] [PATCH vdagent-win 4/6] vdservice: extract init_vdi_port()

2011-07-24 Thread Arnon Gilboa
--- vdservice/vdservice.cpp | 29 - 1 files changed, 16 insertions(+), 13 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index e09828a..bc7ec41 100644 --- a/vdservice/vdservice.cpp +++ b/vdservice/vdservice.cpp @@ -80,6 +80,7 @@ private:

[Spice-devel] [PATCH vdagent-win 3/6] vdservice: clean agent proc handle in kill_agent()

2011-07-24 Thread Arnon Gilboa
fill_agent_events() will not add it to the events used by WaitFor(), preventing usage of a dead process handle. --- vdservice/vdservice.cpp | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index 8c34f59..e09828a 10

[Spice-devel] [PATCH vdagent-win 2/6] vdservice: use overlap ConnectNamedPipe() in launch_agent()

2011-07-24 Thread Arnon Gilboa
passing NULL is buggy when pipe opened with FILE_FLAG_OVERLAPPED --- vdservice/vdservice.cpp | 28 ++-- 1 files changed, 22 insertions(+), 6 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index 009f949..8c34f59 100644 --- a/vdservice/vdservic

[Spice-devel] [PATCH vdagent-win 1/6] vdservice: add control events RHBZ #719140 #722980 (v2)

2011-07-24 Thread Arnon Gilboa
-prevent race between service control manager (SCM) & the service main thread. -use events for stop, logon, agent restart. -thread-safe control command queue --- vdservice/vdservice.cpp | 85 +++--- 1 files changed, 57 insertions(+), 28 deletions(-) diff

[Spice-devel] [PATCH vdagent-win 0/6] fix agent breaking on session change RHBZ #719140 #722980 (v2)

2011-07-24 Thread Arnon Gilboa
use thread-safe control command queue Arnon Gilboa (6): vdservice: add control events RHBZ #719140 #722980 (v2) vdservice: use overlap ConnectNamedPipe() in launch_agent() vdservice: clean agent proc handle in kill_agent() vdservice: extract init_vdi_port() vdagent: remove whitespaces

Re: [Spice-devel] [PATCH vdagent-win 3/6] vdservice: clean agent proc handle in kill_agent()

2011-07-24 Thread Arnon Gilboa
Alon Levy wrote: On Sun, Jul 24, 2011 at 01:48:15PM +0300, Arnon Gilboa wrote: prevent usage of a dead proc handle in the WaitFor() Is this usage in fill_agent_event? can you make a note of that in the commit message? Otherwise ACK. Right, will add a note. ___

Re: [Spice-devel] [PATCH vdagent-win 1/6] vdservice: add control events RHBZ #719140 #722980

2011-07-24 Thread Arnon Gilboa
Alon Levy wrote: On Sun, Jul 24, 2011 at 01:48:13PM +0300, Arnon Gilboa wrote: prevent race between service control manager (SCM) & the service main thread. use events for stop, logon, agent restart. --- vdservice/vdservice.cpp | 70 +- 1 files c

[Spice-devel] Announcing xspice

2011-07-24 Thread Alon Levy
Hi, XSpice has been released as part of the xf86-video-qxl 0.0.16 package, see the announce message: http://lists.freedesktop.org/archives/xorg-announce/2011-July/001713.html It is a standalone X server and Spice server. source tarball: http://www.spice-space.org/download.html#XSpice

Re: [Spice-devel] [PATCH vdagent-win 1/6] vdservice: add control events RHBZ #719140 #722980

2011-07-24 Thread Alon Levy
On Sun, Jul 24, 2011 at 01:48:13PM +0300, Arnon Gilboa wrote: > prevent race between service control manager (SCM) & the service main thread. > use events for stop, logon, agent restart. > --- > vdservice/vdservice.cpp | 70 +- > 1 files changed, 44 in

Re: [Spice-devel] [PATCH vdagent-win 0/6] fix agent breaking on session change RHBZ #719140 #722980

2011-07-24 Thread Alon Levy
On Sun, Jul 24, 2011 at 01:48:12PM +0300, Arnon Gilboa wrote: > Arnon Gilboa (6): > vdservice: add control events RHBZ #719140 #722980 > vdservice: use overlap ConnectNamedPipe() in launch_agent() > vdservice: clean agent proc handle in kill_agent() > vdservice: extract init_vdi_port() >

Re: [Spice-devel] [PATCH vdagent-win 3/6] vdservice: clean agent proc handle in kill_agent()

2011-07-24 Thread Alon Levy
On Sun, Jul 24, 2011 at 01:48:15PM +0300, Arnon Gilboa wrote: > prevent usage of a dead proc handle in the WaitFor() Is this usage in fill_agent_event? can you make a note of that in the commit message? Otherwise ACK. > --- > vdservice/vdservice.cpp | 11 +++ > 1 files changed, 7 inse

[Spice-devel] [PATCH vdagent-win 6/6] vdagent: add casting

2011-07-24 Thread Arnon Gilboa
--- vdagent/desktop_layout.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vdagent/desktop_layout.cpp b/vdagent/desktop_layout.cpp index 9bd1852..0eada52 100644 --- a/vdagent/desktop_layout.cpp +++ b/vdagent/desktop_layout.cpp @@ -67,7 +67,7 @@ void DesktopLayout::get

[Spice-devel] [PATCH vdagent-win 5/6] vdagent: remove whitespaces

2011-07-24 Thread Arnon Gilboa
--- vdagent/vdagent.cpp |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp index 1ebf1e4..646afed 100644 --- a/vdagent/vdagent.cpp +++ b/vdagent/vdagent.cpp @@ -565,11 +565,11 @@ bool VDAgent::handle_clipboard(VDAgentClipboard*

[Spice-devel] [PATCH vdagent-win 4/6] vdservice: extract init_vdi_port()

2011-07-24 Thread Arnon Gilboa
--- vdservice/vdservice.cpp | 29 - 1 files changed, 16 insertions(+), 13 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index f61c318..3abc146 100644 --- a/vdservice/vdservice.cpp +++ b/vdservice/vdservice.cpp @@ -77,6 +77,7 @@ private:

[Spice-devel] [PATCH vdagent-win 3/6] vdservice: clean agent proc handle in kill_agent()

2011-07-24 Thread Arnon Gilboa
prevent usage of a dead proc handle in the WaitFor() --- vdservice/vdservice.cpp | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index 7ca9db8..f61c318 100644 --- a/vdservice/vdservice.cpp +++ b/vdservice/vdservic

[Spice-devel] [PATCH vdagent-win 2/6] vdservice: use overlap ConnectNamedPipe() in launch_agent()

2011-07-24 Thread Arnon Gilboa
passing NULL is buggy when pipe opened with FILE_FLAG_OVERLAPPED --- vdservice/vdservice.cpp | 28 ++-- 1 files changed, 22 insertions(+), 6 deletions(-) diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp index 4d4937f..7ca9db8 100644 --- a/vdservice/vdservic

[Spice-devel] [PATCH vdagent-win 1/6] vdservice: add control events RHBZ #719140 #722980

2011-07-24 Thread Arnon Gilboa
prevent race between service control manager (SCM) & the service main thread. use events for stop, logon, agent restart. --- vdservice/vdservice.cpp | 70 +- 1 files changed, 44 insertions(+), 26 deletions(-) diff --git a/vdservice/vdservice.cpp b/vds

[Spice-devel] [PATCH vdagent-win 0/6] fix agent breaking on session change RHBZ #719140 #722980

2011-07-24 Thread Arnon Gilboa
Arnon Gilboa (6): vdservice: add control events RHBZ #719140 #722980 vdservice: use overlap ConnectNamedPipe() in launch_agent() vdservice: clean agent proc handle in kill_agent() vdservice: extract init_vdi_port() vdagent: remove whitespaces vdagent: add casting vdagent/desktop_layou

Re: [Spice-devel] [PATCH] fix typo in client/cmd_line_parser.cpp

2011-07-24 Thread Alon Levy
On Sun, Jul 24, 2011 at 03:35:43PM +0800, Liang Guo wrote: > Fix typo in client/cmd_line_parser.cpp can you resend as a proper input to git am? assuming you are using the git repository, and your commited a patch for each typo, do a "git format-patch HEAD^^" and send the resulting 0001* and 0002*

Re: [Spice-devel] About spice multiarch support

2011-07-24 Thread Alon Levy
On Sun, Jul 24, 2011 at 03:04:32PM +0800, Liang Guo wrote: > Hi, All > > SPICE only support x86 and x86_64 platrorm now, it looks there are > only very little asm code, do you have any plan to support other > architecture ? > It is possible to run a spice client on arm with very little modifica

Re: [Spice-devel] Win7 Guest system hangs while doing shutdown...

2011-07-24 Thread Arnon Gilboa
Naga Mohan Pothula wrote: Hi, Launched windows7 Guest image with Spice v0.8 in fullscreen mode with auto-config from windows client. Spice window hangs frequently while doing shutdown or restart. if it doesn't hang then shutdown process is slow. This issue doesn't happen if we don't launch in f

[Spice-devel] [PATCH] Fix typo in client/x11/record.cpp

2011-07-24 Thread Liang Guo
Fix typo in client/x11/record.cpp: treshold -> threshold --- a/client/x11/record.cpp +++ b/client/x11/record.cpp @@ -179,7 +179,7 @@ } if ((err = snd_pcm_sw_params_set_start_threshold(_pcm, _sw_params, frame_size)) < 0) { -LOG_ERROR("cannot set start treshold %s", snd_str

[Spice-devel] [PATCH] fix typo in client/cmd_line_parser.cpp

2011-07-24 Thread Liang Guo
Fix typo in client/cmd_line_parser.cpp seperator -> separator --- a/client/cmd_line_parser.cpp +++ b/client/cmd_line_parser.cpp @@ -140,7 +140,7 @@ } if (!ispunct(seperator)) { -THROW("invalid seperator"); +THROW("invalid separator"); } Option* opt = fi

[Spice-devel] About spice multiarch support

2011-07-24 Thread Liang Guo
Hi, All SPICE only support x86 and x86_64 platrorm now, it looks there are only very little asm code, do you have any plan to support other architecture ? Thanks, -- Liang Guo http://bluestone.cublog.cn ___ Spice-devel mailing list Spice-devel@lists.f