re: CVS commit: src/usr.sbin/npf/npfctl

2018-09-21 Thread matthew green
> >> Modified Files: > >>src/usr.sbin/npf/npfctl: npf.conf.5 > >> > >> Log Message: > >> Switch back to tabs, it was nicer this way. > > > > now these examples *really* overflow 80 lines, vs only just. > > > > can you try fix this? thanks. > > Even with whitespaces there were overflows. > >

Re: CVS commit: src/usr.sbin/npf/npfctl

2018-09-21 Thread Maxime Villard
Le 19/09/2018 à 20:44, matthew green a écrit : "Maxime Villard" writes: Module Name:src Committed By: maxv Date: Wed Sep 19 15:36:12 UTC 2018 Modified Files: src/usr.sbin/npf/npfctl: npf.conf.5 Log Message: Switch back to tabs, it was nicer this way. now these example

re: CVS commit: src/usr.sbin/npf/npfctl

2018-09-19 Thread matthew green
"Maxime Villard" writes: > Module Name: src > Committed By: maxv > Date: Wed Sep 19 15:36:12 UTC 2018 > > Modified Files: > src/usr.sbin/npf/npfctl: npf.conf.5 > > Log Message: > Switch back to tabs, it was nicer this way. now these examples *really* overflow 80 lines, vs only jus

Re: CVS commit: src/usr.sbin/npf/npfctl

2018-09-01 Thread Maxime Villard
Le 01/09/2018 à 18:28, Mindaugas Rasiukevicius a écrit : Module Name:src Committed By: rmind Date: Sat Sep 1 16:28:57 UTC 2018 Modified Files: src/usr.sbin/npf/npfctl: npf.conf.5 Log Message: npf.conf(5): fix some of the previous incorrect or inaccurate changes. The TCP

Re: CVS commit: src/usr.sbin/npf/npfctl

2014-12-26 Thread Martin Husemann
On Fri, Dec 26, 2014 at 09:40:54PM +, Christos Zoulas wrote: > In article <20141226204438.c525...@cvs.netbsd.org>, > Mindaugas Rasiukevicius wrote: > > >+if (modctl(MODCTL_LOAD, &args) != 0 && errno != EEXIST) { > >+fprintf(stderr, "WARNING: bpfjit is not loaded; " > >+

Re: CVS commit: src/usr.sbin/npf/npfctl

2014-12-26 Thread Christos Zoulas
In article <20141226204438.c525...@cvs.netbsd.org>, Mindaugas Rasiukevicius wrote: >+ if (modctl(MODCTL_LOAD, &args) != 0 && errno != EEXIST) { >+ fprintf(stderr, "WARNING: bpfjit is not loaded; " >+ "this may have severe impact on performance."); This is too m

Re: CVS commit: src/usr.sbin/npf/npfctl

2013-11-19 Thread Christos Zoulas
In article <20131119213306.88c0114a...@mail.netbsd.org>, Mindaugas Rasiukevicius wrote: >"Christos Zoulas" wrote: >> Module Name: src >> Committed By:christos >> Date:Tue Nov 19 17:01:45 UTC 2013 >> >> Modified Files: >> src/usr.sbin/npf/npfctl: npf_show.c >> >> Lo

Re: CVS commit: src/usr.sbin/npf/npfctl

2013-11-19 Thread Mindaugas Rasiukevicius
"Christos Zoulas" wrote: > Module Name: src > Committed By: christos > Date: Tue Nov 19 17:01:45 UTC 2013 > > Modified Files: > src/usr.sbin/npf/npfctl: npf_show.c > > Log Message: > CID 1129614: dereference after null > It should never be NULL. Perhaps assert(tl != NULL)? --

Re: CVS commit: src/usr.sbin/npf/npfctl

2012-10-31 Thread Martin Husemann
On Wed, Oct 31, 2012 at 09:38:09AM +, Iain Hibbert wrote: > how can it, when "&nct" is passed to external function ioctl() before > potentially looping back? the structure contents may have changed.. I see - and indeed moving "again:" down stops it from complaining. I apologize, apparently it

Re: CVS commit: src/usr.sbin/npf/npfctl

2012-10-31 Thread Iain Hibbert
On Wed, 31 Oct 2012, Martin Husemann wrote: > Module Name: src > Committed By: martin > Date: Wed Oct 31 08:54:39 UTC 2012 > > Modified Files: > src/usr.sbin/npf/npfctl: npfctl.c > > Log Message: > gcc 4.1 is not smart enough to notice "arg" is only used when initialized > correctly

Re: CVS commit: src/usr.sbin/npf/npfctl

2011-03-23 Thread Jukka Ruohonen
On Tue, Mar 22, 2011 at 04:51:11PM +, Mindaugas Rasiukevicius wrote: > Thanks for improvements. However, I wanted to make performance note > visible enough. Can you please leave it as a paragraph? It was left as a paragraph. I put it back as PERFORMANCE, although such notes usually go to CAV

Re: CVS commit: src/usr.sbin/npf/npfctl

2011-03-22 Thread Mindaugas Rasiukevicius
"Jukka Ruohonen" wrote: > Module Name: src > Committed By: jruoho > Date: Tue Mar 22 07:40:10 UTC 2011 > > Modified Files: > src/usr.sbin/npf/npfctl: npfctl.8 > > Log Message: > Use 'offset indent' for the list of commands. Emphasize valid commands. > Remove PERFORMANCE (too small