On Fri, Dec 26, 2014 at 09:40:54PM +0000, Christos Zoulas wrote:
> In article <20141226204438.c525...@cvs.netbsd.org>,
> Mindaugas Rasiukevicius <source-changes-d@NetBSD.org> wrote:
> 
> >+    if (modctl(MODCTL_LOAD, &args) != 0 && errno != EEXIST) {
> >+            fprintf(stderr, "WARNING: bpfjit is not loaded; "
> >+                "this may have severe impact on performance.");
> 
> This is too much magic I think, and in either case it should be:
> 
>       warn("autoloading bpfjit failed; "
>           "performance will severely be degraded");
> 
> So that the reason and the program name are printed...

Note that bpfjit is not yet available on many architectures - so this might
be scary and hard to fix by the user (can we formally call it a degradition
in that case at all?)

Martin

Reply via email to