Re: CVS commit: src/usr.sbin/envstat

2012-12-17 Thread Christos Zoulas
In article , Iain Hibbert wrote: > >I didn't understand it, in any case.. can you explain why, in C, when >exit() explicitly closes all open file descriptors and releases any memory >etc (see a detailed list in exit(3) and _exit(3)), there might be a >benefit in doing so formally before calling e

Re: CVS commit: src/usr.sbin/envstat

2012-12-17 Thread Iain Hibbert
On Sun, 16 Dec 2012, David Holland wrote: > On Fri, Dec 14, 2012 at 06:18:57PM +0100, Marc Balmer wrote: > > proper resource management is a good thing - if the code continues > > to run. In this case, where the program exits, there no benefit > > from freeing up memory etc. > > Buncombe. is t

Re: CVS commit: src/usr.sbin/envstat

2012-12-16 Thread David Holland
On Fri, Dec 14, 2012 at 06:18:57PM +0100, Marc Balmer wrote: > Similarly it just isn't worth trying to free resources prior > to program exit. Have you ever waited while a big C++ program > runs all its destructors, paging in code and data just to exit! > >>> > >>> Depends, it

Re: CVS commit: src/usr.sbin/envstat

2012-12-14 Thread Jukka Ruohonen
On Fri, Dec 14, 2012 at 06:18:57PM +0100, Marc Balmer wrote: > > Ironically, proper ressource managements tends to make it much easier to > > fulfill at least two of the three items... > > proper resource management is a good thing - if the code continues to run. > In this case, where the program

Re: CVS commit: src/usr.sbin/envstat

2012-12-14 Thread Marc Balmer
Am 14.12.2012 um 18:05 schrieb Joerg Sonnenberger : > On Fri, Dec 14, 2012 at 05:51:44PM +0100, Marc Balmer wrote: >> >> >> Am 14.12.2012 um 17:07 schrieb Joerg Sonnenberger : >> >>> On Fri, Dec 14, 2012 at 08:59:37AM +, David Laight wrote: Similarly it just isn't worth trying to free

Re: CVS commit: src/usr.sbin/envstat

2012-12-14 Thread Joerg Sonnenberger
On Fri, Dec 14, 2012 at 05:51:44PM +0100, Marc Balmer wrote: > > > Am 14.12.2012 um 17:07 schrieb Joerg Sonnenberger : > > > On Fri, Dec 14, 2012 at 08:59:37AM +, David Laight wrote: > >> Similarly it just isn't worth trying to free resources prior > >> to program exit. Have you ever waited

Re: CVS commit: src/usr.sbin/envstat

2012-12-14 Thread Marc Balmer
Am 14.12.2012 um 17:07 schrieb Joerg Sonnenberger : > On Fri, Dec 14, 2012 at 08:59:37AM +, David Laight wrote: >> Similarly it just isn't worth trying to free resources prior >> to program exit. Have you ever waited while a big C++ program >> runs all its destructors, paging in code and dat

Re: CVS commit: src/usr.sbin/envstat

2012-12-14 Thread Joerg Sonnenberger
On Fri, Dec 14, 2012 at 08:59:37AM +, David Laight wrote: > Similarly it just isn't worth trying to free resources prior > to program exit. Have you ever waited while a big C++ program > runs all its destructors, paging in code and data just to exit! Depends, it makes tools like valgrind a lot

Re: CVS commit: src/usr.sbin/envstat

2012-12-14 Thread David Laight
On Thu, Dec 13, 2012 at 08:45:02PM -0800, Paul Goyette wrote: > It seems that the following commit has introduced a regression for the > dev/sysmon/t_swsensor atf tests (for details, see test results at > http://screamer.whooppee.com/amd64-results/4722_1_atf.html) > > >Module Name:src > >Com

Re: CVS commit: src/usr.sbin/envstat

2012-12-13 Thread Paul Goyette
It seems that the following commit has introduced a regression for the dev/sysmon/t_swsensor atf tests (for details, see test results at http://screamer.whooppee.com/amd64-results/4722_1_atf.html) Module Name:src Committed By: christos Date: Thu Dec 13 20:06:42 UTC 2012 Modifi

Re: CVS commit: src/usr.sbin/envstat

2012-12-13 Thread Paul Goyette
On Fri, 14 Dec 2012, Jukka Ruohonen wrote: On Thu, Dec 13, 2012 at 11:53:24AM -0800, Paul Goyette wrote: While we're making sure to free() things, should we not also defend against memory leaks in the case where an option is used more than once? While we are here, I wonder why sysmon(9) does

Re: CVS commit: src/usr.sbin/envstat

2012-12-13 Thread Warner Losh
On Dec 13, 2012, at 4:30 PM, John Nemeth wrote: > On Mar 31, 12:00am, Paul Goyette wrote: > } > } > Module Name:src > } > Committed By: christos > } > Date: Thu Dec 13 19:31:25 UTC 2012 > } > > } > Modified Files: > } > src/usr.sbin/envstat: envstat.c > } > } > Log Messag

Re: CVS commit: src/usr.sbin/envstat

2012-12-13 Thread John Nemeth
On Mar 31, 12:00am, Paul Goyette wrote: } } > Module Name:src } > Committed By: christos } > Date: Thu Dec 13 19:31:25 UTC 2012 } > } > Modified Files: } > src/usr.sbin/envstat: envstat.c } } > Log Message: } > PR/47316: Henning Petersen: Memory leak in envstat with config

Re: CVS commit: src/usr.sbin/envstat

2012-12-13 Thread Jukka Ruohonen
On Thu, Dec 13, 2012 at 11:53:24AM -0800, Paul Goyette wrote: > While we're making sure to free() things, should we not also defend > against memory leaks in the case where an option is used more than once? While we are here, I wonder why sysmon(9) does not follow the common guidelines w.r.t. for

Re: CVS commit: src/usr.sbin/envstat

2012-12-13 Thread Paul Goyette
Module Name:src Committed By: christos Date: Thu Dec 13 19:31:25 UTC 2012 Modified Files: src/usr.sbin/envstat: envstat.c Log Message: PR/47316: Henning Petersen: Memory leak in envstat with config file. While we're making sure to free() things, should we not also def

re: CVS commit: src/usr.sbin/envstat

2011-06-04 Thread Paul Goyette
On Sun, 5 Jun 2011, matthew green wrote: Module Name:src Committed By: pgoyette Date: Sat Jun 4 13:29:03 UTC 2011 Modified Files: src/usr.sbin/envstat: envstat.c Log Message: Since there is no longer a value-avg property, remove the code that extracts it. what's th

re: CVS commit: src/usr.sbin/envstat

2011-06-04 Thread matthew green
> Module Name: src > Committed By: pgoyette > Date: Sat Jun 4 13:29:03 UTC 2011 > > Modified Files: > src/usr.sbin/envstat: envstat.c > > Log Message: > Since there is no longer a value-avg property, remove the code that > extracts it. what's the behaviour of old envstat and new