Re: CVS commit: src/usr.bin/make

2024-01-25 Thread Simon Gerraty
On Thu, 25 Jan 2024 20:02:00 +0100, Roland Illig writes: >>> Modified Files: >>> src/usr.bin/make: make.1 >>> >>> Log Message: >>> Indicate that for :U newval is optional >> >> I think this is more confusing than helpful. > >I agree. Make doesn't distinguish between an empty string and an absen

Re: CVS commit: src/usr.bin/make

2024-01-25 Thread Simon Gerraty
On Thu, 25 Jan 2024 21:12:20 +0100, Roland Illig writes: >them all. Due to this, I'd go with: > >> .It Cm \&:U\| Ns Ar newval >> If the variable is undefined, >> .Ar newval >> (which may be empty) is the value. That's almost exactly what I had in my 1st cut ;-) Will do. >Then, add the same wordin

Re: Detecting typos in makefiles (was: Re: CVS commit: src/share/mk)

2023-01-15 Thread Simon Gerraty
On Sun, 15 Jan 2023 19:14:14 +0100, Roland Illig writes: >It is really unfortunate that make didn't catch this typo by itself. > >.if ${MACHINE_ARCH} =3D=3D "x86_64" || \ > ${MACHINE_ARCH} =3D=3D "i386" || \ > ${MACHINE_ARCH} =3D=3D "alpha" || \\ > !empty(MACHINE_ARCH:Maarch64*) || \ >

Re: CVS commit: src/usr.bin/make

2022-01-30 Thread Simon Gerraty
On Sun, 30 Jan 2022 14:54:25 -0500, Christos Zoulas writes: >> Since usr.bin/make is also used in tools/make, it needs to follow the >> rules in tools/README, which say that all tools should stick to C89. >> The format specifier %zu comes from C99 though. > >Yes, %zu is annoying because windows doe