On Sun, 30 Jan 2022 14:54:25 -0500, Christos Zoulas writes: >> Since usr.bin/make is also used in tools/make, it needs to follow the >> rules in tools/README, which say that all tools should stick to C89. >> The format specifier %zu comes from C99 though. > >Yes, %zu is annoying because windows does not have it either (until very >recently I think). But cygwin does have it(?) so there is no issue?
size_t is annoying ;-) >> Or can we drop the C89 rule from tools/README? In the past few years, >> usr.bin/make used several features from C99 (end-of-line comments, = >long >> long, %zu, snprintf), and nobody cared to fix the C99-isms, so either >> nobody needed the C89 restriction or we simply ignored the complaints. > >I think that we should ask in tech-toolchain. Yes, I prefer to require = >c99 >at this point. For bmake I have converted the %zu to %u. I no longer have access to even a tiny fraction of the systems bmake is used on, but I recall %z being an issue in the past. I cannot find docs on gcc-2.95 (which is the oldest compiler I've recently had to use to port bmake), and the license for that VM has expired, it probably should support c99 but I cannot confirm. --sjg
