lint: constant in conditional (was: Re: CVS commit: src/sys/sys)

2025-04-05 Thread Roland Illig
Am 06.04.2025 um 03:24 schrieb Taylor R Campbell: >> Date: Sat, 5 Apr 2025 19:18:20 +0200 >> From: Roland Illig >> >> Would it be narrow enough to add /*CONSTCOND*/ to the definition of >> ALIGNED_POINTER on i386 and amd64? Or would you consider this still too >> broad? > > Might be reasonable. B

Re: CVS commit: src/lib/librumpuser

2025-04-05 Thread Taylor R Campbell
> Module Name:src > Committed By: martin > Date: Wed Apr 2 07:25:42 UTC 2025 > > Modified Files: > src/lib/librumpuser: sp_common.c > > Log Message: > Revert accidental local test change from previous - the DEBUG define > is passed on the command line already. FYI, this

Re: CVS commit: src/sys/sys

2025-04-05 Thread Taylor R Campbell
> Date: Sat, 5 Apr 2025 19:18:20 +0200 > From: Roland Illig > > Would it be narrow enough to add /*CONSTCOND*/ to the definition of > ALIGNED_POINTER on i386 and amd64? Or would you consider this still too > broad? Might be reasonable. But then we have a lot of predicates that might be used in

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-05 Thread Nat Sloss
On Fri, 4 Apr 2025 23:27:49 Martin Husemann wrote: > On Fri, Apr 04, 2025 at 10:48:17PM +1100, Nat Sloss wrote: > > The changes to the context switch in sys/m68k have been reverted and the > > nop insertion by gas(1) has been turned off by default. > > What does upstream gcc plan to do with the ne

CVS commit: src/sys/sys

2025-04-05 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 29 15:48:26 UTC 2025 Modified Files: src/sys/sys: cdefs.h Log Message: __predict_true/false: Make these work with C++ too. Should fix build after recent assert.h change. error: no match for `operator!=' (operand types

CVS commit: src/tools/mandoc

2025-04-05 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Wed Mar 26 18:41:54 UTC 2025 Modified Files: src/tools/mandoc: Makefile Log Message: don't define _OPENBSD_SOURCE from the command line; it is defined again in the generated config.h To generate a diff of this commit: cvs rdif

CVS commit: src/tests/lib/libc/gen

2025-04-05 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Fri Mar 28 22:51:58 UTC 2025 Modified Files: src/tests/lib/libc/gen: t_ctype.c Log Message: t_ctype: Include UCHAR_MAX in the range of inputs tested. It should definitely be included because it is important to distinguish it f

CVS commit: src/distrib/sets/lists/base

2025-04-05 Thread Robert Elz
Module Name:src Committed By: kre Date: Wed Mar 26 17:36:16 UTC 2025 Modified Files: src/distrib/sets/lists/base: mi Log Message: tzdata update to 2025b Added zoneinfo files: America/Coyhaique To generate a diff of this commit: cvs rdiff -u -r1.1364 -r1.1365 src/

CVS commit: src/lib/libc

2025-04-05 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Mar 30 16:17:05 UTC 2025 Modified Files: src/lib/libc: Makefile src/lib/libc/gen: ctype_guard.h Log Message: ctype(3): Actually conditionalize guard page on shared libc. Apparently we build the libc .o files with -

CVS commit: src/sys

2025-04-05 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 31 14:45:35 UTC 2025 Modified Files: src/sys/arch/mips/ralink: ralink_ehci.c src/sys/dev/cardbus: ehci_cardbus.c src/sys/dev/pci: ehci_pci.c usb_pci.c Log Message: ehci(4): Sprinkle KERNEL_LOCKED_P and K

CVS commit: src/sys/arch/vax

2025-04-05 Thread Hans Rosenfeld
Module Name:src Committed By: hans Date: Sat Mar 22 10:37:19 UTC 2025 Modified Files: src/sys/arch/vax/include: db_machdep.h src/sys/arch/vax/vax: db_disasm.c db_machdep.c trap.c Log Message: vax/ddb(4): clean up machine dependent code and improve usability First,

CVS commit: src/sys/arch/m68k/m68k

2025-04-05 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Sun Mar 30 04:44:26 UTC 2025 Modified Files: src/sys/arch/m68k/m68k: switch_subr.s Log Message: Sprinkle nop. This is the kernel part of addressing the issue with fpu emulation on lc040 cpus. The idea is that we might be switch fro

CVS commit: src/crypto/external/bsd/openssh/dist

2025-04-05 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Fri Mar 21 14:05:14 UTC 2025 Modified Files: src/crypto/external/bsd/openssh/dist: auth2.c Log Message: PR/59201: Jose Luis Duran: Remove leftover header To generate a diff of this commit: cvs rdiff -u -r1.32 -r1.33 src/crypto

CVS commit: src/external/gpl3/gcc/dist/libsanitizer/sanitizer_common

2025-04-05 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sat Mar 22 17:04:55 UTC 2025 Modified Files: src/external/gpl3/gcc/dist/libsanitizer/sanitizer_common: sanitizer_flags.inc Log Message: Allow addr2line (or llvm_symbolizer to run by default) to print stack traces.

CVS commit: src/sys/arch/m68k/m68k

2025-04-05 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Mon Mar 31 13:03:23 UTC 2025 Modified Files: src/sys/arch/m68k/m68k: switch_subr.s Log Message: Wrap up lc040 compatability nops in a macro. Also add a comment describing why they are there so they wont be accidently removed in the

CVS commit: src/external/bsd/blocklist/bin

2025-04-05 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Wed Mar 26 17:09:35 UTC 2025 Modified Files: src/external/bsd/blocklist/bin: blocklistd.c Log Message: Also initialize conf (jlduran) To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/external/bsd/blocklist/bin/

CVS commit: src/usr.bin/make

2025-04-05 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Mar 29 16:44:14 UTC 2025 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: moderrs.exp moderrs.mk vardebug.exp vardebug.mk varmod-edge.exp varmod-edge.mk varmod-indirect.exp va

CVS commit: src/sys/arch/evbarm/conf

2025-04-05 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Mar 27 12:23:19 UTC 2025 Modified Files: src/sys/arch/evbarm/conf: GENERIC64 Log Message: evbarm/GENERIC64: Enable vio9p(4). Tested under qemu. PR kern/59211: vio9p(4): missing from various GENERICs and MAKEDEVs To gene

CVS commit: [netbsd-10] src/share/installboot/evbarm

2025-04-05 Thread Martin Husemann
Module Name:src Committed By: martin Date: Sat Mar 29 11:09:47 UTC 2025 Modified Files: src/share/installboot/evbarm [netbsd-10]: boards.plist Log Message: Pull up following revision(s) (requested by gutteridge in ticket #1078): share/installboot/evbarm/boards.pli

CVS commit: src/sys/arch/evbarm/conf

2025-04-05 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Mar 27 12:23:19 UTC 2025 Modified Files: src/sys/arch/evbarm/conf: GENERIC64 Log Message: evbarm/GENERIC64: Enable vio9p(4). Tested under qemu. PR kern/59211: vio9p(4): missing from various GENERICs and MAKEDEVs To gene

CVS commit: [netbsd-10] src/share/installboot/evbarm

2025-04-05 Thread Martin Husemann
Module Name:src Committed By: martin Date: Sat Mar 29 11:09:47 UTC 2025 Modified Files: src/share/installboot/evbarm [netbsd-10]: boards.plist Log Message: Pull up following revision(s) (requested by gutteridge in ticket #1078): share/installboot/evbarm/boards.pli

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-05 Thread Nathanial Sloss
On Mon, 31 Mar 2025 22:48:39 Tetsuya Isaki wrote: > At Sun, 30 Mar 2025 04:44:26 +, > > Nathanial Sloss wrote: > > Module Name:src > > Committed By: nat > > Date: Sun Mar 30 04:44:26 UTC 2025 > > > > Modified Files: > > src/sys/arch/m68k/m68k: switch_subr.s > >

CVS commit: src/share/man/man3

2025-04-05 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Mar 26 14:12:16 UTC 2025 Modified Files: src/share/man/man3: CMSG_DATA.3 Log Message: cmsg(3): Clarify guarantees about CMSG_SPACE/LEN constancy. Add some line breaks while here to break up walls of text so it's easier to

CVS commit: src/tests/fs/tmpfs

2025-04-05 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Fri Mar 21 16:39:30 UTC 2025 Modified Files: src/tests/fs/tmpfs: t_vnd.sh Log Message: Add a label because on sun a sunlabel with all zeros has no partitions. To generate a diff of this commit: cvs rdiff -u -r1.14 -r1.15 src/t

CVS commit: src/sys/dev/usb

2025-04-05 Thread Hans Rosenfeld
Module Name:src Committed By: hans Date: Sun Mar 23 12:07:24 UTC 2025 Modified Files: src/sys/dev/usb: uts.c Log Message: uts(4): make sure the device is enabled before calling uhidev_close() This check was already there, but only enabled for DIAGNOSTIC kernels. The check

CVS commit: src/tools/mandoc

2025-04-05 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Wed Mar 26 18:41:54 UTC 2025 Modified Files: src/tools/mandoc: Makefile Log Message: don't define _OPENBSD_SOURCE from the command line; it is defined again in the generated config.h To generate a diff of this commit: cvs rdif

CVS commit: src/tests/net/if_vlan

2025-04-05 Thread Ryota Ozaki
Module Name:src Committed By: ozaki-r Date: Tue Mar 18 07:57:34 UTC 2025 Modified Files: src/tests/net/if_vlan: t_vlan.sh Log Message: tests: dedup t_vlan.sh like others (NFC) To generate a diff of this commit: cvs rdiff -u -r1.25 -r1.26 src/tests/net/if_vlan/t_vlan.sh

Re: CVS commit: src/usr.bin/make

2025-04-05 Thread Roland Illig
Am 30.03.2025 um 11:51 schrieb Roland Illig: > Module Name: src > Committed By: rillig > Date: Sun Mar 30 09:51:51 UTC 2025 > > Modified Files: > src/usr.bin/make: parse.c > src/usr.bin/make/unit-tests: ... > > Log Message: > make: use '"filename" line 123' for locations instea

CVS commit: src/external/gpl3/gcc/lib

2025-04-05 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Mar 23 18:56:43 UTC 2025 Modified Files: src/external/gpl3/gcc/lib: preinit.mk Log Message: Use ${LIBDIR} so that the compat build works. To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/external/gpl3/gcc/li

CVS commit: src/sys/kern

2025-04-05 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Thu Mar 20 15:18:43 UTC 2025 Modified Files: src/sys/kern: kern_module.c Log Message: And fix the formatting. /me needs to stop committing when severely sleep-deprived To generate a diff of this commit: cvs rdiff -u -r1.166 -

Re: CVS commit: src/sys/sys

2025-04-05 Thread Roland Illig
Am 05.04.2025 um 02:07 schrieb Taylor R Campbell: >> Module Name:src >> Committed By: rillig >> Date: Fri Apr 4 20:52:32 UTC 2025 >> >> Modified Files: >> src/sys/sys: cdefs.h >> >> Log Message: >> sys/cdefs.h: fix __predict_true and __predict_false for lint >> >> -#define

CVS commit: src/sys/kern

2025-04-05 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Thu Mar 20 15:18:43 UTC 2025 Modified Files: src/sys/kern: kern_module.c Log Message: And fix the formatting. /me needs to stop committing when severely sleep-deprived To generate a diff of this commit: cvs rdiff -u -r1.166 -

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-05 Thread Tetsuya Isaki
At Tue, 1 Apr 2025 02:26:35 +1100, Nathanial Sloss wrote: > Consider the following (including my gas patch for binutils): > > movq. > nop > fnop > > Thats as it's assembled but at run time it could posslibly > run like this > > movq > nop > (switch task) > fnop > > So the nops are inser

CVS commit: src/sys/kern

2025-04-05 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Thu Mar 20 13:24:06 UTC 2025 Modified Files: src/sys/kern: kern_module.c Log Message: Be consistent in formatting `module' names in diagnostic messages NFCI To generate a diff of this commit: cvs rdiff -u -r1.163 -r1.164 src/

CVS commit: src/sys/dev/wscons

2025-04-05 Thread Hans Rosenfeld
Module Name:src Committed By: hans Date: Sun Mar 23 12:09:05 UTC 2025 Modified Files: src/sys/dev/wscons: wskbd.c Log Message: wskbd(4): fix bogus DIAGNOSTIC checks Similar to uts(4) and ums(4), these checks should be done always, and the only thing DIAGNOSTIC about them

CVS commit: src

2025-04-05 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 29 01:06:37 UTC 2025 Modified Files: src/lib/libc/gen: isctype.c src/tests/lib/libc/gen: t_ctype.c Log Message: ctype(3): Summon a demon from caller's nose if abused out-of-line. This way, applications which op

CVS commit: src/sys/kern

2025-04-05 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Fri Mar 21 07:09:58 UTC 2025 Modified Files: src/sys/kern: kern_module.c Log Message: Consistently capitalize the beginning of a kernel message. NFCI To generate a diff of this commit: cvs rdiff -u -r1.167 -r1.168 src/sys/ker

Re: CVS commit: src/external/gpl3/binutils/dist/gas/config

2025-04-05 Thread Martin Husemann
On Thu, Apr 03, 2025 at 11:48:26AM +, Nathanial Sloss wrote: > Module Name: src > Committed By: nat > Date: Thu Apr 3 11:48:26 UTC 2025 > > Modified Files: > src/external/gpl3/binutils/dist/gas/config: tc-m68k.c > > Log Message: > Compiler support for buggy early revision 68LC

CVS commit: src/sys/external/bsd/drm2/dist/drm/nouveau

2025-04-05 Thread Emmanuel
Module Name:src Committed By: joe Date: Sun Mar 23 17:04:10 UTC 2025 Modified Files: src/sys/external/bsd/drm2/dist/drm/nouveau: nouveau_bo.c Log Message: safety: fix memory leak in drm use error lable to free and return on error To generate a diff of this commit: cvs rd

CVS commit: src/usr.bin/make

2025-04-05 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sun Mar 30 01:09:41 UTC 2025 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: varmod-assign.exp varmod-assign.mk Log Message: make: add details to error message for the "::=" modifier The previous erro

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-05 Thread Martin Husemann
On Sat, Apr 05, 2025 at 10:47:39PM +1100, Nat Sloss wrote: > nop > fnop > > could be executed as > > nop > (context swtich) > (return from context swtich) > fnop > > So without these the fnop would not be coverted. Not sure what you mean here. Why would the nop before the rte make any differen

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-05 Thread Nat Sloss
On Sat, 5 Apr 2025 22:32:10 Martin Husemann wrote: > On Sat, Apr 05, 2025 at 10:01:37PM +1100, Nat Sloss wrote: > > Following advice and following the spirit of my intentions adding nop in > > the switch i added nops before "rte" in locore.s in sys/mac68k as > > opposed to m68k/swicher. > > This m

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-05 Thread Martin Husemann
On Sat, Apr 05, 2025 at 10:01:37PM +1100, Nat Sloss wrote: > Following advice and following the spirit of my intentions adding nop in the > switch i added nops before "rte" in locore.s in sys/mac68k as opposed to > m68k/swicher. This makes no sense to me (but I can only guess how the exact bug w

Re: CVS commit: src/sys/arch/m68k/m68k

2025-04-05 Thread Nat Sloss
Following advice and following the spirit of my intentions adding nop in the switch i added nops before "rte" in locore.s in sys/mac68k as opposed to m68k/swicher. Along with adding nops before fline instructions with the modified assember. I took a picture for your consideration. http://ftp.n