Re: CVS commit: src/sys/dev/pci

2019-02-06 Thread Masanobu SAITOH
On 2019/02/07 13:03, SAITOH Masanobu wrote: Module Name:src Committed By: msaitoh Date: Thu Feb 7 04:03:25 UTC 2019 Modified Files: src/sys/dev/pci: if_wm.c Log Message: Fix a bug that WOL didn't work on some chips since if_wm.c rev. 1.60. s/1.60/1.610/ Set WUC_AP

re: CVS commit: src/external/cddl/osnet/sys/sys

2019-02-06 Thread matthew green
m...@netbsd.org writes: > On Wed, Feb 06, 2019 at 12:56:57PM -0500, Christos Zoulas wrote: > D.org> > > @@ -66,7 +66,7 @@ crgetgroups(cred_t *cr) > > { > > static gid_t gids[NGROUPS_MAX]; > > I feel uncomfortable seeing unnecessary use of static. > (I find it too magical) > > What do others

Re: CVS commit: src/external/cddl/osnet/sys/sys

2019-02-06 Thread maya
On Wed, Feb 06, 2019 at 12:56:57PM -0500, Christos Zoulas wrote: D.org> > @@ -66,7 +66,7 @@ crgetgroups(cred_t *cr) > { > static gid_t gids[NGROUPS_MAX]; I feel uncomfortable seeing unnecessary use of static. (I find it too magical) What do others think? > > - memset(gids, 0, NGROUP

Re: CVS commit: src/sys/dev/usb

2019-02-06 Thread Joerg Sonnenberger
On Wed, Feb 06, 2019 at 09:15:02AM +, Rin Okuyama wrote: > Module Name: src > Committed By: rin > Date: Wed Feb 6 09:15:01 UTC 2019 > > Modified Files: > src/sys/dev/usb: if_mue.c > > Log Message: > Fix sign compare. > > > To generate a diff of this commit: > cvs rdiff -u -r

Re: CVS commit: src/sys/dev/usb

2019-02-06 Thread Rin Okuyama
Sorry for my long silence. On 2019/01/31 23:20, Robert Swindells wrote: ... The revision number of my device is "1". Robert Swindells Hmm, both of my adapters have same revision of "1": * StarTech USB21000S2 mue1 at uhub3 port 2 mue1: WS (0x424) USB Gigabit LAN (0x7500), rev 2.00/1.00, addr