On Wed, Feb 06, 2019 at 09:15:02AM +0000, Rin Okuyama wrote: > Module Name: src > Committed By: rin > Date: Wed Feb 6 09:15:01 UTC 2019 > > Modified Files: > src/sys/dev/usb: if_mue.c > > Log Message: > Fix sign compare. > > > To generate a diff of this commit: > cvs rdiff -u -r1.38 -r1.39 src/sys/dev/usb/if_mue.c
IMO casting the sizeof to int is cleaner, it will get a warning in the future if mh_len ever gets changed to size_t/unsigned. It is also the subexpression where we know for sure that the cast is safe. Joerg
