Re: CVS commit: src/sys/ufs/ffs

2015-02-15 Thread Christos Zoulas
In article <26607.1424011...@splode.eterna.com.au>, matthew green wrote: > >> > Also, I think you might want to keep the print when the >> > checksum is wrong. >> >> If we keep this print, then we keep a lot of other prints. So we don't >keep it. > >i don't follow. > >usually these messages are

re: CVS commit: src/sys/ufs/ffs

2015-02-15 Thread matthew green
> > Also, I think you might want to keep the print when the > > checksum is wrong. > > If we keep this print, then we keep a lot of other prints. So we don't keep > it. i don't follow. usually these messages are the only real indication of what is actually wrong, and they aren't log spew probl

Re: CVS commit: src/sys/ufs/ffs

2015-02-15 Thread Maxime Villard
Le 14/02/2015 20:21, David Holland a écrit : > On Sat, Feb 14, 2015 at 08:07:39AM +, Maxime Villard wrote: > > Modified Files: > >src/sys/ufs/ffs: ffs_appleufs.c > > > > Log Message: > > ffs_appleufs_validate(): > > - remove superfluous printfs > > - ensure ul_namelen!=0, otherwis