Re: CVS commit: src/sys/arch/i386/stand/lib

2010-12-24 Thread David Laight
On Sat, Dec 25, 2010 at 01:27:43AM +, Jonathan A. Kollasch wrote: > > > > > > libsa's printf(3) doesn't support %lld unless > > > -DLIBSA_PRINTF_LONGLONG_SUPPORT is specified. > > > > True, that but it's not like this code path is often compiled. > > I should probably at least add the necessa

Re: CVS commit: src/sys/arch/i386/stand/lib

2010-12-24 Thread Christos Zoulas
On Dec 25, 12:06am, jakll...@kollasch.net ("Jonathan A. Kollasch") wrote: -- Subject: Re: CVS commit: src/sys/arch/i386/stand/lib | On Fri, Dec 24, 2010 at 06:14:13PM -0500, Christos Zoulas wrote: | > On Dec 24, 11:05pm, jakll...@kollasch.net ("Jonathan A. Kollasch") wrote: | > -- Subject: Re: CVS

Re: CVS commit: src/sys/dev/pci

2010-12-24 Thread Michael
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, On Dec 24, 2010, at 5:07 AM, Izumi Tsutsui wrote: Modified Files: src/sys/dev/pci: voyagerfb.c Log Message: read 32bits instead of 64bits and truncate the upper 32bits Please stop making unnecessary changes to drivers you can't test

Re: CVS commit: src/sys/dev/pci

2010-12-24 Thread Michael
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, On Dec 24, 2010, at 5:11 AM, Christoph Egger wrote: On 24.12.10 11:07, Izumi Tsutsui wrote: Modified Files: src/sys/dev/pci: voyagerfb.c Log Message: read 32bits instead of 64bits and truncate the upper 32bits Please stop making unn

Re: CVS commit: src/sys/dev/pci

2010-12-24 Thread Michael
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, On Dec 24, 2010, at 8:51 PM, Izumi Tsutsui wrote: It is declared but not implemented. I got an 'undefined reference' linking error. Revert your change first. It's author's request and you didn't test it on hardware. No positive reason to k

Re: CVS commit: src/sys/dev/pci

2010-12-24 Thread Izumi Tsutsui
> It is declared but not implemented. I got an 'undefined reference' > linking error. Revert your change first. It's author's request and you didn't test it on hardware. No positive reason to keep it. Buildability of i386 ALL can't be an excuse in your case. You should make it defined reference i

Re: CVS commit: src/sys/arch/i386/stand/lib

2010-12-24 Thread Jonathan A. Kollasch
On Sat, Dec 25, 2010 at 12:09:43AM +, Jonathan A. Kollasch wrote: > On Sat, Dec 25, 2010 at 08:07:50AM +0900, Izumi Tsutsui wrote: > > > >Log Message: > > > >Sprinkle daddr_t. > > > >Adjust DISK_DEBUG printf formats to match. > > : > > > >-printf("warning: no disklabel in secto

Re: CVS commit: src/sys/arch/i386/stand/lib

2010-12-24 Thread Jonathan A. Kollasch
On Sat, Dec 25, 2010 at 08:07:50AM +0900, Izumi Tsutsui wrote: > > >Log Message: > > >Sprinkle daddr_t. > > >Adjust DISK_DEBUG printf formats to match. > : > > >- printf("warning: no disklabel in sector %u\n", sector); > > >+ printf("warning: no disklabel in sector %lld\n", secto

Re: CVS commit: src/sys/arch/i386/stand/lib

2010-12-24 Thread Jonathan A. Kollasch
On Fri, Dec 24, 2010 at 06:14:13PM -0500, Christos Zoulas wrote: > On Dec 24, 11:05pm, jakll...@kollasch.net ("Jonathan A. Kollasch") wrote: > -- Subject: Re: CVS commit: src/sys/arch/i386/stand/lib > > | > Are you sure this is right? My guess is that you would need PRId64 > | > instead of lld. >

RE: CVS commit: src/sys/lib/libsa

2010-12-24 Thread Paul Goyette
Module Name:src Committed By: christos Date: Fri Dec 24 23:12:29 UTC 2010 Modified Files: src/sys/lib/libsa: stand.h Log Message: panic takes a printf format too. This changes breaks the build on port-amd64: /build/netbsd-local/src/sys/arch/i386/stand/boot/biosboot/../

Re: CVS commit: src/sys/arch/i386/stand/lib

2010-12-24 Thread Christos Zoulas
On Dec 24, 11:05pm, jakll...@kollasch.net ("Jonathan A. Kollasch") wrote: -- Subject: Re: CVS commit: src/sys/arch/i386/stand/lib | > Are you sure this is right? My guess is that you would need PRId64 | > instead of lld. | | Well, maybe. But I expect int64_t will always be long long on i386. Is

Re: CVS commit: src/sys/arch/i386/stand/lib

2010-12-24 Thread Izumi Tsutsui
> >Log Message: > >Sprinkle daddr_t. > >Adjust DISK_DEBUG printf formats to match. : > >-printf("warning: no disklabel in sector %u\n", sector); > >+printf("warning: no disklabel in sector %lld\n", sector); > > #endif > > Are you sure this is right? My guess is that you wo

Re: CVS commit: src/sys/arch/i386/stand/lib

2010-12-24 Thread Jonathan A. Kollasch
On Fri, Dec 24, 2010 at 11:00:40PM +, Christos Zoulas wrote: > In article <20101224203651.e3c4117...@cvs.netbsd.org>, > Jonathan A. Kollasch wrote: > >-=-=-=-=-=- > > > >Module Name: src > >Committed By:jakllsch > >Date:Fri Dec 24 20:36:51 UTC 2010 > > > >Modified Files

Re: CVS commit: src/sys/arch/i386/stand/lib

2010-12-24 Thread Christos Zoulas
In article <20101224203651.e3c4117...@cvs.netbsd.org>, Jonathan A. Kollasch wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: jakllsch >Date: Fri Dec 24 20:36:51 UTC 2010 > >Modified Files: > src/sys/arch/i386/stand/lib: biosdisk.c biosdisk.h biosdisk_ll.c > >Log Message: >S

Re: CVS commit: src/sys/dev/pci

2010-12-24 Thread Michael
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, On Dec 24, 2010, at 11:43 AM, Christoph Egger wrote: On 24.12.10 14:11, Michael wrote: Hello, On Dec 24, 2010, at 4:13 AM, Christoph Egger wrote: On 24.12.10 00:56, Michael wrote: Hello, On Dec 23, 2010, at 4:34 PM, Christoph Egger wro

Re: CVS commit: src/external/gpl2/lvm2

2010-12-24 Thread Christos Zoulas
In article , Adam Hamsik wrote: > >Then can you please request to import these changes to upstream repository ? https://bugzilla.redhat.com/show_bug.cgi?id=665562 christos

Re: CVS commit: src/sys/arch/i386/stand

2010-12-24 Thread Jonathan A. Kollasch
On Fri, Dec 24, 2010 at 03:13:28PM +, David Laight wrote: > On Wed, Dec 22, 2010 at 08:46:43PM +, Jonathan A. Kollasch wrote: > > > > Log Message: > > It just so happens we don't need -Wno-attributes if we > > place __packed in the right place. > > Does that need __packed (which would for

Re: CVS commit: src/sys/dev/pci

2010-12-24 Thread Christoph Egger
On 24.12.10 14:11, Michael wrote: > Hello, > > On Dec 24, 2010, at 4:13 AM, Christoph Egger wrote: > >> On 24.12.10 00:56, Michael wrote: >>> Hello, >>> >>> On Dec 23, 2010, at 4:34 PM, Christoph Egger wrote: >>> Module Name:src Committed By:cegger Date:Thu Dec 23 2

Re: CVS commit: src/external/gpl2/lvm2

2010-12-24 Thread Adam Hamsik
On Dec,Friday 24 2010, at 4:50 PM, Christos Zoulas wrote: > In article , > Adam Hamsik wrote: > >>> Index: src/external/gpl2/lvm2/dist/daemons/cmirrord/functions.c >> >> This file is not even build please revert your change. >> >>> Index: src/external/gpl2/lvm2/dist/libdm/ioctl/libdm-iface.c

Re: CVS commit: src/external/gpl2/lvm2

2010-12-24 Thread Christos Zoulas
In article , Adam Hamsik wrote: >> Index: src/external/gpl2/lvm2/dist/daemons/cmirrord/functions.c > >This file is not even build please revert your change. > >> Index: src/external/gpl2/lvm2/dist/libdm/ioctl/libdm-iface.c > >This is original linux file which is not build, please revert your cha

Re: CVS commit: src/sys/arch/i386/stand

2010-12-24 Thread David Laight
On Wed, Dec 22, 2010 at 08:46:43PM +, Jonathan A. Kollasch wrote: > > Log Message: > It just so happens we don't need -Wno-attributes if we > place __packed in the right place. Does that need __packed (which would force unaligned access code) be added for all accesses, or just __attribute__((

Re: CVS commit: src/sys/dev/pci

2010-12-24 Thread Michael
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, On Dec 24, 2010, at 4:13 AM, Christoph Egger wrote: On 24.12.10 00:56, Michael wrote: Hello, On Dec 23, 2010, at 4:34 PM, Christoph Egger wrote: Module Name:src Committed By:cegger Date:Thu Dec 23 21:34:02 UTC 2010 Mod

Re: CVS commit: src/sys/dev/pci

2010-12-24 Thread Izumi Tsutsui
> The 'reg' variable is of type 'uint32_t'. > So why using bus_space_read_8() when > bus_space_read_4() gives the same result? Did you confirm if it really gave the same result? Some bus/device might require certain access size on I/O. I don't know if the device have such restriction, but "making

Re: CVS commit: src/sys/dev/pci

2010-12-24 Thread Christoph Egger
On 24.12.10 11:07, Izumi Tsutsui wrote: Modified Files: src/sys/dev/pci: voyagerfb.c >>> Log Message: read 32bits instead of 64bits and truncate the upper 32bits >>> >>> Please stop making unnecessary changes to drivers you can't test on >>> actual hardware. >> >> Sorry, sho

Re: CVS commit: src/sys/dev/pci

2010-12-24 Thread Izumi Tsutsui
> >> Modified Files: > >> src/sys/dev/pci: voyagerfb.c > > > >> Log Message: > >> read 32bits instead of 64bits and truncate the upper 32bits > > > > Please stop making unnecessary changes to drivers you can't test on > > actual hardware. > > Sorry, should have mentioned this makes the i386

Re: CVS commit: src/sys/dev/pci

2010-12-24 Thread Christoph Egger
On 24.12.10 00:56, Michael wrote: > Hello, > > On Dec 23, 2010, at 4:34 PM, Christoph Egger wrote: > >> Module Name:src >> Committed By:cegger >> Date:Thu Dec 23 21:34:02 UTC 2010 > >> Modified Files: >> src/sys/dev/pci: voyagerfb.c > >> Log Message: >> read 32bits instead o