On Dec,Friday 24 2010, at 4:50 PM, Christos Zoulas wrote: > In article <fefc4453-cdc4-4771-b16f-7f31c8555...@gmail.com>, > Adam Hamsik <haa...@gmail.com> wrote: > >>> Index: src/external/gpl2/lvm2/dist/daemons/cmirrord/functions.c >> >> This file is not even build please revert your change. >> >>> Index: src/external/gpl2/lvm2/dist/libdm/ioctl/libdm-iface.c >> >> This is original linux file which is not build, please revert your change. > > I think that the fixes are correct though, so I would prefer to ask > upstream to take them.
Then can you please request to import these changes to upstream repository ? > >> PR is about block devices not about char control devices this part >> changes /dev/mapper/control do we really want to have 640 there if yes >> I'm fine with it I just want to be sure that you wanted to do that. > > Yes that was problematic, and we needed to add permission checks > in the kernel portion. What's nice about it is that perhaps this will > allow an operator to query the state of the volumes now. > > Most of this was hashed out privately. Yeah thanks. Regards Adam.
