re: CVS commit: src/distrib/sets

2010-03-03 Thread matthew green
> > "dtrace,zfs" means "MKDTRACE=yes" *and* "MKZFS=yes" which is not what > > we want. Invent a flag "solaris" which is the or of those two flags. > > should sets be taught an or operator? Not really. In modular world, these should be represented as modules (syspkg) + de

Re: CVS commit: src/sys/dev/acpi

2010-03-03 Thread Jukka Ruohonen
On Thu, Mar 04, 2010 at 03:10:18AM +, Paul Goyette wrote: > Module Name: src > Committed By: pgoyette > Date: Thu Mar 4 03:10:18 UTC 2010 > > Modified Files: > src/sys/dev/acpi: smbus_acpi.c > > Log Message: > Replace ACPI_FREE() with AcpiOsFree() so we no longer need to defin

re: CVS commit: src/sys/kern

2010-03-03 Thread matthew green
Module Name: src Committed By:pooka Date:Wed Mar 3 17:58:37 UTC 2010 Modified Files: src/sys/kern: kern_module.c Log Message: Replace unsafe use of TAILQ_FOREACH: as the comment says, the structures are pulled off the list in the loop a

CVS commit: src/sys/dev/acpi

2010-03-03 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Thu Mar 4 03:10:18 UTC 2010 Modified Files: src/sys/dev/acpi: smbus_acpi.c Log Message: Replace ACPI_FREE() with AcpiOsFree() so we no longer need to define _COMPONENT (we don't have a bit defined for SMBUS anyway). This was u

CVS commit: src/sys/dev/acpi

2010-03-03 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Thu Mar 4 03:10:18 UTC 2010 Modified Files: src/sys/dev/acpi: smbus_acpi.c Log Message: Replace ACPI_FREE() with AcpiOsFree() so we no longer need to define _COMPONENT (we don't have a bit defined for SMBUS anyway). This was u

Re: CVS commit: src/distrib/sets

2010-03-03 Thread Masao Uebayashi
> > "dtrace,zfs" means "MKDTRACE=yes" *and* "MKZFS=yes" which is not what > > we want. Invent a flag "solaris" which is the or of those two flags. > > should sets be taught an or operator? Not really. In modular world, these should be represented as modules (syspkg) + dependency. Pretty much

Re: CVS commit: src/distrib/sets

2010-03-03 Thread Masao Uebayashi
> I specifically decided not to do that because this flag is not necessary > outside of set lists. make(1) can combine two conditions with or just fine. "MKSOLARIS" in *.mk and "solaris" in set lists should be identical. Both mean "build solaris.kmod". MKZFS (zfs.kmod) and MKDTRACE (dtrace.kmod)

Re: CVS commit: src/distrib/sets

2010-03-03 Thread Masao Uebayashi
> The solaris module provides OpenSolaris compatibility functions. Both > DTrace and ZFS are ports from OpenSolaris and rely on the solaris module > to provide some OpenSolaris functionality. Understood, thanks. In modular world, the "rely on" should be represented as a dependency. So we sho

Re: CVS commit: src/share/man/man3

2010-03-03 Thread David Holland
On Wed, Mar 03, 2010 at 12:58:33PM -0500, Greg A. Woods wrote: > I believe that __UNCONST() in particular is _never_ absolutely necessary > -- it may sometimes save a very few cycles and a few bytes of storage, > but that's the best it can do. No such luck, at least not until C grows a stronger

Re: CVS commit: src/distrib/sets

2010-03-03 Thread David Holland
On Wed, Mar 03, 2010 at 04:13:42PM +, Matthias Scheler wrote: > src/distrib/sets: mkvars.mk sets.subr > src/distrib/sets/lists/modules: mi > > Log Message: > "dtrace,zfs" means "MKDTRACE=yes" *and* "MKZFS=yes" which is not what > we want. Invent a flag "solaris" which is the or

Re: CVS commit: src/distrib/sets

2010-03-03 Thread Matthias Scheler
On 3 Mar 2010, at 16:33, Masao Uebayashi wrote: >> +mksolaris: .PHONY >> +.if (${MKDTRACE} != "no" || ${MKZFS} != "no") >> +@echo "MKSOLARIS=yes" >> +.else >> +@echo "MKSOLARIS=no" >> +.endif >> > > Could you move this to bsd.own.mk, where all the dirty work is done now? I specifically

Re: CVS commit: src/distrib/sets

2010-03-03 Thread Darran Hunt
On 4/03/2010, at 5:43 AM, Masao Uebayashi wrote: Log Message: "dtrace,zfs" means "MKDTRACE=yes" *and* "MKZFS=yes" which is not what we want. Invent a flag "solaris" which is the or of those two flags. Why is this needed ? I would rather see two flags one for zfs and one for dtrace. Becau

Re: CVS commit: src/share/man/man3

2010-03-03 Thread Joerg Sonnenberger
On Wed, Mar 03, 2010 at 12:58:33PM -0500, Greg A. Woods wrote: > I believe that __UNCONST() in particular is _never_ absolutely necessary > -- it may sometimes save a very few cycles and a few bytes of storage, > but that's the best it can do. At least one important interface would use its purpose

Re: CVS commit: src/share/man/man3

2010-03-03 Thread Greg A. Woods
At Tue, 02 Mar 2010 07:57:42 +1100, matthew green wrote: Subject: re: CVS commit: src/share/man/man3 > > >Module Name: src >Committed By: jruoho >Date: Mon Mar 1 13:44:10 UTC 2010 > >Modified Files: > src/share/man/man3: Makefile >Added File

CVS commit: src/sys/kern

2010-03-03 Thread Antti Kantee
Module Name:src Committed By: pooka Date: Wed Mar 3 17:58:37 UTC 2010 Modified Files: src/sys/kern: kern_module.c Log Message: Replace unsafe use of TAILQ_FOREACH: as the comment says, the structures are pulled off the list in the loop and it's anyone's guess where they g

CVS commit: src/sys/kern

2010-03-03 Thread Antti Kantee
Module Name:src Committed By: pooka Date: Wed Mar 3 17:58:37 UTC 2010 Modified Files: src/sys/kern: kern_module.c Log Message: Replace unsafe use of TAILQ_FOREACH: as the comment says, the structures are pulled off the list in the loop and it's anyone's guess where they g

CVS commit: src/usr.sbin/puffs/rump_lfs

2010-03-03 Thread Antti Kantee
Module Name:src Committed By: pooka Date: Wed Mar 3 17:37:01 UTC 2010 Modified Files: src/usr.sbin/puffs/rump_lfs: rump_lfs.c Log Message: Give usage() a chance. XXX: UKFS_DEVICE_ARGVPROBE() interface To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/usr

CVS commit: src/usr.sbin/puffs/rump_lfs

2010-03-03 Thread Antti Kantee
Module Name:src Committed By: pooka Date: Wed Mar 3 17:37:01 UTC 2010 Modified Files: src/usr.sbin/puffs/rump_lfs: rump_lfs.c Log Message: Give usage() a chance. XXX: UKFS_DEVICE_ARGVPROBE() interface To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/usr

Re: CVS commit: src/distrib/sets

2010-03-03 Thread Masao Uebayashi
> > Log Message: > > "dtrace,zfs" means "MKDTRACE=yes" *and* "MKZFS=yes" which is not what > > we want. Invent a flag "solaris" which is the or of those two flags. > > Why is this needed ? I would rather see two flags one for zfs and one > for dtrace. Because solaris.kmod is shared? The real que

Re: CVS commit: src/distrib/sets

2010-03-03 Thread haad
On Wed, Mar 3, 2010 at 5:13 PM, Matthias Scheler wrote: > Module Name:    src > Committed By:   tron > Date:           Wed Mar  3 16:13:42 UTC 2010 > > Modified Files: >        src/distrib/sets: mkvars.mk sets.subr >        src/distrib/sets/lists/modules: mi > > Log Message: > "dtrace,zfs" means "

Re: CVS commit: src/distrib/sets

2010-03-03 Thread Masao Uebayashi
> @@ -45,7 +45,7 @@ > > # > > -mkvars: mkvarsyesno mkextravars .PHONY > +mkvars: mkvarsyesno mkextravars mksolaris .PHONY > > mkvarsyesno: .PHONY > .for i in ${_MKVARS.yes} > @@ -59,3 +59,10 @@ > .for i in ${MKEXTRAVARS} > @echo $i="${$i}" > .endfor > + > +mksolaris: .PHONY > +

CVS commit: src/distrib/sets

2010-03-03 Thread Matthias Scheler
Module Name:src Committed By: tron Date: Wed Mar 3 16:13:42 UTC 2010 Modified Files: src/distrib/sets: mkvars.mk sets.subr src/distrib/sets/lists/modules: mi Log Message: "dtrace,zfs" means "MKDTRACE=yes" *and* "MKZFS=yes" which is not what we want. Invent a flag

CVS commit: src/distrib/sets

2010-03-03 Thread Matthias Scheler
Module Name:src Committed By: tron Date: Wed Mar 3 16:13:42 UTC 2010 Modified Files: src/distrib/sets: mkvars.mk sets.subr src/distrib/sets/lists/modules: mi Log Message: "dtrace,zfs" means "MKDTRACE=yes" *and* "MKZFS=yes" which is not what we want. Invent a flag

Re: CVS commit: src/sys/arch/xen/x86

2010-03-03 Thread Izumi Tsutsui
> OT: these are a little unclear to me. Could someone outline what > > roundup > roundup2 > rounddown > howmany They are in . >> #define howmany(x, y) (((x)+((y)-1))/(y)) how many y-byte blocks are required to store x-bytes region? >> #define roundup(x, y) x)+((y

Re: CVS commit: src/sys/arch/xen/x86

2010-03-03 Thread Jukka Ruohonen
On Wed, Mar 03, 2010 at 12:09:03AM +, Jean-Yves Migeon wrote: > Module Name: src > Committed By: jym > Date: Wed Mar 3 00:09:03 UTC 2010 > > Modified Files: > src/sys/arch/xen/x86: cpu.c > > Log Message: > Use roundup2() instead of hardcoding the CACHE_LINE_SIZE rounding > ope

CVS commit: src/distrib/sets/lists/modules

2010-03-03 Thread Matthias Scheler
Module Name:src Committed By: tron Date: Wed Mar 3 14:43:41 UTC 2010 Modified Files: src/distrib/sets/lists/modules: mi Log Message: The directory "modules/solaris" depends on ZFS as well. To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/distrib/sets/lis

CVS commit: src/distrib/sets/lists/modules

2010-03-03 Thread Matthias Scheler
Module Name:src Committed By: tron Date: Wed Mar 3 14:43:41 UTC 2010 Modified Files: src/distrib/sets/lists/modules: mi Log Message: The directory "modules/solaris" depends on ZFS as well. To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/distrib/sets/lis

CVS commit: src/distrib/sets/lists/modules

2010-03-03 Thread Matthias Scheler
Module Name:src Committed By: tron Date: Wed Mar 3 14:32:29 UTC 2010 Modified Files: src/distrib/sets/lists/modules: mi Log Message: The "solaris" kernel module also gets build if ZFS is enabled. To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/distrib/se

CVS commit: src/distrib/sets/lists/modules

2010-03-03 Thread Matthias Scheler
Module Name:src Committed By: tron Date: Wed Mar 3 14:32:29 UTC 2010 Modified Files: src/distrib/sets/lists/modules: mi Log Message: The "solaris" kernel module also gets build if ZFS is enabled. To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/distrib/se

CVS commit: src/sys/dev/raidframe

2010-03-03 Thread Greg Oster
Module Name:src Committed By: oster Date: Wed Mar 3 14:23:27 UTC 2010 Modified Files: src/sys/dev/raidframe: rf_paritymap.c Log Message: Don't attempt to read or write component label stuff from/to 'dead disks'. Update used spares with the correct parity map bits too. Ad

CVS commit: src/sys/dev/raidframe

2010-03-03 Thread Greg Oster
Module Name:src Committed By: oster Date: Wed Mar 3 14:23:27 UTC 2010 Modified Files: src/sys/dev/raidframe: rf_paritymap.c Log Message: Don't attempt to read or write component label stuff from/to 'dead disks'. Update used spares with the correct parity map bits too. Ad

CVS commit: src/share/man/man9

2010-03-03 Thread Antti Kantee
Module Name:src Committed By: pooka Date: Wed Mar 3 13:57:35 UTC 2010 Modified Files: src/share/man/man9: config.9 Log Message: update description of deffs To generate a diff of this commit: cvs rdiff -u -r1.26 -r1.27 src/share/man/man9/config.9 Please note that diffs

CVS commit: src/share/man/man9

2010-03-03 Thread Antti Kantee
Module Name:src Committed By: pooka Date: Wed Mar 3 13:57:35 UTC 2010 Modified Files: src/share/man/man9: config.9 Log Message: update description of deffs To generate a diff of this commit: cvs rdiff -u -r1.26 -r1.27 src/share/man/man9/config.9 Please note that diffs

CVS commit: src/usr.bin/config

2010-03-03 Thread Antti Kantee
Module Name:src Committed By: pooka Date: Wed Mar 3 13:56:30 UTC 2010 Modified Files: src/usr.bin/config: main.c Log Message: reflect previous change in comment To generate a diff of this commit: cvs rdiff -u -r1.39 -r1.40 src/usr.bin/config/main.c Please note that dif

CVS commit: src/usr.bin/config

2010-03-03 Thread Antti Kantee
Module Name:src Committed By: pooka Date: Wed Mar 3 13:56:30 UTC 2010 Modified Files: src/usr.bin/config: main.c Log Message: reflect previous change in comment To generate a diff of this commit: cvs rdiff -u -r1.39 -r1.40 src/usr.bin/config/main.c Please note that dif

CVS commit: src/usr.bin/config

2010-03-03 Thread Antti Kantee
Module Name:src Committed By: pooka Date: Wed Mar 3 13:53:22 UTC 2010 Modified Files: src/usr.bin/config: config.5 defs.h gram.y main.c Log Message: Remove fs_foo.h support from deffs now that nothing uses it. To generate a diff of this commit: cvs rdiff -u -r1.20 -r1.2

CVS commit: src/usr.bin/config

2010-03-03 Thread Antti Kantee
Module Name:src Committed By: pooka Date: Wed Mar 3 13:53:22 UTC 2010 Modified Files: src/usr.bin/config: config.5 defs.h gram.y main.c Log Message: Remove fs_foo.h support from deffs now that nothing uses it. To generate a diff of this commit: cvs rdiff -u -r1.20 -r1.2

CVS commit: src/sys

2010-03-03 Thread Izumi Tsutsui
Module Name:src Committed By: tsutsui Date: Wed Mar 3 13:39:58 UTC 2010 Modified Files: src/sys/arch/x68k/dev: if_ne_intio.c if_ne_neptune.c src/sys/conf: files src/sys/dev/ic: ne2000.c ne2000var.h src/sys/dev/isa: if_ne_isa.c src/sys/dev/is

CVS commit: src/sys

2010-03-03 Thread Izumi Tsutsui
Module Name:src Committed By: tsutsui Date: Wed Mar 3 13:39:58 UTC 2010 Modified Files: src/sys/arch/x68k/dev: if_ne_intio.c if_ne_neptune.c src/sys/conf: files src/sys/dev/ic: ne2000.c ne2000var.h src/sys/dev/isa: if_ne_isa.c src/sys/dev/is

CVS commit: src/lib/libterminfo

2010-03-03 Thread Roy Marples
Module Name:src Committed By: roy Date: Wed Mar 3 12:09:49 UTC 2010 Modified Files: src/lib/libterminfo: genhash genman genterms genthash Log Message: Abort an error. To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/lib/libterminfo/genhash cvs rdiff -u -r

CVS commit: src/lib/libterminfo

2010-03-03 Thread Roy Marples
Module Name:src Committed By: roy Date: Wed Mar 3 12:09:49 UTC 2010 Modified Files: src/lib/libterminfo: genhash genman genterms genthash Log Message: Abort an error. To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/lib/libterminfo/genhash cvs rdiff -u -r

CVS commit: src/sys/compat/sunos

2010-03-03 Thread Antti Kantee
Module Name:src Committed By: pooka Date: Wed Mar 3 11:08:00 UTC 2010 Modified Files: src/sys/compat/sunos: sunos_syscall.h sunos_syscallargs.h sunos_syscalls.c sunos_sysent.c Log Message: regen: ENOSYS nfssvc honestly To generate a diff of this commit: cvs

CVS commit: src/sys/compat/sunos

2010-03-03 Thread Antti Kantee
Module Name:src Committed By: pooka Date: Wed Mar 3 11:08:00 UTC 2010 Modified Files: src/sys/compat/sunos: sunos_syscall.h sunos_syscallargs.h sunos_syscalls.c sunos_sysent.c Log Message: regen: ENOSYS nfssvc honestly To generate a diff of this commit: cvs

CVS commit: src/sys/compat/sunos

2010-03-03 Thread Antti Kantee
Module Name:src Committed By: pooka Date: Wed Mar 3 11:07:17 UTC 2010 Modified Files: src/sys/compat/sunos: sunos_misc.c syscalls.master Log Message: One more overcomplex ENOSYS bites the dust. To generate a diff of this commit: cvs rdiff -u -r1.166 -r1.167 src/sys/comp

CVS commit: src/sys/compat/sunos

2010-03-03 Thread Antti Kantee
Module Name:src Committed By: pooka Date: Wed Mar 3 11:07:17 UTC 2010 Modified Files: src/sys/compat/sunos: sunos_misc.c syscalls.master Log Message: One more overcomplex ENOSYS bites the dust. To generate a diff of this commit: cvs rdiff -u -r1.166 -r1.167 src/sys/comp

CVS commit: src/sys/compat

2010-03-03 Thread Antti Kantee
Module Name:src Committed By: pooka Date: Wed Mar 3 11:02:34 UTC 2010 Modified Files: src/sys/compat/sunos32: sunos32_misc.c src/sys/compat/ultrix: ultrix_misc.c Log Message: Remove nfssvc non-emulations I missed yesterday. To generate a diff of this commit: cvs

CVS commit: src/sys/compat

2010-03-03 Thread Antti Kantee
Module Name:src Committed By: pooka Date: Wed Mar 3 11:02:34 UTC 2010 Modified Files: src/sys/compat/sunos32: sunos32_misc.c src/sys/compat/ultrix: ultrix_misc.c Log Message: Remove nfssvc non-emulations I missed yesterday. To generate a diff of this commit: cvs

CVS commit: src/sys/compat/sunos32

2010-03-03 Thread Martin Husemann
Module Name:src Committed By: martin Date: Wed Mar 3 10:56:47 UTC 2010 Modified Files: src/sys/compat/sunos32: sunos32_misc.c Log Message: Add prototype and forward declarations to make the empty nfs stub compile. To generate a diff of this commit: cvs rdiff -u -r1.69 -

CVS commit: src/sys/compat/sunos32

2010-03-03 Thread Martin Husemann
Module Name:src Committed By: martin Date: Wed Mar 3 10:56:47 UTC 2010 Modified Files: src/sys/compat/sunos32: sunos32_misc.c Log Message: Add prototype and forward declarations to make the empty nfs stub compile. To generate a diff of this commit: cvs rdiff -u -r1.69 -

CVS commit: src/sys/compat

2010-03-03 Thread Havard Eidnes
Module Name:src Committed By: he Date: Wed Mar 3 08:20:39 UTC 2010 Modified Files: src/sys/compat/common: vfs_syscalls_30.c src/sys/compat/ibcs2: ibcs2_misc.c src/sys/compat/irix: irix_dirent.c src/sys/compat/linux/common: linux_file64.c linux_misc.

CVS commit: src/sys/compat

2010-03-03 Thread Havard Eidnes
Module Name:src Committed By: he Date: Wed Mar 3 08:20:39 UTC 2010 Modified Files: src/sys/compat/common: vfs_syscalls_30.c src/sys/compat/ibcs2: ibcs2_misc.c src/sys/compat/irix: irix_dirent.c src/sys/compat/linux/common: linux_file64.c linux_misc.