On Thu, Mar 04, 2010 at 03:10:18AM +0000, Paul Goyette wrote: > Module Name: src > Committed By: pgoyette > Date: Thu Mar 4 03:10:18 UTC 2010 > > Modified Files: > src/sys/dev/acpi: smbus_acpi.c > > Log Message: > Replace ACPI_FREE() with AcpiOsFree() so we no longer need to define > _COMPONENT (we don't have a bit defined for SMBUS anyway). This was > uncovered by turning on ACPI_DEBUG for the i386 ALL kernel config. > > Reported by Greg Woods on current-users@
Well, this is wrong in the sense that the _COMPONENT definition was incorrect to begin with, and in the sense that we have explicitly tried to recently add the _COMPONENT definitions. Also: now it does BadThings(tm) if the memory tracking of ACPICA is enabled. The right solution is to e.g. "#define _COMPONENT ACPI_BUS_COMPONENT". The components that can be used are defined in <dev/acpi/acpireg.h>. But a bigger question I'd like to ask from all: do we really need to play these games with the ACPICA; why not just convert everything to use native allocators? - Jukka.
