The sprintf is deprecated in Xcode 14 because of security concerns. The issue
was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for
hotspot impl, and [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378)
for building, but the test case was not covered. The failure
On Wed, 11 Jan 2023 21:16:51 GMT, Mikael Vidstedt wrote:
> This PR does not address all the remaining sprintf:s in hotspot, and with it
> now explicitly forbidden the build will fail:
>
This is a question to me as well. I noticed there are still some use of
sprintf, but the building passed o
On Wed, 11 Jan 2023 21:29:01 GMT, Xue-Lei Andrew Fan wrote:
> > I'm also curious: some of the sprintfs are C2 (src/hotspot/share/opto) -
> > are your builds including C2? If so, why are you not running into the issue
> > for those files?
>
> I'm new to hotsp
On Thu, 12 Jan 2023 07:25:07 GMT, Xue-Lei Andrew Fan wrote:
>>> This PR does not address all the remaining sprintf:s in hotspot, and with
>>> it now explicitly forbidden the build will fail:
>>>
>>
>> This is a question to me as well. I noticed there
was not covered. The failure was reported in [PR
> 11793](https://github.com/openjdk/jdk/pull/11793#issuecomment-1371151565),
> while running tier1 testing.
>
> This patch is trying to find the use of sprintf in test cases, and replace it
> with snprintf accordingly.
Xue-Lei A
was not covered. The failure was reported in [PR
> 11793](https://github.com/openjdk/jdk/pull/11793#issuecomment-1371151565),
> while running tier1 testing.
>
> This patch is trying to find the use of sprintf in test cases, and replace it
> with snprintf accordingly.
Xue-Lei A
was not covered. The failure was reported in [PR
> 11793](https://github.com/openjdk/jdk/pull/11793#issuecomment-1371151565),
> while running tier1 testing.
>
> This patch is trying to find the use of sprintf in test cases, and replace it
> with snprintf accordingly.
Xue-Lei A
On Fri, 13 Jan 2023 01:56:23 GMT, Serguei Spitsyn wrote:
> There are more uses of sprintf in some serviceability folders:
Yes. There are at least 57 src files that use sprintf function, as far as I
can see. This PR is pretty big now. I would like to clean them up in an other
PR so that it i
was not covered. The failure was reported in [PR
> 11793](https://github.com/openjdk/jdk/pull/11793#issuecomment-1371151565),
> while running tier1 testing.
>
> This patch is trying to find the use of sprintf in test cases, and replace it
> with snprintf accordingly.
Xue-Lei A
On Tue, 17 Jan 2023 20:50:26 GMT, Chris Plummer wrote:
>> src/hotspot/os/windows/os_windows.cpp line 387:
>>
>>> 385: os::snprintf_checked(buf, sizeof(buf), "%s%s;%s%s%s",
>>> 386: Arguments::get_java_home(), EXT_DIR,
>>> 387: path, PACKAGE_DIR, EXT_DIR);
>>
>> When
On Tue, 17 Jan 2023 01:34:49 GMT, David Holmes wrote:
>> Xue-Lei Andrew Fan has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains
was not covered. The failure was reported in [PR
> 11793](https://github.com/openjdk/jdk/pull/11793#issuecomment-1371151565),
> while running tier1 testing.
>
> This patch is trying to find the use of sprintf in hotspot iml and test cases.
Xue-Lei Andrew Fan has updated the pull req
On Tue, 17 Jan 2023 01:36:43 GMT, David Holmes wrote:
> I would suggest constraining this PR to src/hotspot and test/hotspot and deal
> with the JDK serviceability files in a different PR (and there may be other
> JDK files impacted too).
I agreed. This PR is mainly focus on the hotspot, exce
was not covered. The failure was reported in [PR
> 11793](https://github.com/openjdk/jdk/pull/11793#issuecomment-1371151565),
> while running tier1 testing.
>
> This patch is trying to find the use of sprintf in hotspot iml and test cases.
Xue-Lei Andrew Fan has updated the pull req
On Wed, 18 Jan 2023 19:45:55 GMT, Chris Plummer wrote:
>> I can see both styles are used in this file. The current code here uses 8
>> whitespaces indent, I would like to keep it.
>
> I scanned the first 1000 lines and saw many cases of multi-line argument
> passing, and they all indent as Dav
was not covered. The failure was reported in [PR
> 11793](https://github.com/openjdk/jdk/pull/11793#issuecomment-1371151565),
> while running tier1 testing.
>
> This patch is trying to find the use of sprintf in hotspot iml and test cases.
Xue-Lei Andrew Fan has updated the pull req
On Fri, 13 Jan 2023 08:00:55 GMT, Serguei Spitsyn wrote:
>>> > I'm also curious: some of the sprintfs are C2 (src/hotspot/share/opto) -
>>> > are your builds including C2? If so, why are you not running into the
>>> > issue for those files?
>>>
>>> I'm new to hotspot. Do you know how could I e
On Fri, 20 Jan 2023 04:39:13 GMT, David Holmes wrote:
> Nothing further from me. I think this is okay as-is now. Thanks.
@dholmes-ora Thank you for the review!
-
PR: https://git.openjdk.org/jdk/pull/11935
On Fri, 20 Jan 2023 18:20:10 GMT, Xue-Lei Andrew Fan wrote:
>> Nothing further from me. I think this is okay as-is now. Thanks.
>
>> Nothing further from me. I think this is okay as-is now. Thanks.
>
> @dholmes-ora Thank you for the review!
> @XueleiFan You need two re
On Wed, 25 Jan 2023 02:05:31 GMT, Mikael Vidstedt wrote:
> Looks good, thank you for doing this!
@vidmik Thank you!
-
PR: https://git.openjdk.org/jdk/pull/11935
On Wed, 11 Jan 2023 06:26:18 GMT, Xue-Lei Andrew Fan wrote:
> The sprintf is deprecated in Xcode 14 because of security concerns. The issue
> was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812)
> for hotspot impl, and
> [JDK-8299378](https://bugs.openjdk.or
The sprintf is deprecated in Xcode 14 because of security concerns. The issue
was addressed in
[JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812)/[JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378)/[JDK-8299635](https://bugs.openjdk.org/browse/JDK-8299635),
but the test was not fu
but the test was not fully covered yet. This would be the last effort to fix
> the issue in test.
Xue-Lei Andrew Fan has updated the pull request incrementally with one
additional commit since the last revision:
incorrect use of sizeof
-
Changes:
- all: https://git.openjdk.org
On Thu, 26 Jan 2023 18:07:42 GMT, Mikael Vidstedt wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> incorrect use of sizeof
>
> test/jdk/sun/management/windows/exerevokeall.
On Thu, 26 Jan 2023 06:38:00 GMT, Xue-Lei Andrew Fan wrote:
> The sprintf is deprecated in Xcode 14 because of security concerns. The issue
> was addressed in
> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812)/[JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378)/[JD
The sprintf is deprecated in Xcode 14 because of security concerns. The issue
was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for
building failure, and
[JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378)/[JDK-8299635](https://bugs.openjdk.org/browse/JDK-8299635
On Mon, 30 Jan 2023 10:23:02 GMT, Kevin Walls wrote:
>> The sprintf is deprecated in Xcode 14 because of security concerns. The
>> issue was addressed in
>> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building
>> failure, and
>> [JDK-8299378](https://bugs.openjdk.org/browse
On Fri, 27 Jan 2023 20:32:35 GMT, Xue-Lei Andrew Fan wrote:
> The sprintf is deprecated in Xcode 14 because of security concerns. The issue
> was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812)
> for building failure, and
> [JDK-8299378](https://bugs.openjd
On Fri, 27 Jan 2023 20:32:35 GMT, Xue-Lei Andrew Fan wrote:
> The sprintf is deprecated in Xcode 14 because of security concerns. The issue
> was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812)
> for building failure, and
> [JDK-8299378](https://bugs.openjd
Hi,
May I have this update reviewed?
The sprintf is deprecated in Xcode 14 because of security concerns. The issue
was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for
building failure, and
[JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378)/[JDK-8299635](http
k.org/browse/JDK-8299378)/[JDK-8299635](https://bugs.openjdk.org/browse/JDK-8299635)/[JDK-8301132](https://bugs.openjdk.org/browse/JDK-8301132)
> for testing issues . This is a break-down update for sprintf uses in
> jdk.hotspot.agent module.
>
> Thanks,
> Xuelei
Xue-Lei
On Thu, 2 Mar 2023 19:31:46 GMT, Chris Plummer wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - one more correction
>> - correct mistakes
>
> src/jdk.hotspot.agent/w
k.org/browse/JDK-8299378)/[JDK-8299635](https://bugs.openjdk.org/browse/JDK-8299635)/[JDK-8301132](https://bugs.openjdk.org/browse/JDK-8301132)
> for testing issues . This is a break-down update for sprintf uses in
> jdk.hotspot.agent module.
>
> Thanks,
> Xuelei
Xue-Lei
On Thu, 2 Mar 2023 19:17:40 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14 because of security concerns. The issue
> was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812)
> for
On Fri, 3 Mar 2023 18:18:02 GMT, Chris Plummer wrote:
> @XueleiFan In the future please get two reviews for all hotspot (and
> serviceability) changes. Thanks.
Thank you for pointing it out, and the review.
-
PR: https://git.openjdk.org/jdk/pull/12837
Hi,
May I have this update reviewed?
The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because of
security concerns. The issue was addressed in
[JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building
failure, and
[JDK-8299378](https://bugs.openjdk.org/browse
d
> [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378)/[JDK-8299635](https://bugs.openjdk.org/browse/JDK-8299635)/[JDK-8301132](https://bugs.openjdk.org/browse/JDK-8301132)
> for testing issues . This is a break-down update for sprintf uses in
> jdk.jdwp.agent module.
>
> T
d
> [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378)/[JDK-8299635](https://bugs.openjdk.org/browse/JDK-8299635)/[JDK-8301132](https://bugs.openjdk.org/browse/JDK-8301132)
> for testing issues . This is a break-down update for sprintf uses in
> jdk.jdwp.agent module.
>
> T
On Mon, 6 Mar 2023 20:23:13 GMT, Chris Plummer wrote:
> windows/native/libjdwp/linker_md.c also needs its copyright updated.
Ooops, I missed this file. Updated. Thanks!
-
PR: https://git.openjdk.org/jdk/pull/12870
On Sat, 4 Mar 2023 06:29:20 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because
> of security concerns. The issue was addressed in
> [JDK-8296812](https://bugs.o
Hi,
May I have this update reviewed?
The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because of
security concerns. The issue was addressed in
[JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building
failure, and
[JDK-8299378](https://bugs.openjdk.org/browse
Hi,
May I have this update reviewed?
The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because of
security concerns. The issue was addressed in
[JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building
failure, and
[JDK-8299378](https://bugs.openjdk.org/browse
On Wed, 10 May 2023 18:02:22 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because
> of security concerns. The issue was addressed in
> [JDK-8296812](https://bugs.o
On Wed, 10 May 2023 17:48:04 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this update reviewed?
>
> The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because
> of security concerns. The issue was addressed in
> [JDK-8296812](https://bugs.o
On Wed, 26 Oct 2022 16:00:56 GMT, Daniel Fuchs wrote:
> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
> to parse or construct any URL.
>
> The `java.net.URL` class does not itself encode or decode any URL components
> according to the escaping mechanism defined in
On Wed, 26 Oct 2022 17:24:59 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/net/URL.java line 852:
>>
>>> 850: * @since 20
>>> 851: */
>>> 852: public static URL fromURI(URI uri, URLStreamHandler streamHandler)
>>
>> What do you think to have this method in URI inste
46 matches
Mail list logo
