On Wed, 14 Dec 2022 23:40:52 GMT, Damon Nguyen wrote:
> Open l10n drop
> All tests passed
src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties
line 188:
> 186: main.plugin.module=\u63D2\u4EF6\u6A21\u5757
> 187:
> 188: main.plugin.category=\u7C7B\u522B
As Naoto poin
On Wed, 14 Dec 2022 23:40:52 GMT, Damon Nguyen wrote:
> Open l10n drop
> All tests passed
src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line 26:
> 24: #
> 25:
> 26: jmod.description=JMOD-Dateien erstellen und den Inhalt vorhandener
> JMOD-Dateien auflisten
`jlink.de
On Thu, 15 Dec 2022 00:58:06 GMT, Justin Lu wrote:
>> Open l10n drop
>> All tests passed
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties
> line 188:
>
>> 186: main.plugin.module=\u63D2\u4EF6\u6A21\u5757
>> 187:
>&
On Tue, 24 Jan 2023 22:20:22 GMT, Damon Nguyen wrote:
>> src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_zh_CN.properties
>> line 174:
>>
>>> 172:
>>> MBEANS_TAB_UNSUBSCRIBE_NOTIFICATIONS_BUTTON=\u53D6\u6D88\u8BA2\u9605(&U)
>>> 173:
>>> MBEANS_TAB_UNSUBSCRIBE_NOTIFICATION
On Tue, 24 Jan 2023 22:33:24 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revisi
On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revisi
This PR converts Unicode sequences to UTF-8 native in .properties file.
(Excluding the Unicode space and tab sequence). The conversion was done using
native2ascii.
In addition, the build logic is adjusted to support reading in the .properties
files as UTF-8 during the conversion from .propertie
On Tue, 7 Mar 2023 23:15:14 GMT, Jonathan Gibbons wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is adjusted to support readin
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request incrementally with four additional
commits since the last revision:
- Bug6204853 should not be converted
- Copyright year for CompileProperties
- Redo translation for CS.prope
On Thu, 16 Mar 2023 18:19:29 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is
On Wed, 15 Mar 2023 20:19:51 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Bug6204853 should not be converted
>> - Copyright year for CompileProperties
>>
On Wed, 15 Mar 2023 16:18:44 GMT, Archie L. Cobbs wrote:
>> Justin Lu has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - Bug6204853 should not be converted
>> - Copyright year for CompilePropert
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request incrementally with two additional
commits since the last revision:
- Reconvert CS.properties to UTF-8
- Revert all changes to CurrencySymbols.properties
-
Ch
On Thu, 16 Mar 2023 18:31:23 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Adjust CF test to read in with UTF-8 to fix failing test
-
Changes:
- all: https://git.openj
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Close streams when finished loading into props
-
Changes:
- all: https://git.openjdk.org/jdk/pul
On Fri, 17 Mar 2023 22:27:48 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is
ing the conversion from .properties file to
> .java ListResourceBundle file.
Justin Lu has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains 16 commits:
- Convert the merged master changes to UTF-8
- Merge master and fix conflicts
On Thu, 11 May 2023 20:21:57 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is
Please review this PR which updates the JDK's localized resources since the
previous L10n translation drop (1/26).
To help with reviewing the changes, @jonathan-gibbons created a tool which
displays the localized changes next to the original file's changes in UTF-8
native. Those files can be vi
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized
On Mon, 12 Jun 2023 21:42:24 GMT, Kevin Rushforth wrote:
>> @prrace @jonathan-gibbons @pavelrappo @lahodaj @wangweij @igraves
>> @AlanBateman @eirbjo could you please review the modules / changes you are
>> familiar with, thank you.
>
> @justin-curtis-lu Unless there is a strong reason to do ot
Please review this PR which updates the JDK's localized resources since the
previous L10n translation drop (1/26).
To help with reviewing the changes, @jonathan-gibbons created a tool which
displays the localized changes next to the original file's changes in UTF-8
native. Those files can be vi
On Mon, 12 Jun 2023 22:00:01 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized
in UTF-8
> native. Those files can be viewed [here](https://cr.openjdk.org/~jlu/output/)
>
> For example,
>
> src="https://github.com/openjdk/jdk21/assets/67398801/e68a48a8-916e-4860-afb0-526924c6a3d3";>
>
>
> Please note that the HTML files only apply to .
On Mon, 12 Jun 2023 22:17:25 GMT, Eirik Bjorsnos wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 'main.help.opt.any.file' value for _de
>
> src/jdk.jarto
On Tue, 13 Jun 2023 18:13:12 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 'main.help.opt.any.file' value for _de
>
> src/jdk.compiler/sha
in UTF-8
> native. Those files can be viewed [here](https://cr.openjdk.org/~jlu/output/)
>
> For example,
>
> src="https://github.com/openjdk/jdk21/assets/67398801/e68a48a8-916e-4860-afb0-526924c6a3d3";>
>
>
> Please note that the HTML files only apply to .
On Tue, 13 Jun 2023 19:59:28 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 'main.help.opt.any.file' value for _de
>
> src/java.deskto
in UTF-8
> native. Those files can be viewed [here](https://cr.openjdk.org/~jlu/output/)
>
> For example,
>
> src="https://github.com/openjdk/jdk21/assets/67398801/e68a48a8-916e-4860-afb0-526924c6a3d3";>
>
>
> Please note that the HTML files only apply to .
On Tue, 13 Jun 2023 20:56:31 GMT, Weijun Wang wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 'main.help.opt.any.file' value for _de
>
> Some comments:
>
&g
On Tue, 13 Jun 2023 18:50:42 GMT, Justin Lu wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties
>> line 140:
>>
>>> 138:
>>> 139: # 0: type, 1: name
>>> 140: compiler.err.annotation.unrecognized.attribute.n
On Mon, 12 Jun 2023 22:00:01 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized
On Thu, 15 Jun 2023 21:06:32 GMT, Kevin Rushforth wrote:
> Is the patch expected to be the same as in jdk mainline? I see some
> differences between the two patches (which is why Skara didn't mark it as
> "clean")
Hi Kevin, yes it is. I still need to grab the changes from mainline and include
in UTF-8
> native. Those files can be viewed [here](https://cr.openjdk.org/~jlu/output/)
>
> For example,
>
> src="https://github.com/openjdk/jdk21/assets/67398801/e68a48a8-916e-4860-afb0-526924c6a3d3";>
>
>
> Please note that the HTML files only apply to .
On Mon, 12 Jun 2023 21:21:05 GMT, Justin Lu wrote:
> Please review this PR which updates the JDK's localized resources since the
> previous L10n translation drop (1/26).
>
> To help with reviewing the changes, @jonathan-gibbons created a tool which
> displays the localized
JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
would improve readability to see the native characters instead of escape
sequences (especially for the L10n process). The majority of files changed are
localized resource files.
This change converts the Unicode escape
or .properties files need
> to be updated to UTF-8. (IntelliJ IDEA locks .properties files as ISO-8859-1
> unless manually changed).
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
Replace InputStreamReader with BufferedReader
---
On Wed, 13 Sep 2023 18:12:15 GMT, Naoto Sato wrote:
> Looks good to me, although I did not look at each l10n file, but sampled
> some. Thanks for tackling this conversion.
Thanks for the review; (In addition to testing), I ran a script to verify only
white space escape sequences exist in JDK .
On Tue, 12 Sep 2023 21:57:31 GMT, Justin Lu wrote:
> JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
> would improve readability to see the native characters instead of escape
> sequences (especially for the L10n process). The majority of files chang
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote:
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK. Primarily, the changes between JDK 22
> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>
> The translati
On Tue, 11 Jun 2024 17:15:49 GMT, Naoto Sato wrote:
>> Yeah, I believe you're right. Noted as something else to file against the
>> translation tool.
>
> Just out of curiosity, do we know why `\t` was attached in the first place? I
> don't think it is with the original English properties.
I ca
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The tra
>
> The commit being backported was authored by Damon Nguyen on 13 Jun 2024 and
> was reviewed by Alisen Chung, Justin Lu, Naoto Sato, Joe Wang, Pavel Rappo,
> Chris Plummer, Alexey Semenyuk and Phil Race.
>
> Thanks!
Clean backport of L10n resource drop required for JDK23
---
Please review this PR which is part of the bigger umbrella bug:
https://bugs.openjdk.org/browse/JDK-8341542.
This fixes incorrect usage of `jthrowable ExceptionOccurred(JNIEnv *env)`
within _jdk.jdi_.
This corrects instances where the return value is being treated as a boolean.
Such occurrences
Please review this PR which is part of the bigger umbrella bug:
https://bugs.openjdk.org/browse/JDK-8341542.
This fixes incorrect usage of `jthrowable ExceptionOccurred(JNIEnv *env)`
within _jdk.attach_.
This corrects instances where the return value is being treated as a boolean.
Such occurren
On Thu, 10 Oct 2024 21:55:37 GMT, Justin Lu wrote:
> Please review this PR which is part of the bigger umbrella bug:
> https://bugs.openjdk.org/browse/JDK-8341542.
>
> This fixes incorrect usage of `jthrowable ExceptionOccurred(JNIEnv *env)`
> within _jdk.attach_.
> This
On Thu, 10 Oct 2024 21:56:39 GMT, Justin Lu wrote:
> Please review this PR which is part of the bigger umbrella bug:
> https://bugs.openjdk.org/browse/JDK-8341542.
>
> This fixes incorrect usage of `jthrowable ExceptionOccurred(JNIEnv *env)`
> within _jdk.jdi_.
> This correc
>> ExceptionCheck
>> We introduce a convenience function to check for pending exceptions
>> without creating a local reference to the exception object.
>>
>> jboolean ExceptionCheck(JNIEnv *env);
>>
>> Returns JNI_TRUE when there is a pend
On Mon, 28 Oct 2024 03:12:55 GMT, David Holmes wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address other cases in Hotspot
>
> @justin-curtis-lu you have missed a large number
On Thu, 31 Oct 2024 20:13:08 GMT, Justin Lu wrote:
> Please review this PR which is a JNI cleanup to replace incorrect usages of
> `jthrowable ExceptionOccurred(JNIEnv *env)` with `jboolean
> ExceptionCheck(JNIEnv *env)` in _jdk.jdwp.agent_.
>
> This is part of the bigger
On Thu, 31 Oct 2024 20:13:08 GMT, Justin Lu wrote:
> Please review this PR which is a JNI cleanup to replace incorrect usages of
> `jthrowable ExceptionOccurred(JNIEnv *env)` with `jboolean
> ExceptionCheck(JNIEnv *env)` in _jdk.jdwp.agent_.
>
> This is part of the bigger
On Thu, 31 Oct 2024 19:54:20 GMT, Justin Lu wrote:
> Please review this PR which is a JNI cleanup to replace incorrect usages of
> `jthrowable ExceptionOccurred(JNIEnv *env)` with `jboolean
> ExceptionCheck(JNIEnv *env)` in _jdk.hotspot.agent_.
>
> This is part of the bigger
On Thu, 31 Oct 2024 20:14:43 GMT, Justin Lu wrote:
>> Please review this PR which is a JNI cleanup to replace incorrect usages of
>> `jthrowable ExceptionOccurred(JNIEnv *env)` with `jboolean
>> ExceptionCheck(JNIEnv *env)` in _jdk.hotspot.agent_.
>>
>> This
On Tue, 29 Oct 2024 00:19:29 GMT, Justin Lu wrote:
>> A trivial JNI refactoring in Hotspot to use `ExceptionCheck()` over
>> `ExceptionOccurred()` when the usage is treating the return value as a
>> boolean. This is part of the bigger umbrella issue:
>> [JDK-8341542](
On Fri, 25 Oct 2024 21:51:53 GMT, Justin Lu wrote:
> A trivial JNI refactoring in Hotspot to use `ExceptionCheck()` over
> `ExceptionOccurred()` when the usage is treating the return value as a
> boolean. This is part of the bigger umbrella issue:
> [JDK-8341542](https://bugs
On Thu, 31 Oct 2024 02:34:04 GMT, David Holmes wrote:
>> Thank you for the review.
>
> @justin-curtis-lu for future reference note that hotspot generally requires
> two reviews per PR before integration. This was a very simple change but not
> "trivial" in the sense documented in the developer
Please review this PR which is a JNI cleanup to replace incorrect usages of
`jthrowable ExceptionOccurred(JNIEnv *env)` with `jboolean
ExceptionCheck(JNIEnv *env)` in _jdk.hotspot.agent_.
This is part of the bigger umbrella issue:
https://bugs.openjdk.org/browse/JDK-8341542. This change only mo
/JDK-8341542. This change only modifies
> instances where the exception object is not needed, and the method return
> value is being treated as if it were a boolean.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
for consistency,
Please review this PR which is a JNI cleanup to replace incorrect usages of
`jthrowable ExceptionOccurred(JNIEnv *env)` with `jboolean
ExceptionCheck(JNIEnv *env)` in _jdk.jdwp.agent_.
This is part of the bigger umbrella issue:
https://bugs.openjdk.org/browse/JDK-8341542. This change only modif
A trivial JNI refactoring in Hotspot to use `ExceptionCheck()` over
`ExceptionOccurred()` when the usage is treating the return value as a boolean.
This is part of the bigger umbrella issue:
[JDK-8341542](https://bugs.openjdk.org/browse/JDK-8341542).
> ExceptionCheck
> We introduce a
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 23 Dec 2024 09:45:00 GMT, Qizheng Xing wrote:
> This patch fixes unmatched brackets in some source files.
make/data/cldr/common/main/kn.xml line 1085:
> 1083: ಇಸ್ಲಾಮಿಕ್
> ಕ್ಯಾಲೆಂಡರ್
> 1084: type="islamic-civil">ಇಸ್ಲಾಮಿಕ್-ಸಿವಿಲ್ ಕ್ಯಾಲೆಂಡರ
64 matches
Mail list logo
