On Sun, 26 May 2024 17:02:33 GMT, SendaoYan wrote:
> > > That would mean it's not tested. I suspect the
> > > java_lang_VirtualThread::is_instance checks will need to be changed to
> > > test with is_a(vmClasses::BaseVirtualThread_klass()) to allow for the
> > > alternative implementation.
> >
I add the testcase which can reproduce the crash. I hope that I could get some
advise if the codes need changing.
-
Commit messages:
- 8337331: crash: pinned virtual thread will lead to jvm crash when running
with the javaagent option
Changes: https://git.openjdk.org/jdk/pull/2037
> I add the testcase which can reproduce the crash. I hope that I could get
> some advise if the codes need changing.
Jiawei Tang has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the pr
On Mon, 29 Jul 2024 10:01:56 GMT, David Holmes wrote:
>> Jiawei Tang has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request co
> I add the testcase which can reproduce the crash. I hope that I could get
> some advise if the codes need changing.
Jiawei Tang has updated the pull request incrementally with one additional
commit since the last revision:
changes according to reviewers' advice
---
On Mon, 29 Jul 2024 09:53:40 GMT, Alan Bateman wrote:
>> Jiawei Tang has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request co
On Mon, 29 Jul 2024 10:00:23 GMT, David Holmes wrote:
>> Jiawei Tang has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request co
On Mon, 29 Jul 2024 10:40:17 GMT, Alan Bateman wrote:
> Can we not just preload the problematic class so that it won't happen during
> the transition?
I think if a new agent are attached into the running progress, the vm may still
crash?
-
PR Comment: https://git.openjdk.org/jdk/
> I add the testcase which can reproduce the crash. I hope that I could get
> some advise if the codes need changing.
Jiawei Tang has updated the pull request incrementally with one additional
commit since the last revision:
refactor testcase and change the location of fix
On Mon, 29 Jul 2024 22:34:46 GMT, Serguei Spitsyn wrote:
>> Jiawei Tang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes according to reviewers' advice
>
> src/hotspot/share/prims/jvmtiExp
> I add the testcase which can reproduce the crash. I hope that I could get
> some advise if the codes need changing.
Jiawei Tang has updated the pull request incrementally with one additional
commit since the last revision:
remove useless codes and refactor the te
On Tue, 30 Jul 2024 11:20:48 GMT, Serguei Spitsyn wrote:
>> Jiawei Tang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> refactor testcase and change the location of fix codes
>
> src/hotspot/share/p
> I add the testcase which can reproduce the crash. I hope that I could get
> some advise if the codes need changing.
Jiawei Tang has updated the pull request incrementally with one additional
commit since the last revision:
change test condition for TestPinCaseWithCFL
> I add the testcase which can reproduce the crash. I hope that I could get
> some advise if the codes need changing.
Jiawei Tang has updated the pull request incrementally with one additional
commit since the last revision:
rearrange to avoid long lines
-
Changes:
> I add the testcase which can reproduce the crash. I hope that I could get
> some advise if the codes need changing.
Jiawei Tang has updated the pull request incrementally with one additional
commit since the last revision:
change the format of the testcase file
-
C
> I add the testcase which can reproduce the crash. I hope that I could get
> some advise if the codes need changing.
Jiawei Tang has updated the pull request incrementally with one additional
commit since the last revision:
change the format of the testcase file
-
C
> I add the testcase which can reproduce the crash. I hope that I could get
> some advise if the codes need changing.
Jiawei Tang has updated the pull request incrementally with one additional
commit since the last revision:
change the format of the testcase file
-
C
> I add the testcase which can reproduce the crash. I hope that I could get
> some advise if the codes need changing.
Jiawei Tang has updated the pull request incrementally with one additional
commit since the last revision:
change the format of the testcase file
-
C
On Mon, 5 Aug 2024 03:58:18 GMT, Jiawei Tang wrote:
>> I add the testcase which can reproduce the crash. I hope that I could get
>> some advise if the codes need changing.
>
> Jiawei Tang has updated the pull request incrementally with one additional
> commit si
> I add the testcase which can reproduce the crash. I hope that I could get
> some advise if the codes need changing.
Jiawei Tang has updated the pull request incrementally with one additional
commit since the last revision:
fix the test condition to avoid NoClassDefFoun
On Tue, 6 Aug 2024 04:36:38 GMT, Jaikiran Pai wrote:
> Hello @jia-wei-tang, I see that a `@build jdk.test.lib.util.JavaAgentBuilder`
> was added in the latest update to the PR. Did that help solve the
> NoClassDefFoundError you were running into when running those tests? I find
> it surprising
> I add the testcase which can reproduce the crash. I hope that I could get
> some advise if the codes need changing.
Jiawei Tang has updated the pull request incrementally with one additional
commit since the last revision:
fix the test condition to avoid NoClassDefFoun
On Tue, 6 Aug 2024 06:14:45 GMT, Jaikiran Pai wrote:
>>> Hello @jia-wei-tang, I see that a `@build
>>> jdk.test.lib.util.JavaAgentBuilder` was added in the latest update to the
>>> PR. Did that help solve the NoClassDefFoundError you were running into when
>>> running those tests? I find it su
> I add the testcase which can reproduce the crash. I hope that I could get
> some advise if the codes need changing.
Jiawei Tang has updated the pull request incrementally with one additional
commit since the last revision:
fix the test condition to avoid NoClassDefFoun
On Wed, 7 Aug 2024 12:13:55 GMT, Jaikiran Pai wrote:
>> I was able to reproduce this `NoClassDefFoundError` in this new test
>> locally. I will take a look to see if I can figure out what's going on.
>
> I looked into this locally and this is a (known) bug in jtreg
> https://bugs.openjdk.org/br
On Thu, 8 Aug 2024 02:18:34 GMT, Jiawei Tang wrote:
>> I looked into this locally and this is a (known) bug in jtreg
>> https://bugs.openjdk.org/browse/CODETOOLS-7902847.
>>
>> What's happening here is that the tests are launched using make tes
> I add the testcase which can reproduce the crash. I hope that I could get
> some advise if the codes need changing.
Jiawei Tang has updated the pull request incrementally with one additional
commit since the last revision:
fix the test condition to avoid NoClassDefFoun
On Thu, 8 Aug 2024 04:43:19 GMT, David Holmes wrote:
>> I am not too sure adding the `@build jdk.test.lib.Utils` is a good thing.
>> This test definition nor the test code uses/references that class. So it's
>> odd to be adding a build tag for an indirect dependent class (and only that
>> spec
On Thu, 8 Aug 2024 08:39:34 GMT, Jiawei Tang wrote:
>> Building a test library class not actually used by the test is certainly
>> somewhat odd. I wasn't aware of the `@clean` workaround but I see a lot of
>> vmTestbase tests use it, so please try the `@clean` a
> I add the testcase which can reproduce the crash. I hope that I could get
> some advise if the codes need changing.
Jiawei Tang has updated the pull request incrementally with one additional
commit since the last revision:
fix the test condition to avoid NoClassDefFoun
On Thu, 8 Aug 2024 09:11:29 GMT, Jaikiran Pai wrote:
>> A stable way to reproduce the problem: run AgentWithVThread.java and then
>> TestPinCaseWithCFLH.java.
>>
>>
>> jtreg -v:error,fail -jdk:{JDKPATH}
>> ./test/hotspot/jtreg/serviceability/jvmti/vthread/premain/AgentWithVThreadTest.java
>>
On Mon, 29 Jul 2024 09:36:47 GMT, Jiawei Tang wrote:
> I add the testcase which can reproduce the crash. I hope that I could get
> some advise if the codes need changing.
This pull request has now been integrated.
Changeset: 55c50970
Author:Jiawei Tang
URL:
https://git.openj
32 matches
Mail list logo
