On Tue, 27 May 2025 22:48:15 GMT, Alex Menkov wrote:
>> This is first (hotspot) part of the update for
>> `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` to
>> include lock information in thread dumps (JDK-8356870).
>> The update has been split into parts to simplify review
> This is the code for the [JEP 509: CPU Time based profiling for
> JFR](https://openjdk.org/jeps/509).
>
> Currently tested using [this test
> suite](https://github.com/parttimenerd/basic-profiler-tests). This runs
> profiles the [Renaissance](https://renaissance.dev/) benchmark with
> - ... d
On Wed, 28 May 2025 09:08:30 GMT, Kevin Walls wrote:
> Hi, looks good.
> If we are removing things from jcmd PerfCounter.print output, that could
> feature in the release note that you have planned. Anybody expecting these
> counters using jcmd PerfCounter.print or other methods, may not know t
On Thu, 22 May 2025 14:09:37 GMT, Casper Norrbin wrote:
>> Hi everyone,
>>
>> This change removes the legacy `PerfData` sampling mechanism implemented
>> through the `StatSampler` — an always-on periodic task that runs every 50ms
>> my default. The sampling feature was originally introduced to
On Mon, 26 May 2025 20:57:15 GMT, Johannes Bechberger
wrote:
>> This is the code for the [JEP 509: CPU Time based profiling for
>> JFR](https://openjdk.org/jeps/509).
>>
>> Currently tested using [this test
>> suite](https://github.com/parttimenerd/basic-profiler-tests). This runs
>> profile
On Tue, 27 May 2025 16:34:14 GMT, Markus Grönlund wrote:
>> It seems to normally be a pointer. I'll try the forward declaration later.
>
> Don't worry if it's too hard. It would just be a nice thing to eliminate
> these special includes from the header file.
The signal.h is apparently included
On Mon, 26 May 2025 16:06:01 GMT, Andrey Turbanov wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase.
>
> src/java.base/share/classes/jdk/internal/vm/Th
> This is the code for the [JEP 509: CPU Time based profiling for
> JFR](https://openjdk.org/jeps/509).
>
> Currently tested using [this test
> suite](https://github.com/parttimenerd/basic-profiler-tests). This runs
> profiles the [Renaissance](https://renaissance.dev/) benchmark with
> - ... d
> This is the code for the [JEP 509: CPU Time based profiling for
> JFR](https://openjdk.org/jeps/509).
>
> Currently tested using [this test
> suite](https://github.com/parttimenerd/basic-profiler-tests). This runs
> profiles the [Renaissance](https://renaissance.dev/) benchmark with
> - ... d
On Fri, 23 May 2025 20:50:15 GMT, Serguei Spitsyn wrote:
> The test
> `test/hotspot/jtreg/serviceability/jvmti/vthread/TestPinCaseWithCFLH/TestPinCaseWithCFLH.java`
> was contributed by an external contributor to exercise the
> `-Djdk.tracePinnedThreads=full` system property when a `javaagent`
On Tue, 27 May 2025 22:48:15 GMT, Alex Menkov wrote:
>> This is first (hotspot) part of the update for
>> `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` to
>> include lock information in thread dumps (JDK-8356870).
>> The update has been split into parts to simplify review
On Tue, 27 May 2025 22:48:15 GMT, Alex Menkov wrote:
>> This is first (hotspot) part of the update for
>> `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` to
>> include lock information in thread dumps (JDK-8356870).
>> The update has been split into parts to simplify review
On Tue, 27 May 2025 22:48:15 GMT, Alex Menkov wrote:
>> This is first (hotspot) part of the update for
>> `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` to
>> include lock information in thread dumps (JDK-8356870).
>> The update has been split into parts to simplify review
On Tue, 27 May 2025 11:36:41 GMT, Markus Grönlund wrote:
>> Johannes Bechberger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove assertion
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/PlatformEventType.java line 195:
>
>> 193:
On Sat, 24 May 2025 09:37:21 GMT, Shaojin Wen wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase.
>
> test/jdk/com/sun/management/HotSpotDiagnosticMXBea
On Thu, 22 May 2025 14:09:37 GMT, Casper Norrbin wrote:
>> Hi everyone,
>>
>> This change removes the legacy `PerfData` sampling mechanism implemented
>> through the `StatSampler` — an always-on periodic task that runs every 50ms
>> my default. The sampling feature was originally introduced to
On Thu, 22 May 2025 14:09:37 GMT, Casper Norrbin wrote:
>> Hi everyone,
>>
>> This change removes the legacy `PerfData` sampling mechanism implemented
>> through the `StatSampler` — an always-on periodic task that runs every 50ms
>> my default. The sampling feature was originally introduced to
On Fri, 25 Apr 2025 10:38:39 GMT, Casper Norrbin wrote:
> Hi everyone,
>
> This change removes the legacy `PerfData` sampling mechanism implemented
> through the `StatSampler` — an always-on periodic task that runs every 50ms
> my default. The sampling feature was originally introduced to coll
On Fri, 23 May 2025 20:50:15 GMT, Serguei Spitsyn wrote:
> The test
> `test/hotspot/jtreg/serviceability/jvmti/vthread/TestPinCaseWithCFLH/TestPinCaseWithCFLH.java`
> was contributed by an external contributor to exercise the
> `-Djdk.tracePinnedThreads=full` system property when a `javaagent`
On Thu, 22 May 2025 14:09:37 GMT, Casper Norrbin wrote:
>> Hi everyone,
>>
>> This change removes the legacy `PerfData` sampling mechanism implemented
>> through the `StatSampler` — an always-on periodic task that runs every 50ms
>> my default. The sampling feature was originally introduced to
On Mon, 26 May 2025 15:42:57 GMT, Erik Gahlin wrote:
> > I will see if I can create an example with some other events that show the
> > syntax, and then you can fill in the CPU-Time events.
>
> I have a Mac, so I could not try it with an actual recording, but something
> like this:
>
> ```
>
On Wed, 28 May 2025 07:07:27 GMT, David Holmes wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move to ThreadService
>
> src/hotspot/share/services/threadService.cpp line 1170:
>
>> 1168: };
>> 1169:
>> 1170:
SonarCloud reports an issue since
[JDK-8355003](https://bugs.openjdk.org/browse/JDK-8355003) integration:
duplicate index in `metadataTypeArray` initialization code. Looks like a simple
typo, this PR fixes it.
Additional testing:
- [x] Linux x86_64 server fastdebug, `serviceability/sa`
-
On Wed, 28 May 2025 12:58:49 GMT, Alan Bateman wrote:
>> src/hotspot/share/prims/jvmtiThreadState.hpp line 80:
>>
>>> 78: // Virtual Thread Mount State Transition (VTMS transition) mechanism
>>> 79: //
>>> 80: class JvmtiVTMSTransitionDisabler : public AnyObj {
>>
>> Why this change?
>
> It's u
On Wed, 28 May 2025 18:51:09 GMT, Aleksey Shipilev wrote:
> SonarCloud reports an issue since
> [JDK-8355003](https://bugs.openjdk.org/browse/JDK-8355003) integration:
> duplicate index in `metadataTypeArray` initialization code. Looks like a
> simple typo, this PR fixes it.
>
> Additional t
On Tue, 27 May 2025 21:57:11 GMT, Igor Veresov wrote:
>> Improve warm-up time by making profile data from a previous run of an
>> application instantly available, when the HotSpot Java Virtual Machine
>> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
>> to store me
On Wed, 28 May 2025 07:10:57 GMT, David Holmes wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move to ThreadService
>
> src/hotspot/share/services/threadService.cpp line 1206:
>
>> 1204: bool ret = _retry_hand
On Wed, 28 May 2025 10:33:36 GMT, Serguei Spitsyn wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move to ThreadService
>
> src/hotspot/share/prims/jvm.cpp line 2968:
>
>> 2966: oop snapshot = VMThreadSnapshot::g
On Wed, 28 May 2025 03:47:04 GMT, Serguei Spitsyn wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move to ThreadService
>
> src/hotspot/share/services/threadService.cpp line 1172:
>
>> 1170: Handle _java_thread;
> This is first (hotspot) part of the update for
> `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` to
> include lock information in thread dumps (JDK-8356870).
> The update has been split into parts to simplify reviewing.
> The fix contains an implementation of `jdk.internal.
On Wed, 28 May 2025 19:36:39 GMT, Alex Menkov wrote:
>> src/hotspot/share/prims/jvm.cpp line 2968:
>>
>>> 2966: oop snapshot = VMThreadSnapshot::get_thread_snapshot(jthread,
>>> THREAD);
>>> 2967: return JNIHandles::make_local(THREAD, snapshot);
>>> 2968: #elif
>>
>> Q: should it be `#else
On Wed, 28 May 2025 03:51:36 GMT, Serguei Spitsyn wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move to ThreadService
>
> src/hotspot/share/services/threadService.cpp line 1180:
>
>> 1178: GrowableArray* _locks
On Wed, 28 May 2025 07:09:06 GMT, David Holmes wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move to ThreadService
>
> src/hotspot/share/services/threadService.cpp line 1189:
>
>> 1187: _thread_status(), _nam
On Wed, 28 May 2025 18:31:21 GMT, Alex Menkov wrote:
>> src/hotspot/share/services/threadService.cpp line 1203:
>>
>>> 1201: }
>>> 1202:
>>> 1203: bool read_reset_retry() {
>>
>> What does the `read` mean in the name?
>
> read and then reset the `retry` value (return old value)
removed "r
On Wed, 28 May 2025 13:35:44 GMT, Alan Bateman wrote:
>> src/hotspot/share/classfile/javaClasses.cpp line 1875:
>>
>>> 1873:
>>> 1874: oop java_lang_Thread::park_blocker(oop java_thread) {
>>> 1875: return java_thread->obj_field_acquire(_park_blocker_offset);
>>
>> Where is the releasing sto
On Thu, 29 May 2025 03:26:49 GMT, Alex Menkov wrote:
>> This is first (hotspot) part of the update for
>> `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` to
>> include lock information in thread dumps (JDK-8356870).
>> The update has been split into parts to simplify review
On Wed, 28 May 2025 18:16:20 GMT, Alex Menkov wrote:
>> It's used by VMThreadSnapshot::get_thread_snapshot. The transition disabling
>> support is currently in the jvmti code. I think this is the first usage in a
>> handshake op that isn't supporting a JVMTI function. Maybe in the future
>> th
On Mon, 28 Apr 2025 15:51:44 GMT, PAWAN CHAWDHARY wrote:
> 8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1
This pull request has now been integrated.
Changeset: e579cca6
Author:PAWAN CHAWDHARY
Committer: Leonid Mesnik
URL:
https://git.openjdk.org/jdk/commit/e
On Wed, 28 May 2025 07:01:53 GMT, David Holmes wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move to ThreadService
>
> src/hotspot/share/prims/jvmtiThreadState.hpp line 80:
>
>> 78: // Virtual Thread Mount State
On Fri, 25 Apr 2025 20:18:41 GMT, Igor Veresov wrote:
> Improve warm-up time by making profile data from a previous run of an
> application instantly available, when the HotSpot Java Virtual Machine
> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483)
> to store method
On Fri, 23 May 2025 04:33:36 GMT, PAWAN CHAWDHARY wrote:
>> 8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1
>
> PAWAN CHAWDHARY has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains three commits:
>
> - Merge bran
> This is the code for the [JEP 509: CPU Time based profiling for
> JFR](https://openjdk.org/jeps/509).
>
> Currently tested using [this test
> suite](https://github.com/parttimenerd/basic-profiler-tests). This runs
> profiles the [Renaissance](https://renaissance.dev/) benchmark with
> - ... d
On Wed, 28 May 2025 06:59:48 GMT, David Holmes wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move to ThreadService
>
> src/hotspot/share/classfile/javaClasses.cpp line 1875:
>
>> 1873:
>> 1874: oop java_lang_Thr
> This is the code for the [JEP 509: CPU Time based profiling for
> JFR](https://openjdk.org/jeps/509).
>
> Currently tested using [this test
> suite](https://github.com/parttimenerd/basic-profiler-tests). This runs
> profiles the [Renaissance](https://renaissance.dev/) benchmark with
> - ... d
On Wed, 28 May 2025 18:51:09 GMT, Aleksey Shipilev wrote:
> SonarCloud reports an issue since
> [JDK-8355003](https://bugs.openjdk.org/browse/JDK-8355003) integration:
> duplicate index in `metadataTypeArray` initialization code. Looks like a
> simple typo, this PR fixes it.
>
> Additional t
On Wed, 28 May 2025 18:51:09 GMT, Aleksey Shipilev wrote:
> SonarCloud reports an issue since
> [JDK-8355003](https://bugs.openjdk.org/browse/JDK-8355003) integration:
> duplicate index in `metadataTypeArray` initialization code. Looks like a
> simple typo, this PR fixes it.
>
> Additional t
On Wed, 28 May 2025 18:51:09 GMT, Aleksey Shipilev wrote:
> SonarCloud reports an issue since
> [JDK-8355003](https://bugs.openjdk.org/browse/JDK-8355003) integration:
> duplicate index in `metadataTypeArray` initialization code. Looks like a
> simple typo, this PR fixes it.
>
> Additional t
> This is first (hotspot) part of the update for
> `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` to
> include lock information in thread dumps (JDK-8356870).
> The update has been split into parts to simplify reviewing.
> The fix contains an implementation of `jdk.internal.
On Fri, 9 May 2025 22:34:45 GMT, Chen Liang wrote:
>> For early eval; test by changing the ClassReader max accepted version of
>> test ASM to 24 instead of 25
>
> Chen Liang has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unr
49 matches
Mail list logo