Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v2]

2025-05-28 Thread Serguei Spitsyn
On Tue, 27 May 2025 22:48:15 GMT, Alex Menkov wrote: >> This is first (hotspot) part of the update for >> `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` to >> include lock information in thread dumps (JDK-8356870). >> The update has been split into parts to simplify review

Re: RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v20]

2025-05-28 Thread Johannes Bechberger
> This is the code for the [JEP 509: CPU Time based profiling for > JFR](https://openjdk.org/jeps/509). > > Currently tested using [this test > suite](https://github.com/parttimenerd/basic-profiler-tests). This runs > profiles the [Renaissance](https://renaissance.dev/) benchmark with > - ... d

Re: RFR: 8241678: Remove PerfData sampling via StatSampler [v4]

2025-05-28 Thread Casper Norrbin
On Wed, 28 May 2025 09:08:30 GMT, Kevin Walls wrote: > Hi, looks good. > If we are removing things from jcmd PerfCounter.print output, that could > feature in the release note that you have planned. Anybody expecting these > counters using jcmd PerfCounter.print or other methods, may not know t

Re: RFR: 8241678: Remove PerfData sampling via StatSampler [v4]

2025-05-28 Thread Kevin Walls
On Thu, 22 May 2025 14:09:37 GMT, Casper Norrbin wrote: >> Hi everyone, >> >> This change removes the legacy `PerfData` sampling mechanism implemented >> through the `StatSampler` — an always-on periodic task that runs every 50ms >> my default. The sampling feature was originally introduced to

Re: RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v17]

2025-05-28 Thread Markus Grönlund
On Mon, 26 May 2025 20:57:15 GMT, Johannes Bechberger wrote: >> This is the code for the [JEP 509: CPU Time based profiling for >> JFR](https://openjdk.org/jeps/509). >> >> Currently tested using [this test >> suite](https://github.com/parttimenerd/basic-profiler-tests). This runs >> profile

Re: RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v17]

2025-05-28 Thread Johannes Bechberger
On Tue, 27 May 2025 16:34:14 GMT, Markus Grönlund wrote: >> It seems to normally be a pointer. I'll try the forward declaration later. > > Don't worry if it's too hard. It would just be a nice thing to eliminate > these special includes from the header file. The signal.h is apparently included

Re: RFR: 8356870: HotSpotDiagnosticMXBean.dumpThreads and jcmd Thread.dump_to_file updates [v2]

2025-05-28 Thread Alan Bateman
On Mon, 26 May 2025 16:06:01 GMT, Andrey Turbanov wrote: >> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. > > src/java.base/share/classes/jdk/internal/vm/Th

Re: RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v18]

2025-05-28 Thread Johannes Bechberger
> This is the code for the [JEP 509: CPU Time based profiling for > JFR](https://openjdk.org/jeps/509). > > Currently tested using [this test > suite](https://github.com/parttimenerd/basic-profiler-tests). This runs > profiles the [Renaissance](https://renaissance.dev/) benchmark with > - ... d

Re: RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v19]

2025-05-28 Thread Johannes Bechberger
> This is the code for the [JEP 509: CPU Time based profiling for > JFR](https://openjdk.org/jeps/509). > > Currently tested using [this test > suite](https://github.com/parttimenerd/basic-profiler-tests). This runs > profiles the [Renaissance](https://renaissance.dev/) benchmark with > - ... d

Re: RFR: 8357673: remove test serviceability/jvmti/vthread/TestPinCaseWithCFLH

2025-05-28 Thread Serguei Spitsyn
On Fri, 23 May 2025 20:50:15 GMT, Serguei Spitsyn wrote: > The test > `test/hotspot/jtreg/serviceability/jvmti/vthread/TestPinCaseWithCFLH/TestPinCaseWithCFLH.java` > was contributed by an external contributor to exercise the > `-Djdk.tracePinnedThreads=full` system property when a `javaagent`

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v2]

2025-05-28 Thread David Holmes
On Tue, 27 May 2025 22:48:15 GMT, Alex Menkov wrote: >> This is first (hotspot) part of the update for >> `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` to >> include lock information in thread dumps (JDK-8356870). >> The update has been split into parts to simplify review

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v2]

2025-05-28 Thread Serguei Spitsyn
On Tue, 27 May 2025 22:48:15 GMT, Alex Menkov wrote: >> This is first (hotspot) part of the update for >> `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` to >> include lock information in thread dumps (JDK-8356870). >> The update has been split into parts to simplify review

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v2]

2025-05-28 Thread Serguei Spitsyn
On Tue, 27 May 2025 22:48:15 GMT, Alex Menkov wrote: >> This is first (hotspot) part of the update for >> `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` to >> include lock information in thread dumps (JDK-8356870). >> The update has been split into parts to simplify review

Re: RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v17]

2025-05-28 Thread Johannes Bechberger
On Tue, 27 May 2025 11:36:41 GMT, Markus Grönlund wrote: >> Johannes Bechberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove assertion > > src/jdk.jfr/share/classes/jdk/jfr/internal/PlatformEventType.java line 195: > >> 193:

Re: RFR: 8356870: HotSpotDiagnosticMXBean.dumpThreads and jcmd Thread.dump_to_file updates [v2]

2025-05-28 Thread Alan Bateman
On Sat, 24 May 2025 09:37:21 GMT, Shaojin Wen wrote: >> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. > > test/jdk/com/sun/management/HotSpotDiagnosticMXBea

Re: RFR: 8241678: Remove PerfData sampling via StatSampler [v4]

2025-05-28 Thread Casper Norrbin
On Thu, 22 May 2025 14:09:37 GMT, Casper Norrbin wrote: >> Hi everyone, >> >> This change removes the legacy `PerfData` sampling mechanism implemented >> through the `StatSampler` — an always-on periodic task that runs every 50ms >> my default. The sampling feature was originally introduced to

Re: RFR: 8241678: Remove PerfData sampling via StatSampler [v4]

2025-05-28 Thread duke
On Thu, 22 May 2025 14:09:37 GMT, Casper Norrbin wrote: >> Hi everyone, >> >> This change removes the legacy `PerfData` sampling mechanism implemented >> through the `StatSampler` — an always-on periodic task that runs every 50ms >> my default. The sampling feature was originally introduced to

Integrated: 8241678: Remove PerfData sampling via StatSampler

2025-05-28 Thread Casper Norrbin
On Fri, 25 Apr 2025 10:38:39 GMT, Casper Norrbin wrote: > Hi everyone, > > This change removes the legacy `PerfData` sampling mechanism implemented > through the `StatSampler` — an always-on periodic task that runs every 50ms > my default. The sampling feature was originally introduced to coll

Integrated: 8357673: remove test serviceability/jvmti/vthread/TestPinCaseWithCFLH

2025-05-28 Thread Serguei Spitsyn
On Fri, 23 May 2025 20:50:15 GMT, Serguei Spitsyn wrote: > The test > `test/hotspot/jtreg/serviceability/jvmti/vthread/TestPinCaseWithCFLH/TestPinCaseWithCFLH.java` > was contributed by an external contributor to exercise the > `-Djdk.tracePinnedThreads=full` system property when a `javaagent`

Re: RFR: 8241678: Remove PerfData sampling via StatSampler [v4]

2025-05-28 Thread Johan Sjölen
On Thu, 22 May 2025 14:09:37 GMT, Casper Norrbin wrote: >> Hi everyone, >> >> This change removes the legacy `PerfData` sampling mechanism implemented >> through the `StatSampler` — an always-on periodic task that runs every 50ms >> my default. The sampling feature was originally introduced to

Re: RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v10]

2025-05-28 Thread Johannes Bechberger
On Mon, 26 May 2025 15:42:57 GMT, Erik Gahlin wrote: > > I will see if I can create an example with some other events that show the > > syntax, and then you can fill in the CPU-Time events. > > I have a Mac, so I could not try it with an actual recording, but something > like this: > > ``` >

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v2]

2025-05-28 Thread Alex Menkov
On Wed, 28 May 2025 07:07:27 GMT, David Holmes wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> move to ThreadService > > src/hotspot/share/services/threadService.cpp line 1170: > >> 1168: }; >> 1169: >> 1170:

RFR: 8357999: SA: FileMapInfo.metadataTypeArray initialization issue after JDK-8355003

2025-05-28 Thread Aleksey Shipilev
SonarCloud reports an issue since [JDK-8355003](https://bugs.openjdk.org/browse/JDK-8355003) integration: duplicate index in `metadataTypeArray` initialization code. Looks like a simple typo, this PR fixes it. Additional testing: - [x] Linux x86_64 server fastdebug, `serviceability/sa` -

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v2]

2025-05-28 Thread Alex Menkov
On Wed, 28 May 2025 12:58:49 GMT, Alan Bateman wrote: >> src/hotspot/share/prims/jvmtiThreadState.hpp line 80: >> >>> 78: // Virtual Thread Mount State Transition (VTMS transition) mechanism >>> 79: // >>> 80: class JvmtiVTMSTransitionDisabler : public AnyObj { >> >> Why this change? > > It's u

Re: RFR: 8357999: SA: FileMapInfo.metadataTypeArray initialization issue after JDK-8355003

2025-05-28 Thread Albert Mingkun Yang
On Wed, 28 May 2025 18:51:09 GMT, Aleksey Shipilev wrote: > SonarCloud reports an issue since > [JDK-8355003](https://bugs.openjdk.org/browse/JDK-8355003) integration: > duplicate index in `metadataTypeArray` initialization code. Looks like a > simple typo, this PR fixes it. > > Additional t

Re: RFR: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling [v25]

2025-05-28 Thread Vladimir Kozlov
On Tue, 27 May 2025 21:57:11 GMT, Igor Veresov wrote: >> Improve warm-up time by making profile data from a previous run of an >> application instantly available, when the HotSpot Java Virtual Machine >> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) >> to store me

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v2]

2025-05-28 Thread Alex Menkov
On Wed, 28 May 2025 07:10:57 GMT, David Holmes wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> move to ThreadService > > src/hotspot/share/services/threadService.cpp line 1206: > >> 1204: bool ret = _retry_hand

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v2]

2025-05-28 Thread Alex Menkov
On Wed, 28 May 2025 10:33:36 GMT, Serguei Spitsyn wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> move to ThreadService > > src/hotspot/share/prims/jvm.cpp line 2968: > >> 2966: oop snapshot = VMThreadSnapshot::g

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v2]

2025-05-28 Thread Alex Menkov
On Wed, 28 May 2025 03:47:04 GMT, Serguei Spitsyn wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> move to ThreadService > > src/hotspot/share/services/threadService.cpp line 1172: > >> 1170: Handle _java_thread;

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v4]

2025-05-28 Thread Alex Menkov
> This is first (hotspot) part of the update for > `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` to > include lock information in thread dumps (JDK-8356870). > The update has been split into parts to simplify reviewing. > The fix contains an implementation of `jdk.internal.

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v2]

2025-05-28 Thread Alex Menkov
On Wed, 28 May 2025 19:36:39 GMT, Alex Menkov wrote: >> src/hotspot/share/prims/jvm.cpp line 2968: >> >>> 2966: oop snapshot = VMThreadSnapshot::get_thread_snapshot(jthread, >>> THREAD); >>> 2967: return JNIHandles::make_local(THREAD, snapshot); >>> 2968: #elif >> >> Q: should it be `#else

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v2]

2025-05-28 Thread Alex Menkov
On Wed, 28 May 2025 03:51:36 GMT, Serguei Spitsyn wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> move to ThreadService > > src/hotspot/share/services/threadService.cpp line 1180: > >> 1178: GrowableArray* _locks

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v2]

2025-05-28 Thread Alex Menkov
On Wed, 28 May 2025 07:09:06 GMT, David Holmes wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> move to ThreadService > > src/hotspot/share/services/threadService.cpp line 1189: > >> 1187: _thread_status(), _nam

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v2]

2025-05-28 Thread Alex Menkov
On Wed, 28 May 2025 18:31:21 GMT, Alex Menkov wrote: >> src/hotspot/share/services/threadService.cpp line 1203: >> >>> 1201: } >>> 1202: >>> 1203: bool read_reset_retry() { >> >> What does the `read` mean in the name? > > read and then reset the `retry` value (return old value) removed "r

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v2]

2025-05-28 Thread Alex Menkov
On Wed, 28 May 2025 13:35:44 GMT, Alan Bateman wrote: >> src/hotspot/share/classfile/javaClasses.cpp line 1875: >> >>> 1873: >>> 1874: oop java_lang_Thread::park_blocker(oop java_thread) { >>> 1875: return java_thread->obj_field_acquire(_park_blocker_offset); >> >> Where is the releasing sto

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v4]

2025-05-28 Thread David Holmes
On Thu, 29 May 2025 03:26:49 GMT, Alex Menkov wrote: >> This is first (hotspot) part of the update for >> `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` to >> include lock information in thread dumps (JDK-8356870). >> The update has been split into parts to simplify review

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v2]

2025-05-28 Thread David Holmes
On Wed, 28 May 2025 18:16:20 GMT, Alex Menkov wrote: >> It's used by VMThreadSnapshot::get_thread_snapshot. The transition disabling >> support is currently in the jvmti code. I think this is the first usage in a >> handshake op that isn't supporting a JVMTI function. Maybe in the future >> th

Integrated: 8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1

2025-05-28 Thread PAWAN CHAWDHARY
On Mon, 28 Apr 2025 15:51:44 GMT, PAWAN CHAWDHARY wrote: > 8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1 This pull request has now been integrated. Changeset: e579cca6 Author:PAWAN CHAWDHARY Committer: Leonid Mesnik URL: https://git.openjdk.org/jdk/commit/e

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v2]

2025-05-28 Thread Alan Bateman
On Wed, 28 May 2025 07:01:53 GMT, David Holmes wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> move to ThreadService > > src/hotspot/share/prims/jvmtiThreadState.hpp line 80: > >> 78: // Virtual Thread Mount State

Integrated: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling

2025-05-28 Thread Igor Veresov
On Fri, 25 Apr 2025 20:18:41 GMT, Igor Veresov wrote: > Improve warm-up time by making profile data from a previous run of an > application instantly available, when the HotSpot Java Virtual Machine > starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) > to store method

Re: RFR: 8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1 [v3]

2025-05-28 Thread Leonid Mesnik
On Fri, 23 May 2025 04:33:36 GMT, PAWAN CHAWDHARY wrote: >> 8354475: TestDockerMemoryMetricsSubgroup.java fails with exitValue = 1 > > PAWAN CHAWDHARY has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains three commits: > > - Merge bran

Re: RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v21]

2025-05-28 Thread Johannes Bechberger
> This is the code for the [JEP 509: CPU Time based profiling for > JFR](https://openjdk.org/jeps/509). > > Currently tested using [this test > suite](https://github.com/parttimenerd/basic-profiler-tests). This runs > profiles the [Renaissance](https://renaissance.dev/) benchmark with > - ... d

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v2]

2025-05-28 Thread Alan Bateman
On Wed, 28 May 2025 06:59:48 GMT, David Holmes wrote: >> Alex Menkov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> move to ThreadService > > src/hotspot/share/classfile/javaClasses.cpp line 1875: > >> 1873: >> 1874: oop java_lang_Thr

Re: RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v22]

2025-05-28 Thread Johannes Bechberger
> This is the code for the [JEP 509: CPU Time based profiling for > JFR](https://openjdk.org/jeps/509). > > Currently tested using [this test > suite](https://github.com/parttimenerd/basic-profiler-tests). This runs > profiles the [Renaissance](https://renaissance.dev/) benchmark with > - ... d

Re: RFR: 8357999: SA: FileMapInfo.metadataTypeArray initialization issue after JDK-8355003

2025-05-28 Thread Vladimir Kozlov
On Wed, 28 May 2025 18:51:09 GMT, Aleksey Shipilev wrote: > SonarCloud reports an issue since > [JDK-8355003](https://bugs.openjdk.org/browse/JDK-8355003) integration: > duplicate index in `metadataTypeArray` initialization code. Looks like a > simple typo, this PR fixes it. > > Additional t

Re: RFR: 8357999: SA: FileMapInfo.metadataTypeArray initialization issue after JDK-8355003

2025-05-28 Thread Ioi Lam
On Wed, 28 May 2025 18:51:09 GMT, Aleksey Shipilev wrote: > SonarCloud reports an issue since > [JDK-8355003](https://bugs.openjdk.org/browse/JDK-8355003) integration: > duplicate index in `metadataTypeArray` initialization code. Looks like a > simple typo, this PR fixes it. > > Additional t

Re: RFR: 8357999: SA: FileMapInfo.metadataTypeArray initialization issue after JDK-8355003

2025-05-28 Thread Serguei Spitsyn
On Wed, 28 May 2025 18:51:09 GMT, Aleksey Shipilev wrote: > SonarCloud reports an issue since > [JDK-8355003](https://bugs.openjdk.org/browse/JDK-8355003) integration: > duplicate index in `metadataTypeArray` initialization code. Looks like a > simple typo, this PR fixes it. > > Additional t

Re: RFR: 8357650: ThreadSnapshot to take snapshot of thread for thread dumps [v3]

2025-05-28 Thread Alex Menkov
> This is first (hotspot) part of the update for > `HotSpotDiagnosticMXBean.dumpThreads` and `jcmd Thread.dump_to_file` to > include lock information in thread dumps (JDK-8356870). > The update has been split into parts to simplify reviewing. > The fix contains an implementation of `jdk.internal.

Re: RFR: 8356548: Avoid using ASM to parse latest class files in tests [v4]

2025-05-28 Thread David Holmes
On Fri, 9 May 2025 22:34:45 GMT, Chen Liang wrote: >> For early eval; test by changing the ClassReader max accepted version of >> test ASM to 24 instead of 25 > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unr