On Tue, 20 May 2025 07:10:52 GMT, Stefan Karlsson wrote:
>> While working on improving the TLAB sizing code for ZGC @kstefanj ran into
>> an issue with the following tests failing:
>> serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorInterpreterObjectTest.java
>> serviceability/jvmti/HeapMon
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote:
> The libjdwp is currently built with LOW optimization level, it could be built
> with SIZE optimization to lower the lib size by ~ 10 % on UNIX.
> On Windows LOW and SIZE currently translate to the same O1 optimization flag
> so no diff
On Tue, 20 May 2025 07:14:39 GMT, Stefan Karlsson wrote:
>> While working on improving the TLAB sizing code for ZGC @kstefanj ran into
>> an issue with the following tests failing:
>> serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorInterpreterObjectTest.java
>> serviceability/jvmti/HeapMon
On Sat, 17 May 2025 05:04:39 GMT, Chris Plummer wrote:
>> What this PR is fixing is the issue with all of our nsk/jdi testing being
>> done with includevirtualthreads=y even though debuggers typically use the
>> default includevirtualthreads=n. As a result we have a testing gap with
>> include
On Tue, 20 May 2025 19:29:56 GMT, Chris Plummer wrote:
>> What this PR is fixing is the issue with all of our nsk/jdi testing being
>> done with includevirtualthreads=y even though debuggers typically use the
>> default includevirtualthreads=n. As a result we have a testing gap with
>> include
On Tue, 20 May 2025 19:33:34 GMT, Chris Plummer wrote:
>> What this PR is fixing is the issue with all of our nsk/jdi testing being
>> done with includevirtualthreads=y even though debuggers typically use the
>> default includevirtualthreads=n. As a result we have a testing gap with
>> include
On Tue, 20 May 2025 22:04:54 GMT, Leonid Mesnik wrote:
> Thanks for explanation. The fix looks good. The only one question - if it
> does make sense to run test suite in 2 modes: with and without
> -includevirtualthreads or force -includevirtualthreads when virtual threads
> are enabled? Does
On Tue, 20 May 2025 21:41:59 GMT, John R Rose wrote:
>> The problem is CDS; I have really started with `fast_compare()`, but after
>> dehydration the pointers changed and the comparison did not work anymore.
>> This is also a reason why I could not use the hashcode for the ordering.
>> If you'd
On Mon, 5 May 2025 06:35:39 GMT, Radim Vansa wrote:
>> src/hotspot/share/oops/fieldInfo.cpp line 52:
>>
>>> 50:
>>> 51: int FieldInfoStream::compare_symbols(const Symbol *s1, const Symbol
>>> *s2) {
>>> 52: // not lexicographical sort, since we need only total ordering
>>
>> If only a total
On Tue, 20 May 2025 21:10:50 GMT, Leonid Mesnik wrote:
> It is unclear to me if
> -includevirtualthreads requires to pass test in default mode or with virtual
> thread test factory?
It means launch the debug agent with includevirtualthreads=y. It does the same
regardless of the test factory ty
On Tue, 20 May 2025 21:52:09 GMT, Chris Plummer wrote:
> It means launch the debug agent with includevirtualthreads=y. It does the
> same regardless of the test factory type. Probably the logic that actually
> passes the argument (see the change in Binder.java) could be modified to only
> do s
On Wed, 14 May 2025 12:46:41 GMT, Radim Vansa wrote:
>> This optimization is a followup to https://github.com/openjdk/jdk/pull/24290
>> trying to reduce the performance regression in some scenarios introduced in
>> https://bugs.openjdk.org/browse/JDK-8292818 . Based both on performance and
>>
On Tue, 20 May 2025 19:33:34 GMT, Chris Plummer wrote:
>> What this PR is fixing is the issue with all of our nsk/jdi testing being
>> done with includevirtualthreads=y even though debuggers typically use the
>> default includevirtualthreads=n. As a result we have a testing gap with
>> include
On Fri, 16 May 2025 23:51:39 GMT, John R Rose wrote:
>> Radim Vansa has updated the pull request incrementally with five additional
>> commits since the last revision:
>>
>> - Revert change in array.hpp
>> - Revert changes in VerifyRawIndexesTest
>> - Improve FieldInfo::print
>> - Load cons
On Tue, 20 May 2025 07:14:39 GMT, Stefan Karlsson wrote:
>> While working on improving the TLAB sizing code for ZGC @kstefanj ran into
>> an issue with the following tests failing:
>> serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorInterpreterObjectTest.java
>> serviceability/jvmti/HeapMon
> While working on improving the TLAB sizing code for ZGC @kstefanj ran into an
> issue with the following tests failing:
> serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorInterpreterObjectTest.java
> serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java
>
> T
On Sun, 18 May 2025 23:44:13 GMT, Sergey Bylokhov wrote:
> This patch suppresses compiler warning C5287 triggered in debugInit.c when
> building with Visual Studio 2022 version 17.14 (released a few days ago).
>
> I’m simply disabling the warning to unblock the broken build. This change is
> i
> What this PR is fixing is the issue with all of our nsk/jdi testing being
> done with includevirtualthreads=y even though debuggers typically use the
> default includevirtualthreads=n. As a result we have a testing gap with
> includevirtualthreads=n.
>
> includevirtualthreads=y forces the deb
On Tue, 20 May 2025 19:33:34 GMT, Chris Plummer wrote:
>> What this PR is fixing is the issue with all of our nsk/jdi testing being
>> done with includevirtualthreads=y even though debuggers typically use the
>> default includevirtualthreads=n. As a result we have a testing gap with
>> include
On Tue, 20 May 2025 06:34:20 GMT, Johan Sjölen wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ConstantPool.java
>> line 126:
>>
>>> 124: private static int INDY_BSM_OFFSET = 0;
>>> 125: private static int INDY_ARGC_OFFSET = 1;
>>> 126: private static int INDY_ARGV_OFFS
Extend try block to cover debuggee.classByname() call. I would suggest
disabling whitespace diffs when doing the review. It makes code movement and
deletions more obvious.
There are a number of places where I removed a try/catch of
InterruptedException around a Thread.sleep. This will now be ha
On Tue, 20 May 2025 19:33:34 GMT, Chris Plummer wrote:
>> What this PR is fixing is the issue with all of our nsk/jdi testing being
>> done with includevirtualthreads=y even though debuggers typically use the
>> default includevirtualthreads=n. As a result we have a testing gap with
>> include
On Sat, 17 May 2025 05:04:39 GMT, Chris Plummer wrote:
>> What this PR is fixing is the issue with all of our nsk/jdi testing being
>> done with includevirtualthreads=y even though debuggers typically use the
>> default includevirtualthreads=n. As a result we have a testing gap with
>> include
On Thu, 15 May 2025 16:21:56 GMT, Leonid Mesnik wrote:
>> PAWAN CHAWDHARY has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unused import
>
> test/hotspot/jtreg/containers/docker/TestMemoryWithSubgroups.java line 73:
>
>> 71:
> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails
PAWAN CHAWDHARY has updated the pull request incrementally with one additional
commit since the last revision:
address review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24948/files
- new: https://
25 matches
Mail list logo
