RFR: 8355617: Remove historical debug_only macro in favor of DEBUG_ONLY

2025-04-25 Thread Aleksey Shipilev
I noticed in `macros.hpp`: #ifdef ASSERT #define DEBUG_ONLY(code) code #define NOT_DEBUG(code) #define NOT_DEBUG_RETURN /*next token must be ;*/ // Historical. #define debug_only(code) code #else // ASSERT There are 350+ instances of `debug_only`, and 1600+ instances of `DEBUG_ONLY`. We can cl

Re: RFR: 8318730: MonitorVmStartTerminate.java still times out after JDK-8209595 [v3]

2025-04-25 Thread Kevin Walls
> This issue was hard to reproduce or had stopped happening, but was likely a > failure to capture the main arguments from a monitored process, caused by > slow startups e.g. -Xcomp. Recent failures seen in Graal testing are most > likely the same issue and increasing ARGS_ATTEMPTS has been see

Re: RFR: 8318730: MonitorVmStartTerminate.java still times out after JDK-8209595 [v3]

2025-04-25 Thread Chris Plummer
On Fri, 25 Apr 2025 12:38:27 GMT, Kevin Walls wrote: >> This issue was hard to reproduce or had stopped happening, but was likely a >> failure to capture the main arguments from a monitored process, caused by >> slow startups e.g. -Xcomp. Recent failures seen in Graal testing are most >> like

Re: RFR: 8355617: Remove historical debug_only macro in favor of DEBUG_ONLY

2025-04-25 Thread Kim Barrett
On Fri, 25 Apr 2025 15:17:17 GMT, Aleksey Shipilev wrote: > I noticed in `macros.hpp`: > > > #ifdef ASSERT > #define DEBUG_ONLY(code) code > #define NOT_DEBUG(code) > #define NOT_DEBUG_RETURN /*next token must be ;*/ > // Historical. > #define debug_only(code) code > #else // ASSERT > > > The

Integrated: 8355214: nsk/jdi/ThreadStartRequest/addThreadFilter/addthreadfilter001.java should use JDIBase superclass

2025-04-25 Thread Chris Plummer
On Wed, 23 Apr 2025 04:10:24 GMT, Chris Plummer wrote: > There is nsk/jdi superclass called JDIBase that many tests inherit from. It > provides common functionality like log support, basic event handling, support > for setting a breakpoint, and support for the communcation breakpoint that > th

Re: RFR: 8355617: Remove historical debug_only macro in favor of DEBUG_ONLY

2025-04-25 Thread Stefan Karlsson
On Fri, 25 Apr 2025 15:17:17 GMT, Aleksey Shipilev wrote: > I noticed in `macros.hpp`: > > > #ifdef ASSERT > #define DEBUG_ONLY(code) code > #define NOT_DEBUG(code) > #define NOT_DEBUG_RETURN /*next token must be ;*/ > // Historical. > #define debug_only(code) code > #else // ASSERT > > > The

Re: RFR: 8355214: nsk/jdi/ThreadStartRequest/addThreadFilter/addthreadfilter001.java should use JDIBase superclass

2025-04-25 Thread Chris Plummer
On Wed, 23 Apr 2025 04:10:24 GMT, Chris Plummer wrote: > There is nsk/jdi superclass called JDIBase that many tests inherit from. It > provides common functionality like log support, basic event handling, support > for setting a breakpoint, and support for the communcation breakpoint that > th

RFR: 8355003: Implement Ahead-of-Time Method Profiling

2025-04-25 Thread Igor Veresov
Improve warm-up time by making profile data from a previous run of an application instantly available, when the HotSpot Java Virtual Machine starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) to store method execution profiles from training runs, reducing profiling delay

Re: RFR: 8355490: Make VM_RedefineClasses::merge_constant_pools only take reference arguments [v2]

2025-04-25 Thread Serguei Spitsyn
On Fri, 25 Apr 2025 09:39:49 GMT, Johan Sjölen wrote: >> Hi, >> >> I've changed two pointer arguments to be references instead, as we bail if >> they are null and `assert(false)` on top of that. There are no other calls >> to this function than the one I fixed. >> >> Testing: GHA Tier1 > > Jo

Re: RFR: 8355490: Make VM_RedefineClasses::merge_constant_pools only take reference arguments

2025-04-25 Thread Johan Sjölen
On Thu, 24 Apr 2025 12:09:36 GMT, Johan Sjölen wrote: > Hi, > > I've changed two pointer arguments to be references instead, as we bail if > they are null and `assert(false)` on top of that. There are no other calls to > this function than the one I fixed. > > Testing: GHA Tier1 Thank you fo

Re: RFR: 8355490: Make VM_RedefineClasses::merge_constant_pools only take reference arguments [v2]

2025-04-25 Thread Johan Sjölen
> Hi, > > I've changed two pointer arguments to be references instead, as we bail if > they are null and `assert(false)` on top of that. There are no other calls to > this function than the one I fixed. > > Testing: GHA Tier1 Johan Sjölen has updated the pull request incrementally with one add

RFR: 8241678: Remove PerfData sampling via StatSampler

2025-04-25 Thread Casper Norrbin
Hi everyone, This change removes the legacy `PerfData` sampling mechanism implemented through the `StatSampler` — an always-on periodic task that runs every 50ms my default. The sampling feature was originally introduced to collect performance counters and timestamps, but has since seen very li

Re: RFR: 8318730: MonitorVmStartTerminate.java still times out after JDK-8209595 [v2]

2025-04-25 Thread Kevin Walls
On Thu, 24 Apr 2025 17:15:22 GMT, Chris Plummer wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Less unnecessary logging of expected exceptions > > test/jdk/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.ja

Re: RFR: 8355439: Some hotspot/jtreg/serviceability/sa/* tests fail on static JDK due to explicit checks for shared libraries in process memory map

2025-04-25 Thread Jiangli Zhou
On Fri, 25 Apr 2025 02:26:11 GMT, Serguei Spitsyn wrote: >> Please review the change for following hotspot/jtreg/serviceability/sa/* >> tests to not check for JDK/VM shared libraries when running on static JDK. >> >> - test/hotspot/jtreg/serviceability/sa/ClhsdbPmap.java >> - test/hotspot/jtreg

Integrated: 8355439: Some hotspot/jtreg/serviceability/sa/* tests fail on static JDK due to explicit checks for shared libraries in process memory map

2025-04-25 Thread Jiangli Zhou
On Wed, 23 Apr 2025 22:40:16 GMT, Jiangli Zhou wrote: > Please review the change for following hotspot/jtreg/serviceability/sa/* > tests to not check for JDK/VM shared libraries when running on static JDK. > > - test/hotspot/jtreg/serviceability/sa/ClhsdbPmap.java > - test/hotspot/jtreg/service

Re: RFR: 8355490: Make VM_RedefineClasses::merge_constant_pools only take reference arguments [v2]

2025-04-25 Thread Alex Menkov
On Fri, 25 Apr 2025 09:39:49 GMT, Johan Sjölen wrote: >> Hi, >> >> I've changed two pointer arguments to be references instead, as we bail if >> they are null and `assert(false)` on top of that. There are no other calls >> to this function than the one I fixed. >> >> Testing: GHA Tier1 > > Jo