On Mon, 3 Mar 2025 17:36:00 GMT, Jiangli Zhou wrote:
>> Please review the test fix that removes `libVThreadEventTest` explicit
>> dependency to `libjvm`, by removing the call to `JNI_GetCreatedJavaVMs` in
>> `Agent_OnAttach`. There is a `vm` argument passed via `Agent_OnAttach`. With
>> the ch
On Thu, 6 Mar 2025 13:53:31 GMT, Antonio Vieiro wrote:
>> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that
>> it's possible to parameterize this for platforms that use different flags
>> for enabling posix threads.
>>
>> This work is a continuation of the work done by G
On Mon, 3 Mar 2025 17:36:00 GMT, Jiangli Zhou wrote:
>> Please review the test fix that removes `libVThreadEventTest` explicit
>> dependency to `libjvm`, by removing the call to `JNI_GetCreatedJavaVMs` in
>> `Agent_OnAttach`. There is a `vm` argument passed via `Agent_OnAttach`. With
>> the ch
On Fri, 10 Jan 2025 14:43:00 GMT, Kevin Walls wrote:
> DescriptorSupport has a constructor and a method providing creation from, and
> export to, XML.
>
> These are unused in the JDK and have no practical known examples of usage.
> XML parsing is best done by an independent implementation, no
On Fri, 7 Mar 2025 00:18:14 GMT, David Holmes wrote:
>>> What is the intended way of using this? Do you run make with
>>> LIBPTHREAD=-pthread or do you apply a patch on libraries.m4 for the
>>> specific way of linking to pthread?
>>
>> This is in preparation of the upcoming BSD port, which use
On Fri, 7 Mar 2025 04:34:24 GMT, David Holmes wrote:
>>> OK for me now. `test_cgroupSubsystem_linux.cpp` needs a copyright update as
>>> well.
>>
>> Thanks for your review @jerboaa ! I cheched the
>> test_cgroupSubsystem_linux.cpp, it's already updated to 2025 in the master
>> branch.
>
> @se
