Re: RFR: 8351322: Parameterize link option for pthreads

2025-03-06 Thread David Holmes
On Thu, 6 Mar 2025 15:47:58 GMT, Magnus Ihse Bursie wrote: >> What is the intended way of using this? Do you run make with >> `LIBPTHREAD=-pthread` or do you apply a patch on `libraries.m4` for the >> specific way of linking to pthread? > >> What is the intended way of using this? Do you run ma

Re: RFR: 8350939: Revisit Windows PDH buffer size calculation for OperatingSystemMXBean

2025-03-06 Thread Kevin Walls
On Mon, 3 Mar 2025 12:22:01 GMT, Kevin Walls wrote: > Following on from JDK-8350820, which backed out the _snprintf to snprintf > change (JDK-8336289) in OperatingSystemImpl.c on Windows, because the counter > names were being truncated (so CPU monitoring was not possible). > > This change mov

Re: RFR: 8319055: JCMD should not buffer the whole output of commands [v4]

2025-03-06 Thread Johan Sjölen
On Thu, 6 Mar 2025 02:18:35 GMT, Alex Menkov wrote: >> The fix implements streaming output support for attach protocol. >> See JBS issue for evaluation, summary of the changes in the 1st comment. >> Testing: tier1..4,hs-tier5-svc > > Alex Menkov has updated the pull request incrementally with one

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v17]

2025-03-06 Thread David Holmes
On Sun, 2 Mar 2025 21:17:04 GMT, Sergey Chernyshev wrote: >> OK for me now. `test_cgroupSubsystem_linux.cpp` needs a copyright update as >> well. > >> OK for me now. `test_cgroupSubsystem_linux.cpp` needs a copyright update as >> well. > > Thanks for your review @jerboaa ! I cheched the > te

Re: RFR: 8319055: JCMD should not buffer the whole output of commands [v5]

2025-03-06 Thread Alex Menkov
> The fix implements streaming output support for attach protocol. > See JBS issue for evaluation, summary of the changes in the 1st comment. > Testing: tier1..4,hs-tier5-svc Alex Menkov has updated the pull request incrementally with one additional commit since the last revision: feedback --

Re: RFR: 8350939: Revisit Windows PDH buffer size calculation for OperatingSystemMXBean

2025-03-06 Thread Jaikiran Pai
On Thu, 6 Mar 2025 14:13:51 GMT, Kevin Walls wrote: > > Isn't that 32 characters? > > Yes thanks well spotted. Just to clarify, looks like I dropped a backslash > while making that note, the counter would look like `'\Process(java#0)% > Processor Time' ` > > 8-) > > (Correction, I didn't dro

Re: RFR: 8350939: Revisit Windows PDH buffer size calculation for OperatingSystemMXBean

2025-03-06 Thread Kevin Walls
On Thu, 6 Mar 2025 13:25:26 GMT, Jaikiran Pai wrote: > Isn't that 32 characters? Yes thanks well spotted. Just to clarify, looks like I dropped a backslash while making that note, the counter would look like `'\Process(java#0)% Processor Time' ` 8-) (Correction, I didn't drop a backslash, i

Re: RFR: 8351322: Parameterize link option for pthreads

2025-03-06 Thread David Holmes
On Thu, 6 Mar 2025 10:39:27 GMT, snake66 wrote: > Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's > possible to parameterize this for platforms that use different flags for > enabling posix threads. > > This work is a continuation of the work done by Greg Lewis in

RFR: 8351322: Parameterize link option for pthreads

2025-03-06 Thread snake66
Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's possible to parameterize this for platforms that use different flags for enabling posix threads. This work is a continuation of the work done by Greg Lewis in [1], but generalized for the full JDK, and set at the conf

Re: RFR: 8351322: Parameterize link option for pthreads

2025-03-06 Thread Antonio Vieiro
On Thu, 6 Mar 2025 10:39:27 GMT, snake66 wrote: > Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's > possible to parameterize this for platforms that use different flags for > enabling posix threads. > > This work is a continuation of the work done by Greg Lewis in

Re: RFR: 8351322: Parameterize link option for pthreads

2025-03-06 Thread Magnus Ihse Bursie
On Thu, 6 Mar 2025 14:21:08 GMT, Erik Joelsson wrote: > What is the intended way of using this? Do you run make with > LIBPTHREAD=-pthread or do you apply a patch on libraries.m4 for the specific > way of linking to pthread? This is in preparation of the upcoming BSD port, which uses `-pthread

Re: RFR: 8351322: Parameterize link option for pthreads

2025-03-06 Thread Magnus Ihse Bursie
On Thu, 6 Mar 2025 13:53:31 GMT, Antonio Vieiro wrote: >> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that >> it's possible to parameterize this for platforms that use different flags >> for enabling posix threads. >> >> This work is a continuation of the work done by G

Re: RFR: 8351322: Parameterize link option for pthreads

2025-03-06 Thread Magnus Ihse Bursie
On Thu, 6 Mar 2025 10:39:27 GMT, snake66 wrote: > Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's > possible to parameterize this for platforms that use different flags for > enabling posix threads. > > This work is a continuation of the work done by Greg Lewis in

Re: RFR: 8351322: Parameterize link option for pthreads

2025-03-06 Thread snake66
On Thu, 6 Mar 2025 15:56:43 GMT, Magnus Ihse Bursie wrote: >> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that >> it's possible to parameterize this for platforms that use different flags >> for enabling posix threads. >> >> This work is a continuation of the work done

Re: RFR: 8351322: Parameterize link option for pthreads

2025-03-06 Thread snake66
On Thu, 6 Mar 2025 14:15:38 GMT, Erik Joelsson wrote: >> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that >> it's possible to parameterize this for platforms that use different flags >> for enabling posix threads. >> >> This work is a continuation of the work done by Gr

Re: RFR: 8351322: Parameterize link option for pthreads

2025-03-06 Thread Magnus Ihse Bursie
On Thu, 6 Mar 2025 17:28:10 GMT, snake66 wrote: >> make/autoconf/libraries.m4 line 142: >> >>> 140: # Threading library >>> 141: if test "x$OPENJDK_TARGET_OS" = xlinux || test "x$OPENJDK_TARGET_OS" >>> = xaix; then >>> 142: BASIC_JVM_LIBS="$BASIC_JVM_LIBS $(LIBPTHREAD)" >> >> If you sp