Re: RFR: 8350939: Revisit Windows PDH buffer size calculation for OperatingSystemMXBean

2025-03-04 Thread David Holmes
On Tue, 4 Mar 2025 08:14:52 GMT, Kevin Walls wrote: >> src/jdk.management/windows/native/libmanagement_ext/OperatingSystemImpl.c >> line 296: >> >>> 294: /* PDH format patterns, and lengths of their constant component. */ >>> 295: static const char* const OBJECT_COUNTER_FMT = "\\%s\\%s"; >>> 29

Re: RFR: 8351165: Remove unused includes from vmStructs [v2]

2025-03-04 Thread Coleen Phillimore
> Please review this trivial change to remove some unneeded includes and type > declarations from vmStructs. The SystemDictionary type is unused because > classes are looked up in the ClassLoaderDataGraph in the SA, and they haven't > been in a single SystemDictionary for a very long time. > Te

Re: RFR: 8351165: Remove unused includes from vmStructs [v3]

2025-03-04 Thread Coleen Phillimore
> Please review this trivial change to remove some unneeded includes and type > declarations from vmStructs. The SystemDictionary type is unused because > classes are looked up in the ClassLoaderDataGraph in the SA, and they haven't > been in a single SystemDictionary for a very long time. > Te

RFR: 8351165: Remove unused includes from vmStructs

2025-03-04 Thread Coleen Phillimore
Please review this trivial change to remove some unneeded includes and type declarations from vmStructs. The SystemDictionary type is unused because classes are looked up in the ClassLoaderDataGraph in the SA, and they haven't been in a single SystemDictionary for a very long time. Tested with

Re: RFR: 8350524: Some hotspot/jtreg/serviceability/dcmd/vm tier1 tests fail on static JDK

2025-03-04 Thread Alan Bateman
On Sat, 22 Feb 2025 03:31:53 GMT, Jiangli Zhou wrote: > Please review the fix in following tests to not check for shared libraries > when running on static JDK: > > test/hotspot/jtreg/serviceability/dcmd/vm/DynLibsTest.java > test/hotspot/jtreg/serviceability/dcmd/vm/SystemDumpMapTest.java > te

Re: RFR: 8351165: Remove unused includes from vmStructs [v3]

2025-03-04 Thread Kim Barrett
On Tue, 4 Mar 2025 13:22:24 GMT, Coleen Phillimore wrote: >> Please review this trivial change to remove some unneeded includes and type >> declarations from vmStructs. The SystemDictionary type is unused because >> classes are looked up in the ClassLoaderDataGraph in the SA, and they >> have

Re: RFR: 8351165: Remove unused includes from vmStructs [v3]

2025-03-04 Thread Coleen Phillimore
On Tue, 4 Mar 2025 14:30:49 GMT, Kim Barrett wrote: > I think that if classes are being removed from here that the friendship with VMStructs by those classes should also be removed. Good point. Thanks for remembering these. - PR Comment: https://git.openjdk.org/jdk/pull/23897#issu

Re: RFR: 8351165: Remove unused includes from vmStructs [v4]

2025-03-04 Thread Coleen Phillimore
> Please review this trivial change to remove some unneeded includes and type > declarations from vmStructs. The SystemDictionary type is unused because > classes are looked up in the ClassLoaderDataGraph in the SA, and they haven't > been in a single SystemDictionary for a very long time. > Te

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v17]

2025-03-04 Thread duke
On Fri, 28 Feb 2025 20:40:37 GMT, Sergey Chernyshev wrote: >> Cgroup V1 subsustem fails to initialize mounted controllers properly in >> certain cases, that may lead to controllers left undetected/inactive. We >> observed the behavior in CloudFoundry deployments, it affects also host >> syste

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v17]

2025-03-04 Thread Matthias Baesken
On Fri, 28 Feb 2025 20:40:37 GMT, Sergey Chernyshev wrote: >> Cgroup V1 subsustem fails to initialize mounted controllers properly in >> certain cases, that may lead to controllers left undetected/inactive. We >> observed the behavior in CloudFoundry deployments, it affects also host >> syste

Re: RFR: 8350939: Revisit Windows PDH buffer size calculation for OperatingSystemMXBean

2025-03-04 Thread Kevin Walls
On Tue, 4 Mar 2025 06:42:09 GMT, David Holmes wrote: >> Following on from JDK-8350820, which backed out the _snprintf to snprintf >> change (JDK-8336289) in OperatingSystemImpl.c on Windows, because the >> counter names were being truncated (so CPU monitoring was not possible). >> >> This chan