On Wed, 8 Jan 2025 07:45:24 GMT, Ramkumar Sunderbabu
wrote:
>> Trivial logging message change.
>
> Ramkumar Sunderbabu has updated the pull request incrementally with one
> additional commit since the last revision:
>
> incorporated review comments
It looks okay with the suggestion from Dav
This is the same change that I pushed as commit
098afc8b7d0e7caa82999fb9d4e319ea8aed09a1 but now coordinated with @mur47x111
for the graal changes.
A tier1 sanity test in progress.
-
Commit messages:
- 8347147: [REDO] AccessFlags can be u2 in metadata
Changes: https://git.openjd
On Wed, 8 Jan 2025 17:33:09 GMT, Patricio Chilano Mateo
wrote:
> I see. Yes, we still need the handshake in
> JvmtiEventControllerPrivate::enter_interp_only_mode to safely walk the stack
> of the target to deoptimize the frames. When leaving interpreter only mode we
> just decrement _interp_o
On Wed, 8 Jan 2025 07:45:24 GMT, Ramkumar Sunderbabu
wrote:
>> Trivial logging message change.
>
> Ramkumar Sunderbabu has updated the pull request incrementally with one
> additional commit since the last revision:
>
> incorporated review comments
@rsunderbabu
Your change (at version 28c1
This is a fix of one more deadlock issue related to `interruptLock` critical
sections. When the `interruptLock` is hold by the target virtual thread it is
unsafe to suspend or post JVMTI events. This update is to ignore the JVMTI
events when the `interruptLock` is hold. It is additionally to the
> This test fixes an issue with incomplete Windows threads not yet having a
> stack. A test for a null stack_base is added to guard against the potential
> null dereference. An additional test using ZGC is added to the jtreg
> SystemMapTest.
Simon Tooke has updated the pull request with a new
On Wed, 8 Jan 2025 05:23:29 GMT, Chris Plummer wrote:
> Since [JDK-8285417](https://bugs.openjdk.org/browse/JDK-8285417) is now
> closed as a dup of
> [JDK-8347137](https://bugs.openjdk.org/browse/JDK-8347137), its problem list
> entry needs to be updated.
Marked as reviewed by amenkov (Revie
On Wed, 8 Jan 2025 05:23:29 GMT, Chris Plummer wrote:
> Since [JDK-8285417](https://bugs.openjdk.org/browse/JDK-8285417) is now
> closed as a dup of
> [JDK-8347137](https://bugs.openjdk.org/browse/JDK-8347137), its problem list
> entry needs to be updated.
Looks good.
-
Marked a
On Wed, 8 Jan 2025 13:38:09 GMT, Coleen Phillimore wrote:
> This is the same change that I pushed as commit
> 098afc8b7d0e7caa82999fb9d4e319ea8aed09a1 but now coordinated with @mur47x111
> for the graal changes.
>
> A tier1 sanity test complete.
PR for original review here: https://github.co
On Wed, 8 Jan 2025 05:35:34 GMT, Serguei Spitsyn wrote:
> The fix looks good. It is a great and important finding - thanks! What was
> bothering me is that the `EnterInterpOnlyModeClosure` is used in the
> `JvmtiEventControllerPrivate::enter_interp_only_mode()` but no
> `HandshakeClosure` is u
> This is the same change that I pushed as commit
> 098afc8b7d0e7caa82999fb9d4e319ea8aed09a1 but now coordinated with @mur47x111
> for the graal changes.
>
> A tier1 sanity test complete.
Coleen Phillimore has refreshed the contents of this pull request, and previous
commits have been removed
> This is a redo of [JDK-8304824](https://bugs.openjdk.org/browse/JDK-8304824)
> which was backed out by
> [JDK-8343726](https://bugs.openjdk.org/browse/JDK-8343726) due to problems
> documented in [JDK-8343244](https://bugs.openjdk.org/browse/JDK-8343244).
>
> The problem was that `NmtVirtualM
> This is the same change that I pushed as commit
> 098afc8b7d0e7caa82999fb9d4e319ea8aed09a1 but now coordinated with @mur47x111
> for the graal changes.
>
> A tier1 sanity test complete.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last re
On Wed, 8 Jan 2025 16:43:51 GMT, Coleen Phillimore wrote:
>> This is the same change that I pushed as commit
>> 098afc8b7d0e7caa82999fb9d4e319ea8aed09a1 but now coordinated with @mur47x111
>> for the graal changes.
>>
>> A tier1 sanity test complete.
>
> Coleen Phillimore has refreshed the co
On Wed, 8 Jan 2025 07:45:24 GMT, Ramkumar Sunderbabu
wrote:
>> Trivial logging message change.
>
> Ramkumar Sunderbabu has updated the pull request incrementally with one
> additional commit since the last revision:
>
> incorporated review comments
Marked as reviewed by lmesnik (Reviewer).
On Wed, 8 Jan 2025 21:01:37 GMT, Simon Tooke wrote:
>> This test fixes an issue with incomplete Windows threads not yet having a
>> stack. A test for a null stack_base is added to guard against the potential
>> null dereference. An additional test using ZGC is added to the jtreg
>> SystemMap
On Wed, 8 Jan 2025 16:38:50 GMT, Robert Toyonaga wrote:
>> This is a redo of [JDK-8304824](https://bugs.openjdk.org/browse/JDK-8304824)
>> which was backed out by
>> [JDK-8343726](https://bugs.openjdk.org/browse/JDK-8343726) due to problems
>> documented in [JDK-8343244](https://bugs.openjdk.o
On Wed, 8 Jan 2025 16:43:51 GMT, Coleen Phillimore wrote:
>> This is the same change that I pushed as commit
>> 098afc8b7d0e7caa82999fb9d4e319ea8aed09a1 but now coordinated with @mur47x111
>> for the graal changes.
>>
>> A tier1 sanity test complete.
>
> Coleen Phillimore has refreshed the co
On Wed, 8 Jan 2025 13:38:09 GMT, Coleen Phillimore wrote:
> This is the same change that I pushed as commit
> 098afc8b7d0e7caa82999fb9d4e319ea8aed09a1 but now coordinated with @mur47x111
> for the graal changes.
>
> A tier1 sanity test complete.
This pull request has now been integrated.
Ch
Please review a doc-only change to mostly add missing `@serial` javadoc tags.
This is a sub-task of [JDK-8286931] to allow us to re-enable the javadoc
`-serialwarn` option in the JDK doc build, which has been disabled since JDK 19.
[JDK-8286931]: https://bugs.openjdk.org/browse/JDK-8286931
For
On Tue, 7 Jan 2025 03:09:59 GMT, Leonid Mesnik wrote:
> Test nsk/jvmti/ResourceExhausted/resexhausted003 limits metaspace size. 9m
> is not enough if sharing classes are disabled.
> It starts failing with -XX:+UseCompactObjectHeaders just because CDS archives
> are no built this mode. Never
On Mon, 6 Jan 2025 16:41:21 GMT, Patricio Chilano Mateo
wrote:
> Please review the following fix. In method
> `JvmtiEventControllerPrivate::recompute_thread_enabled()`, we are missing to
> call `leave_interp_only_mode()` for the case where `should_be_interp` is
> computed as false and `state-
On Wed, 8 Jan 2025 07:45:24 GMT, Ramkumar Sunderbabu
wrote:
>> Trivial logging message change.
>
> Ramkumar Sunderbabu has updated the pull request incrementally with one
> additional commit since the last revision:
>
> incorporated review comments
Looks good. Thanks
-
Marked
On Wed, 8 Jan 2025 16:43:51 GMT, Coleen Phillimore wrote:
>> This is the same change that I pushed as commit
>> 098afc8b7d0e7caa82999fb9d4e319ea8aed09a1 but now coordinated with @mur47x111
>> for the graal changes.
>>
>> A tier1 sanity test complete.
>
> Coleen Phillimore has refreshed the co
On Tue, 7 Jan 2025 19:53:20 GMT, Serguei Spitsyn wrote:
>> New JVMTI function `ClearAllFramePops` will help to speedup debugger single
>> stepping in some cases.
>> Additionally, the JVMTI `NotifyFramePop` implementation was fixed to return
>> `JVMTI_ERROR_DUPLICATE` to make it consistent with
On Tue, 7 Jan 2025 19:47:10 GMT, Serguei Spitsyn wrote:
>> The JVMTI NotifyFramePop should return JVMTI_ERROR_DUPLICATE in a case the
>> specified FramePop event was already requested. This makes it consistent
>> with the SetBreakpoint which returns the JVMTI_ERROR_DUPLICATE on an attempt
>> t
On Wed, 8 Jan 2025 05:23:29 GMT, Chris Plummer wrote:
> Since [JDK-8285417](https://bugs.openjdk.org/browse/JDK-8285417) is now
> closed as a dup of
> [JDK-8347137](https://bugs.openjdk.org/browse/JDK-8347137), its problem list
> entry needs to be updated.
This pull request has now been integ
On Wed, 8 Jan 2025 05:23:29 GMT, Chris Plummer wrote:
> Since [JDK-8285417](https://bugs.openjdk.org/browse/JDK-8285417) is now
> closed as a dup of
> [JDK-8347137](https://bugs.openjdk.org/browse/JDK-8347137), its problem list
> entry needs to be updated.
Thank you Alex and Kevin!
-
> This test fixes an issue with incomplete Windows threads not yet having a
> stack. A test for a null stack_base is added to guard against the potential
> null dereference. An additional test using ZGC is added to the jtreg
> SystemMapTest.
Simon Tooke has updated the pull request incrementa
On Mon, 6 Jan 2025 21:20:28 GMT, David Holmes wrote:
>> Please review the following fix. In method
>> `JvmtiEventControllerPrivate::recompute_thread_enabled()`, we are missing to
>> call `leave_interp_only_mode()` for the case where `should_be_interp` is
>> computed as false and `state->is_pen
30 matches
Mail list logo
