RFR: 8346990: Remove INTX_FORMAT and UINTX_FORMAT macros

2025-01-03 Thread Coleen Phillimore
There are a lot of format modifiers that are noisy and unnecessary in the code. This change removes the INTX variants. It's not that disruptive even for backporting because %z modifier has been available for a long time so should backport fine. This was mostly done with a sed script plus some

RFR: 8346985: Convert test/jdk/com/sun/jdi/ClassUnloadEventTest.java to Class-File API

2025-01-03 Thread Adam Sotona
This patch converts the remaining test/jdk/com/sun/jdi/ClassUnloadEventTest.java from ASM to Class-File API. Please review. Thanks, Adam - Commit messages: - 8346985: Convert test/jdk/com/sun/jdi/ClassUnloadEventTest.java to Class-File API Changes: https://git.openjdk.org/jdk/pu

Re: RFR: 8346717: serviceability/dcmd/vm/SystemDumpMapTest.java failing on Windows with "Stack base not yet set for thread id" [v2]

2025-01-03 Thread Simon Tooke
On Wed, 25 Dec 2024 00:26:30 GMT, Leonid Mesnik wrote: >> Simon Tooke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> refine jtreg tags per review > > test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTest.java line 39: > >> 37: *

Re: RFR: 8339113: AccessFlags can be u2 in metadata [v9]

2025-01-03 Thread Coleen Phillimore
On Thu, 2 Jan 2025 23:33:31 GMT, Serguei Spitsyn wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Happy New Year > > src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 1151: > >> 1149: // methods matc

Re: RFR: 8339113: AccessFlags can be u2 in metadata [v10]

2025-01-03 Thread Coleen Phillimore
> Please review this change that makes AccessFlags and modifier_flags u2 types > and removes the last remnants of Hotspot adding internal access flags. This > change moves AccessFlags and modifier_flags in Klass to alignment gaps saving > 16 bytes. From pahole: so it's a bit better. > > befor

Re: RFR: 8339113: AccessFlags can be u2 in metadata [v11]

2025-01-03 Thread Coleen Phillimore
> Please review this change that makes AccessFlags and modifier_flags u2 types > and removes the last remnants of Hotspot adding internal access flags. This > change moves AccessFlags and modifier_flags in Klass to alignment gaps saving > 16 bytes. From pahole: so it's a bit better. > > befor

Re: RFR: 8346985: Convert test/jdk/com/sun/jdi/ClassUnloadEventTest.java to Class-File API

2025-01-03 Thread Chen Liang
On Fri, 3 Jan 2025 13:02:07 GMT, Adam Sotona wrote: > This patch converts the remaining > test/jdk/com/sun/jdi/ClassUnloadEventTest.java from ASM to Class-File API. > > Please review. > > Thanks, > Adam Marked as reviewed by liach (Reviewer). test/jdk/com/sun/jdi/ClassUnloadEventTest.java li

Re: RFR: 8342996: Enhance Attach API to support arbitrary length arguments - OSX

2025-01-03 Thread Serguei Spitsyn
On Fri, 3 Jan 2025 01:57:49 GMT, Alex Menkov wrote: > The fix updates client side of OSX implementation to support Attach API v2. > Server side is shared with Linux and was updated by #3. > The changes are identical to client-side changes for Linux from #3. > > Testing: tier1,tier2,tier3

Re: RFR: 8346990: Remove INTX_FORMAT and UINTX_FORMAT macros

2025-01-03 Thread Julian Waters
On Fri, 3 Jan 2025 14:32:39 GMT, Coleen Phillimore wrote: > There are a lot of format modifiers that are noisy and unnecessary in the > code. This change removes the INTX variants. It's not that disruptive even > for backporting because %z modifier has been available for a long time so > sho

Re: RFR: 8346990: Remove INTX_FORMAT and UINTX_FORMAT macros [v2]

2025-01-03 Thread Coleen Phillimore
> There are a lot of format modifiers that are noisy and unnecessary in the > code. This change removes the INTX variants. It's not that disruptive even > for backporting because %z modifier has been available for a long time so > should backport fine. This was mostly done with a sed script p

Re: RFR: 8346990: Remove INTX_FORMAT and UINTX_FORMAT macros

2025-01-03 Thread Coleen Phillimore
On Fri, 3 Jan 2025 14:32:39 GMT, Coleen Phillimore wrote: > There are a lot of format modifiers that are noisy and unnecessary in the > code. This change removes the INTX variants. It's not that disruptive even > for backporting because %z modifier has been available for a long time so > sho