On Mon, 9 Dec 2024 10:07:14 GMT, Fabian Meumertzheim wrote:
>> The return value of Metrics#getCpuSetCpus may change over time, including
>> from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one
> additional commit
Some files have been modified in 2024, but the copyright year has not been
properly updated. This should be fixed.
I have located these modified files using:
git log --since="Jan 1" --name-only --pretty=format: | sort -u > file.list
and then run a script to update the copyright year to 2024 on
On Fri, 6 Dec 2024 17:05:42 GMT, Fabian Meumertzheim wrote:
> The return value of Metrics#getCpuSetCpus may change over time, including
> from non-null to null across the two calls in this method.
This pull request has now been integrated.
Changeset: d7ef3ac0
Author:Fabian Meumertzheim
Co
On Mon, 9 Dec 2024 12:14:32 GMT, Fabian Meumertzheim wrote:
> Apologies in advance if this is not the right process, but could this be
> cherry-picked into JDK 21?
Please see
https://github.com/openjdk/jdk21u-dev?tab=readme-ov-file#welcome-to-openjdk-21-updates
for the process.
-
On Mon, 9 Dec 2024 12:07:33 GMT, Kevin Walls wrote:
>> Fabian Meumertzheim has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Empty commit to trigger CI checks
>
> I think we can consider that failure some annoying noise. It's not expected
Some files have been modified in 2024, but the copyright year has not been
properly updated. This should be fixed.
I have located these modified files using:
git log --since="Jan 1" --name-only --pretty=format: | sort -u > file.list
and then run a script to update the copyright year to 2024 on
On Mon, 9 Dec 2024 12:27:21 GMT, Severin Gehwolf wrote:
>> @kevinjwalls Thanks! Apologies in advance if this is not the right process,
>> but could this be cherry-picked into JDK 21?
>
>> Apologies in advance if this is not the right process, but could this be
>> cherry-picked into JDK 21?
>
>
On Sat, 7 Dec 2024 08:34:45 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> combine like 128MB regions
>
> src/hotspot/os/bsd/memMapPrinter_macosx.cpp line 97:
>
>> 95: _file_name.print_raw
On Mon, 9 Dec 2024 12:41:45 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
> Some files have been modified in 2024, but the copyright year has not been
> properly updated. This should be fixed.
>
> I have located these modified files using:
>
> git log --since="Jan 1" --name-only --pretty=format: | sort -u > file.list
>
> and then run a script to update the copyright
Some files have been modified in 2024, but the copyright year has not been
properly updated. This should be fixed.
I have located these modified files using:
git log --since="Jan 1" --name-only --pretty=format: | sort -u > file.list
and then run a script to update the copyright year to 2024 on
> Some files have been modified in 2024, but the copyright year has not been
> properly updated. This should be fixed.
>
> I have located these modified files using:
>
> git log --since="Jan 1" --name-only --pretty=format: | sort -u > file.list
>
> and then run a script to update the copyright
On Mon, 9 Dec 2024 12:27:21 GMT, Severin Gehwolf wrote:
>> @kevinjwalls Thanks! Apologies in advance if this is not the right process,
>> but could this be cherry-picked into JDK 21?
>
>> Apologies in advance if this is not the right process, but could this be
>> cherry-picked into JDK 21?
>
>
On Mon, 9 Dec 2024 04:22:54 GMT, David Holmes wrote:
>> This moves the modifier_flag computation to when InstanceKlass,
>> ObjArrayKlass and TypeArrayKlass are created.
>>
>> Tested with jck:vm and tier1-4.
>
> src/hotspot/share/classfile/javaClasses.cpp line 1119:
>
>> 1117: // to support C
On Mon, 9 Dec 2024 12:41:45 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Fri, 6 Dec 2024 22:00:14 GMT, Coleen Phillimore wrote:
> This moves the modifier_flag computation to when InstanceKlass, ObjArrayKlass
> and TypeArrayKlass are created.
>
> Tested with jck:vm and tier1-4.
The JVM call is Class.getModifiers() and there are compiler intrinsics because
I gues
On Mon, 9 Dec 2024 13:00:49 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/classfile/javaClasses.cpp line 1119:
>>
>>> 1117: // to support Class.getModifiers(). Instance classes recalculate
>>> 1118: // the cached flags after the class file is parsed, but before the
>>> 1119: // class
On Mon, 9 Dec 2024 13:00:20 GMT, Severin Gehwolf wrote:
> Since this is my second merged PR to the OpenJDK, could I become one?
If you want to be, the process for becoming OpenJDK author is described here:
https://openjdk.org/projects/#project-author
The relevant project is `jdk`:
https://openj
On Fri, 6 Dec 2024 18:02:53 GMT, Fabian Meumertzheim wrote:
>> The return value of Metrics#getCpuSetCpus may change over time, including
>> from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one
> additional commit
On Fri, 6 Dec 2024 18:02:53 GMT, Fabian Meumertzheim wrote:
>> The return value of Metrics#getCpuSetCpus may change over time, including
>> from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one
> additional commit
On Fri, 6 Dec 2024 18:02:53 GMT, Fabian Meumertzheim wrote:
>> The return value of Metrics#getCpuSetCpus may change over time, including
>> from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one
> additional commit
On Mon, 9 Dec 2024 10:07:14 GMT, Fabian Meumertzheim wrote:
>> The return value of Metrics#getCpuSetCpus may change over time, including
>> from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one
> additional commit
On Mon, 9 Dec 2024 10:07:14 GMT, Fabian Meumertzheim wrote:
>> The return value of Metrics#getCpuSetCpus may change over time, including
>> from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one
> additional commit
> The return value of Metrics#getCpuSetCpus may change over time, including
> from non-null to null across the two calls in this method.
Fabian Meumertzheim has updated the pull request incrementally with one
additional commit since the last revision:
Empty commit to trigger CI checks
--
On Mon, 9 Dec 2024 10:07:14 GMT, Fabian Meumertzheim wrote:
>> The return value of Metrics#getCpuSetCpus may change over time, including
>> from non-null to null across the two calls in this method.
>
> Fabian Meumertzheim has updated the pull request incrementally with one
> additional commit
On Fri, 6 Dec 2024 22:55:22 GMT, Simon Tooke wrote:
>> This is a port of #16301 to macOS.
>>
>> System.map and System.dump_map are implemented using the macOS API and
>> provide roughly the same information in the same format. Most of the heavy
>> lifting was implemented by @tstuefe in
>> ht
> This is a port of #16301 to macOS.
>
> System.map and System.dump_map are implemented using the macOS API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in
> https://github.com/openjdk/jdk/pull/16301 - this PR adds the m
On Mon, 9 Dec 2024 13:03:06 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 13:17:35 GMT, Thomas Stuefe wrote:
>> Simon Tooke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add constant
>
> src/hotspot/os/bsd/memMapPrinter_macosx.cpp line 49:
>
>> 47: static const int MAX_REGIONS_RETURNED =
On Mon, 9 Dec 2024 02:08:58 GMT, David Holmes wrote:
>> This change only verifies redefined classes if Verification is enabled.
>> BytecodeVerificationRemote will be false for verification turned off. If
>> someone turns it off but BytecodeVerificationLocal on (which is
>> non-sensical), the
On Mon, 9 Dec 2024 13:03:06 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 12:41:45 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 13:03:06 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Fri, 6 Dec 2024 15:11:20 GMT, Chen Liang wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [49664195](https://github.com/openjdk/jdk/commit/496641955041c5e48359e6256a4a61812653d900)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> This is a test-on
On Fri, 6 Dec 2024 15:11:20 GMT, Chen Liang wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [49664195](https://github.com/openjdk/jdk/commit/496641955041c5e48359e6256a4a61812653d900)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> This is a test-on
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Wed, 4 Dec 2024 03:07:46 GMT, Alex Menkov wrote:
> The PR fixes race in the test between ThreadStart/ThreadEnd callbacks and
> agent thread:
> The callbacks increments event counter and then do self-suspend;
> Agent thread waits when expected number of events is received, then performs
> ver
On Mon, 9 Dec 2024 13:03:06 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 15:26:00 GMT, Kevin Walls wrote:
> I also meant to note that there are updates to binaries,
> src/java.base/share/classes/jdk/internal/icu/impl/data/icudt76b/... which
> maybe isn't intentional, or I just don't understand?
That was certainly not intentional! I'm not sure how
> Some files have been modified in 2024, but the copyright year has not been
> properly updated. This should be fixed.
>
> I have located these modified files using:
>
> git log --since="Jan 1" --name-only --pretty=format: | sort -u > file.list
>
> and then run a script to update the copyright
On Mon, 9 Dec 2024 15:16:10 GMT, Roger Riggs wrote:
> That git query isn't correct for all the files in the repo. In particular,
> the copyrights on third party files are NOT updated uniformly when new
> versions are applied. In particular, XML files are NOT updated.
I'm not sure I understand
On Tue, 19 Nov 2024 00:04:16 GMT, Alex Menkov wrote:
> The fix updates Linux (and server-side of macosx) implementation to support
> Attach API v2 (shared code and Windows implementation were introduced by
> #20782)
>
> Testing: tier1,tier2,tier3,tier4,hs-tier5-svc
> manually tested backward c
On Fri, 6 Dec 2024 15:11:20 GMT, Chen Liang wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [49664195](https://github.com/openjdk/jdk/commit/496641955041c5e48359e6256a4a61812653d900)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> This is a test-on
On Fri, 6 Dec 2024 22:28:29 GMT, Chris Plummer wrote:
> This test fails after
> [JDK-8338713](https://bugs.openjdk.org/browse/JDK-8338713) when using
> JTREG_TEST_THREAD_FACTORY=Virtual. The test uses JVMTI StopThread on a thread
> expecting it to be mounted. Before
> [JDK-8338713](https://bu
On Mon, 9 Dec 2024 20:52:14 GMT, Serguei Spitsyn wrote:
> The fix looks good modulo potential renaming of the `run1()` method.
I think you and @AlanBateman did quite understand what I meant by:
> It also needs to support test runs with platforms threads. See how run()
> checks if it is running
> Some files have been modified in 2024, but the copyright year has not been
> properly updated. This should be fixed.
>
> I have located these modified files using:
>
> git log --since="Jan 1" --name-only --pretty=format: | sort -u > file.list
>
> and then run a script to update the copyright
On Mon, 9 Dec 2024 21:44:42 GMT, Serguei Spitsyn wrote:
> > I think you and @AlanBateman didn't quite understand what I meant by:
> > . . .
> > The run1() method is called regardless of whether or not we are using
> > vthreads and VThreadPinner, so I don't think runPinned() is a good name for
>
On Fri, 6 Dec 2024 22:28:29 GMT, Chris Plummer wrote:
> This test fails after
> [JDK-8338713](https://bugs.openjdk.org/browse/JDK-8338713) when using
> JTREG_TEST_THREAD_FACTORY=Virtual. The test uses JVMTI StopThread on a thread
> expecting it to be mounted. Before
> [JDK-8338713](https://bu
On Mon, 9 Dec 2024 15:45:42 GMT, Magnus Ihse Bursie wrote:
>> That git query isn't correct for all the files in the repo. In particular,
>> the copyrights on third party files are NOT updated uniformly when new
>> versions are applied. In particular, XML files are NOT updated.
>
>> That git que
On Mon, 9 Dec 2024 21:09:41 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
> This is a port of #16301 to macOS.
>
> System.map and System.dump_map are implemented using the macOS API and
> provide roughly the same information in the same format. Most of the heavy
> lifting was implemented by @tstuefe in
> https://github.com/openjdk/jdk/pull/16301 - this PR adds the m
On Mon, 9 Dec 2024 17:01:40 GMT, Kevin Walls wrote:
> VirtualMachineImpl.java and attachListener_PLATFORM.cpp have much in common
> between platforms, but maybe creating new common base classes is an
> interesting refactor work with not that much payoff.
Yes, there a lot of common code between
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 21:09:41 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
55 matches
Mail list logo
