Re: RFR: 8338383: Implementation of Synchronize Virtual Threads without Pinning [v2]

2024-10-21 Thread Axel Boldt-Christmas
On Mon, 21 Oct 2024 15:45:21 GMT, Patricio Chilano Mateo wrote: >> This is the implementation of JEP 491: Synchronize Virtual Threads without >> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for >> further details. >> >> In order to make the code review easier the change

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-21 Thread Weijun Wang
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v4]

2024-10-21 Thread William Kemper
On Fri, 11 Oct 2024 21:17:59 GMT, William Kemper wrote: >> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 579: >> >>> 577: st->print("Status: "); >>> 578: if (has_forwarded_objects()) st->print("has >>> forwarded objects, "); >>> 579: if (is_concurrent_mark_in_pro

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-21 Thread Kevin Walls
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-21 Thread Sean Mullan
On Sat, 19 Oct 2024 07:54:07 GMT, Alan Bateman wrote: > There are a couple of micro benchmarks in test/micro that fork with > `jvmArgsPrepend={"-Djava.security.manager=allow"})`, they will need to be > examined. Fixed, will be in next drop. There are a couple of other micro tests that test th

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Volodymyr Paprotski
On Mon, 21 Oct 2024 18:00:14 GMT, Roman Kennke wrote: >>> I've managed to reproduce the ECoreIndexOf crash locally by running with >>> -XX:+UseSerialGC -XX:+UnlockExperimentalVMOptions >>> -XX:+UseCompactObjectHeaders. The crash happens on line 773 when reading >>> past the needle. >>> >>> ``

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-21 Thread Phil Race
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8341927: Remove hardcoded SunJCE provider

2024-10-21 Thread Andrey Turbanov
On Wed, 16 Oct 2024 18:47:44 GMT, Matthew Donovan wrote: > In this PR, I removed hard-coded security providers and replaced them with a > system property, test.provider.name. If the property is not specified, the > provider originally used in the test is used: > > Cipher c = Cipher.getInstance

Re: RFR: 8338383: Implementation of Synchronize Virtual Threads without Pinning

2024-10-21 Thread Andrey Turbanov
On Thu, 17 Oct 2024 14:28:30 GMT, Patricio Chilano Mateo wrote: > This is the implementation of JEP 491: Synchronize Virtual Threads without > Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for > further details. > > In order to make the code review easier the changes hav

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Stefan Karlsson
On Thu, 17 Oct 2024 10:57:24 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-21 Thread Daniel Fuchs
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-21 Thread Weijun Wang
On Fri, 18 Oct 2024 19:52:35 GMT, Sean Mullan wrote: >> I assume for the second one above you mean >> `javax.security.auth.kerberos.ServicePermission`. These classes still have a >> lot of words like "grant" and "trust". I will make some changes to the >> class descriptions of those classes,

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v44]

2024-10-21 Thread Thomas Stuefe
On Wed, 16 Oct 2024 15:37:59 GMT, Coleen Phillimore wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Problem-list SharedBaseAddress tests on aarch64 > > src/hotspot/share/oops/compressedKlass.cpp line 185: > >> 183

Re: RFR: 8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY

2024-10-21 Thread Erik Joelsson
On Sun, 20 Oct 2024 02:11:11 GMT, SendaoYan wrote: > Hi all, > In > [make/RunTests.gmk](https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L208), > the keyword is 'TEST_THREAD_FACTORY'. > > So the below test command will print error: > > make test TEST=test/jdk/java/math/BigInteger/

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Magnus Ihse Bursie
On Thu, 17 Oct 2024 10:57:24 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Stefan Karlsson
On Thu, 17 Oct 2024 10:57:24 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Coleen Phillimore
On Thu, 17 Oct 2024 10:57:24 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY

2024-10-21 Thread Magnus Ihse Bursie
On Sun, 20 Oct 2024 02:11:11 GMT, SendaoYan wrote: > Hi all, > In > [make/RunTests.gmk](https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L208), > the keyword is 'TEST_THREAD_FACTORY'. > > So the below test command will print error: > > make test TEST=test/jdk/java/math/BigInteger/

RFR: 8342633: javax/management/security/HashedPasswordFileTest.java creates tmp file in src dir

2024-10-21 Thread Kevin Walls
Test update: HashedPasswordFileTest.java was using System.getProperty("test.src") as a place to _create_ a file. jtreg gives us the current working directory for the test invocation as a scratch directory. Create files there, without reading any property to find another location.

Re: RFR: 8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY [v2]

2024-10-21 Thread SendaoYan
> Hi all, > In > [make/RunTests.gmk](https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L208), > the keyword is 'TEST_THREAD_FACTORY'. > > So the below test command will print error: > > make test TEST=test/jdk/java/math/BigInteger/TestValueExact.java > CONF=linux-x86_64-server-relea

Re: RFR: 8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY [v2]

2024-10-21 Thread SendaoYan
On Mon, 21 Oct 2024 12:48:55 GMT, Erik Joelsson wrote: >> SendaoYan has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - JTREG="TEST_THREAD_FACTORY=Virtual" >> - Use JTREG="JTREG_TEST_THREAD_FACTORY=Virtual" to make comment more cleaner >

Re: RFR: 8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY [v2]

2024-10-21 Thread Magnus Ihse Bursie
On Mon, 21 Oct 2024 13:12:55 GMT, SendaoYan wrote: >> Hi all, >> In >> [make/RunTests.gmk](https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L208), >> the keyword is 'TEST_THREAD_FACTORY'. >> >> So the below test command will print error: >> >> make test TEST=test/jdk/java/math/Big

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v23]

2024-10-21 Thread Thomas Stuefe
On Fri, 20 Sep 2024 17:46:21 GMT, Coleen Phillimore wrote: >> Roman Kennke has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'lilliput/JEP-450-temporary-fix-branch-2' >> into JDK-8305895-v4 >> - review feed

Re: RFR: 8341927: Remove hardcoded SunJCE provider

2024-10-21 Thread Sean Mullan
On Wed, 16 Oct 2024 18:47:44 GMT, Matthew Donovan wrote: > In this PR, I removed hard-coded security providers and replaced them with a > system property, test.provider.name. If the property is not specified, the > provider originally used in the test is used: > > Cipher c = Cipher.getInstance

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Roman Kennke
On Thu, 17 Oct 2024 10:57:24 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Roman Kennke
On Mon, 21 Oct 2024 13:53:58 GMT, Roman Kennke wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Compact header riscv (#3) >> >> Implement compact headers on RISCV >> - >> >> Co-authored-by: hamli

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Volodymyr Paprotski
On Mon, 21 Oct 2024 13:53:58 GMT, Roman Kennke wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Compact header riscv (#3) >> >> Implement compact headers on RISCV >> - >> >> Co-authored-by: hamli

Re: RFR: 8342682: Errors related to unused code on Windows after 8339120

2024-10-21 Thread Julian Waters
On Mon, 21 Oct 2024 14:34:30 GMT, Julian Waters wrote: > After 8339120, gcc began catching many different instances of unused code in > the Windows specific codebase. Some of these seem to be bugs. I've taken the > effort to mark out all the relevant globals and locals that trigger the > unuse

RFR: 8342682: Errors related to unused code on Windows after 8339120

2024-10-21 Thread Julian Waters
After 8339120, gcc began catching many different instances of unused code in the Windows specific codebase. Some of these seem to be bugs. I've taken the effort to mark out all the relevant globals and locals that trigger the unused warnings and addressed all of them by commenting out the code a

Re: RFR: 8342633: javax/management/security/HashedPasswordFileTest.java creates tmp file in src dir

2024-10-21 Thread Daniel Fuchs
On Mon, 21 Oct 2024 09:21:35 GMT, Kevin Walls wrote: > Test update: HashedPasswordFileTest.java was using > System.getProperty("test.src") as a place to _create_ a file. > > jtreg gives us the current working directory for the test invocation as a > scratch directory. Create files there, with

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-21 Thread Daniel Fuchs
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Volodymyr Paprotski
On Mon, 21 Oct 2024 13:53:58 GMT, Roman Kennke wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Compact header riscv (#3) >> >> Implement compact headers on RISCV >> - >> >> Co-authored-by: hamli

Re: RFR: 8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY [v2]

2024-10-21 Thread Erik Joelsson
On Mon, 21 Oct 2024 13:12:55 GMT, SendaoYan wrote: >> Hi all, >> In >> [make/RunTests.gmk](https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L208), >> the keyword is 'TEST_THREAD_FACTORY'. >> >> So the below test command will print error: >> >> make test TEST=test/jdk/java/math/Big

Re: RFR: 8338383: Implementation of Synchronize Virtual Threads without Pinning [v2]

2024-10-21 Thread Patricio Chilano Mateo
> This is the implementation of JEP 491: Synchronize Virtual Threads without > Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for > further details. > > In order to make the code review easier the changes have been split into the > following initial 4 commits: > > - Change

Re: RFR: 8338383: Implementation of Synchronize Virtual Threads without Pinning [v2]

2024-10-21 Thread Patricio Chilano Mateo
On Fri, 18 Oct 2024 04:21:57 GMT, Patricio Chilano Mateo wrote: >> src/hotspot/share/runtime/javaThread.hpp line 165: >> >>> 163: // ID used as owner for inflated monitors. Same as the >>> j.l.Thread.tid of the >>> 164: // current _vthread object, except during creation of the primordial

Re: RFR: 8338383: Implementation of Synchronize Virtual Threads without Pinning [v2]

2024-10-21 Thread Patricio Chilano Mateo
On Mon, 21 Oct 2024 08:01:09 GMT, Andrey Turbanov wrote: >> Patricio Chilano Mateo has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Adjust spacing in test JfrEvents.java >> - Adjust comment in JavaThread.hpp >> - RISC-V: Avoid retur

Re: RFR: 8338383: Implementation of Synchronize Virtual Threads without Pinning [v3]

2024-10-21 Thread Patricio Chilano Mateo
> This is the implementation of JEP 491: Synchronize Virtual Threads without > Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for > further details. > > In order to make the code review easier the changes have been split into the > following initial 4 commits: > > - Change

Re: RFR: 8338383: Implementation of Synchronize Virtual Threads without Pinning [v3]

2024-10-21 Thread Patricio Chilano Mateo
On Mon, 21 Oct 2024 06:38:28 GMT, Axel Boldt-Christmas wrote: >> Patricio Chilano Mateo has updated the pull request incrementally with six >> additional commits since the last revision: >> >> - Fix comments in objectMonitor.hpp >> - Move frame::saved_thread_address() to platform dependent f

Re: RFR: 8338383: Implementation of Synchronize Virtual Threads without Pinning [v3]

2024-10-21 Thread Patricio Chilano Mateo
On Mon, 21 Oct 2024 07:57:31 GMT, Axel Boldt-Christmas wrote: >> Patricio Chilano Mateo has updated the pull request incrementally with six >> additional commits since the last revision: >> >> - Fix comments in objectMonitor.hpp >> - Move frame::saved_thread_address() to platform dependent f

Re: RFR: 8342682: Errors related to unused code on Windows after 8339120

2024-10-21 Thread Julian Waters
On Tue, 22 Oct 2024 01:40:11 GMT, David Holmes wrote: > > and whatever team is responsible for HotSpot debugging. > > I don't see anything hotspot related here. > > I think you would be better off splitting this up into distinct issues and > PRs for different areas. I expect the client team in

Re: RFR: 8342682: Errors related to unused code on Windows after 8339120

2024-10-21 Thread David Holmes
On Mon, 21 Oct 2024 14:34:30 GMT, Julian Waters wrote: > and whatever team is responsible for HotSpot debugging. I don't see anything hotspot related here. I think you would be better off splitting this up into distinct issues and PRs for different areas. I expect the client team in particular

Re: RFR: 8342633: javax/management/security/HashedPasswordFileTest.java creates tmp file in src dir

2024-10-21 Thread Alex Menkov
On Mon, 21 Oct 2024 09:21:35 GMT, Kevin Walls wrote: > Test update: HashedPasswordFileTest.java was using > System.getProperty("test.src") as a place to _create_ a file. > > jtreg gives us the current working directory for the test invocation as a > scratch directory. Create files there, with

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Roman Kennke
On Mon, 21 Oct 2024 18:00:14 GMT, Roman Kennke wrote: >>> I've managed to reproduce the ECoreIndexOf crash locally by running with >>> -XX:+UseSerialGC -XX:+UnlockExperimentalVMOptions >>> -XX:+UseCompactObjectHeaders. The crash happens on line 773 when reading >>> past the needle. >>> >>> ``

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Volodymyr Paprotski
On Mon, 21 Oct 2024 20:31:28 GMT, Roman Kennke wrote: >>> @rkennke Could you post the full command you used please? And perhaps also >>> the seed that gets printed.. having trouble getting it to fail.. >>> >>> So far I added a few options and perrmitations of: >>> `./build/linux-x86_64-server-

Re: RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental) [v5]

2024-10-21 Thread William Kemper
> This PR merges JEP 404, a generational mode for the Shenandoah garbage > collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would > like to target JDK24 with this PR. William Kemper has updated the pull request with a new target base due to a merge or a rebase. The pull r

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Sandhya Viswanathan
On Mon, 21 Oct 2024 18:52:46 GMT, Volodymyr Paprotski wrote: > Thanks @rkennke able to reproduce now.. Sandhya will have a patch soon and I > will re-verify @rkennke @vpaprotsk Please find attached the patch which should fix the problem. [smallneedlefix.patch](https://github.com/user-attachmen

Re: RFR: 8341927: Remove hardcoded SunJCE provider [v2]

2024-10-21 Thread Matthew Donovan
> In this PR, I removed hard-coded security providers and replaced them with a > system property, test.provider.name. If the property is not specified, the > provider originally used in the test is used: > > Cipher c = Cipher.getInstance("AES/GCM/NoPadding", > System.getProperty("test.provider.

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v17]

2024-10-21 Thread Ioi Lam
> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315737) and the > [CSR](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v12]

2024-10-21 Thread Ioi Lam
On Mon, 23 Sep 2024 17:56:39 GMT, Calvin Cheung wrote: >> Ioi Lam has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 15 commits: >> >> - Merge branch >> 'jep-483-step-02-8338018-rename-class-prelinker-to-aot-cp-resolver' into >> j

Re: RFR: 8304824: NMT should not use ThreadCritical [v8]

2024-10-21 Thread Robert Toyonaga
On Sat, 12 Oct 2024 18:42:34 GMT, Afshin Zafari wrote: >> Robert Toyonaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update src/hotspot/share/utilities/vmError.cpp >> >> Co-authored-by: David Holmes >> <62092539+dholmes-...@us

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v17]

2024-10-21 Thread Calvin Cheung
On Mon, 21 Oct 2024 20:46:56 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/