RFR: 8341168: Cleanup dead code after JDK-8322630

2024-09-30 Thread Axel Boldt-Christmas
[JDK-8322630](https://bugs.openjdk.org/browse/JDK-8322630) / #17495 removed the the concept of ICStubs, InlineCache buffers and related safepoints. There are a handfull of references and auxiliary constructs still in the code, I propose we clean these out. This removes the unused: * Experiment

Re: RFR: 8341168: Cleanup dead code after JDK-8322630 [v2]

2024-09-30 Thread Thomas Schatzl
On Mon, 30 Sep 2024 08:15:51 GMT, Axel Boldt-Christmas wrote: >> [JDK-8322630](https://bugs.openjdk.org/browse/JDK-8322630) / #17495 removed >> the the concept of ICStubs, InlineCache buffers and related safepoints. >> >> There are a handfull of references and auxiliary constructs still in the

Re: RFR: 8341168: Cleanup dead code after JDK-8322630 [v2]

2024-09-30 Thread Hamlin Li
On Mon, 30 Sep 2024 08:15:51 GMT, Axel Boldt-Christmas wrote: >> [JDK-8322630](https://bugs.openjdk.org/browse/JDK-8322630) / #17495 removed >> the the concept of ICStubs, InlineCache buffers and related safepoints. >> >> There are a handfull of references and auxiliary constructs still in the

Integrated: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container)

2024-09-30 Thread Sebastian Lövdahl
On Thu, 2 May 2024 10:13:51 GMT, Sebastian Lövdahl wrote: > 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid > (Kubernetes debug container) This pull request has now been integrated. Changeset: 52ba7282 Author:Sebastian Lövdahl Committer: Severin Gehwolf URL: h

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v7]

2024-09-30 Thread Severin Gehwolf
On Sun, 29 Sep 2024 06:23:34 GMT, Sebastian Lövdahl wrote: >> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid >> (Kubernetes debug container) > > Sebastian Lövdahl has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev exclu

Re: RFR: 8341168: Cleanup dead code after JDK-8322630

2024-09-30 Thread Stefan Karlsson
On Mon, 30 Sep 2024 07:39:11 GMT, Axel Boldt-Christmas wrote: > [JDK-8322630](https://bugs.openjdk.org/browse/JDK-8322630) / #17495 removed > the the concept of ICStubs, InlineCache buffers and related safepoints. > > There are a handfull of references and auxiliary constructs still in the >

Re: RFR: 8341060: Cleanup statics in HeapDumper [v2]

2024-09-30 Thread Aleksey Shipilev
On Fri, 27 Sep 2024 19:42:12 GMT, Alex Menkov wrote: >> The fix cleans up static variables/methods in HeapDumper. >> See jira for details. >> >> Testing: >> heap dump-related tests (test/hotspot/jtreg/serviceability, >> test/hotspot/jtreg/compiler/c2/TestReduceAllocationAndHeapDump.java, >>

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v7]

2024-09-30 Thread Kevin Walls
On Sun, 29 Sep 2024 06:23:34 GMT, Sebastian Lövdahl wrote: >> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid >> (Kubernetes debug container) > > Sebastian Lövdahl has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev exclu

Re: RFR: 8341168: Cleanup dead code after JDK-8322630 [v2]

2024-09-30 Thread Axel Boldt-Christmas
> [JDK-8322630](https://bugs.openjdk.org/browse/JDK-8322630) / #17495 removed > the the concept of ICStubs, InlineCache buffers and related safepoints. > > There are a handfull of references and auxiliary constructs still in the > code, I propose we clean these out. > > This removes the unused:

Re: RFR: 8341168: Cleanup dead code after JDK-8322630 [v2]

2024-09-30 Thread Aleksey Shipilev
On Mon, 30 Sep 2024 08:13:10 GMT, Axel Boldt-Christmas wrote: >> [JDK-8322630](https://bugs.openjdk.org/browse/JDK-8322630) / #17495 removed >> the the concept of ICStubs, InlineCache buffers and related safepoints. >> >> There are a handfull of references and auxiliary constructs still in the

Re: RFR: 8341168: Cleanup dead code after JDK-8322630 [v2]

2024-09-30 Thread Stefan Karlsson
On Mon, 30 Sep 2024 08:13:10 GMT, Axel Boldt-Christmas wrote: >> [JDK-8322630](https://bugs.openjdk.org/browse/JDK-8322630) / #17495 removed >> the the concept of ICStubs, InlineCache buffers and related safepoints. >> >> There are a handfull of references and auxiliary constructs still in the

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v7]

2024-09-30 Thread duke
On Sun, 29 Sep 2024 06:23:34 GMT, Sebastian Lövdahl wrote: >> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid >> (Kubernetes debug container) > > Sebastian Lövdahl has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev exclu

Re: RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v7]

2024-09-30 Thread Sebastian Lövdahl
On Sun, 29 Sep 2024 06:23:34 GMT, Sebastian Lövdahl wrote: >> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid >> (Kubernetes debug container) > > Sebastian Lövdahl has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev exclu

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v11]

2024-09-30 Thread Roberto Castañeda Lozano
On Thu, 12 Sep 2024 13:20:14 GMT, Emanuel Peter wrote: > Indeed, I could re-enable all tests in: > > ``` > test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java > test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java > test/hotspot/jtreg/compiler/loopopts/su

Re: RFR: 8341246: Test com/sun/tools/attach/PermissionTest.java fails access denied

2024-09-30 Thread Severin Gehwolf
On Mon, 30 Sep 2024 16:11:27 GMT, SendaoYan wrote: > Hi all, > Test `com/sun/tools/attach/PermissionTest.java` fails access denied after > [JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114). This testcase > need the `readlink` permission of file `/proc/self/ns/mnt` after > [JDK-8327114

RFR: 8334305: Remove all code for nsk.share.Log verbose mode

2024-09-30 Thread Ramkumar Sunderbabu
Cleaning up nsk.share.Log code after the verbose mode was set always true. Tested all the vmTestbase/ tests. - Commit messages: - 8334305: Remove all code for nsk.share.Log verbose mode Changes: https://git.openjdk.org/jdk/pull/21267/files Webrev: https://webrevs.openjdk.org/?rep

RFR: 8341246: Test com/sun/tools/attach/PermissionTest.java fails access denied

2024-09-30 Thread SendaoYan
Hi all, Test `com/sun/tools/attach/PermissionTest.java` fails access denied after [JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114). This testcase need the `readlink` permission of file `/proc/self/ns/mnt` after [JDK-8327114](https://bugs.openjdk.org/browse/JDK-8327114). So this PR add

Re: RFR: 8334305: Remove all code for nsk.share.Log verbose mode

2024-09-30 Thread Leonid Mesnik
On Mon, 30 Sep 2024 14:55:33 GMT, Ramkumar Sunderbabu wrote: > Cleaning up nsk.share.Log code after the verbose mode was set always true. > > Tested all the vmTestbase/ tests. Marked as reviewed by lmesnik (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/21267#pullreques

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v26]

2024-09-30 Thread Roman Kennke
On Fri, 27 Sep 2024 16:23:15 GMT, Roman Kennke wrote: >> I believe the code in the patch is good enough as-is, especially if >> `UseCompactObjectHeaders` is slated to go away. The existing `if` will >> prevent the < 16 byte header code from being emitted, which is the desired >> behavior - i.

Re: RFR: 8334305: Remove all code for nsk.share.Log verbose mode

2024-09-30 Thread duke
On Mon, 30 Sep 2024 14:55:33 GMT, Ramkumar Sunderbabu wrote: > Cleaning up nsk.share.Log code after the verbose mode was set always true. > > Tested all the vmTestbase/ tests. @rsunderbabu Your change (at version a346de1ce3387f99bb3f8d63c64b9c6bc1212bcb) is now ready to be sponsored by a Com

Re: RFR: 8334305: Remove all code for nsk.share.Log verbose mode

2024-09-30 Thread Ramkumar Sunderbabu
On Mon, 30 Sep 2024 21:07:59 GMT, Chris Plummer wrote: >> Cleaning up nsk.share.Log code after the verbose mode was set always true. >> >> Tested all the vmTestbase/ tests. > > test/hotspot/jtreg/vmTestbase/nsk/share/Log.java line 287: > >> 285: if (!verbose()) { >> 286: doP

Re: RFR: 8334305: Remove all code for nsk.share.Log verbose mode

2024-09-30 Thread David Holmes
On Mon, 30 Sep 2024 14:55:33 GMT, Ramkumar Sunderbabu wrote: > Cleaning up nsk.share.Log code after the verbose mode was set always true. > > Tested all the vmTestbase/ tests. @rsunderbabu this should wait for the second review by @plummercj to be completed before it is integrated. Thanks.

Re: RFR: 8334305: Remove all code for nsk.share.Log verbose mode [v2]

2024-09-30 Thread Ramkumar Sunderbabu
> Cleaning up nsk.share.Log code after the verbose mode was set always true. > > Tested all the vmTestbase/ tests. Ramkumar Sunderbabu has updated the pull request incrementally with one additional commit since the last revision: Addressed review comments - Changes: - all: htt

Re: RFR: 8334305: Remove all code for nsk.share.Log verbose mode

2024-09-30 Thread Ramkumar Sunderbabu
On Tue, 1 Oct 2024 01:42:09 GMT, David Holmes wrote: > @rsunderbabu this should wait for the second review by @plummercj to be > completed before it is integrated. Thanks. Thanks for pointing out David. I missed seeing those comments. I have addressed them now. - PR Comment: http

Re: RFR: 8336881: [Linux] Support for hierarchical limits for Metrics [v9]

2024-09-30 Thread Severin Gehwolf
> Please review this fix for cgroups-based metrics reporting in the > `jdk.internal.platform` package. This fix is supposed to address wrong > reporting of certain limits if the limits aren't set at the leaf nodes. > > For example, on cg v2, the memory limit interface file is `memory.max`. > Co

Re: RFR: 8336881: [Linux] Support for hierarchical limits for Metrics [v9]

2024-09-30 Thread Severin Gehwolf
On Mon, 30 Sep 2024 12:03:14 GMT, Severin Gehwolf wrote: >> Please review this fix for cgroups-based metrics reporting in the >> `jdk.internal.platform` package. This fix is supposed to address wrong >> reporting of certain limits if the limits aren't set at the leaf nodes. >> >> For example,

Re: RFR: 8334305: Remove all code for nsk.share.Log verbose mode [v2]

2024-09-30 Thread Chris Plummer
On Tue, 1 Oct 2024 01:35:54 GMT, Ramkumar Sunderbabu wrote: >> test/hotspot/jtreg/vmTestbase/nsk/share/Log.java line 287: >> >>> 285: if (!verbose()) { >>> 286: doPrint(message); >>> 287: } >> >> Is this method ever called? Is there a CR to remove it (and any refere

Re: RFR: 8334305: Remove all code for nsk.share.Log verbose mode [v2]

2024-09-30 Thread Chris Plummer
On Tue, 1 Oct 2024 01:52:20 GMT, Ramkumar Sunderbabu wrote: >> Cleaning up nsk.share.Log code after the verbose mode was set always true. >> >> Tested all the vmTestbase/ tests. > > Ramkumar Sunderbabu has updated the pull request incrementally with one > additional commit since the last revis

Re: RFR: 8334305: Remove all code for nsk.share.Log verbose mode [v2]

2024-09-30 Thread Ramkumar Sunderbabu
On Tue, 1 Oct 2024 01:52:20 GMT, Ramkumar Sunderbabu wrote: >> Cleaning up nsk.share.Log code after the verbose mode was set always true. >> >> Tested all the vmTestbase/ tests. > > Ramkumar Sunderbabu has updated the pull request incrementally with one > additional commit since the last revis

Re: RFR: 8334305: Remove all code for nsk.share.Log verbose mode

2024-09-30 Thread Chris Plummer
On Mon, 30 Sep 2024 14:55:33 GMT, Ramkumar Sunderbabu wrote: > Cleaning up nsk.share.Log code after the verbose mode was set always true. > > Tested all the vmTestbase/ tests. test/hotspot/jtreg/vmTestbase/nsk/share/Log.java line 264: > 262: > 263: /** > 264: * Print message to the

RFR: 8337511: Implement JEP-404: Generational Shenandoah (Experimental)

2024-09-30 Thread William Kemper
This PR merges JEP 404, a generational mode for the Shenandoah garbage collector. The JEP can be viewed here: https://openjdk.org/jeps/404. We would like to target JDK24 with this PR. - Commit messages: - 8337511: Implement JEP-404: Generational Shenandoah (Experimental) Changes: