On Mon, 9 Sep 2024 05:11:44 GMT, David Holmes wrote:
> I think we need to understand why this happens, as I don't see this being a
> test issue. I assume the test needs to run under a none-US locale for the
> problem to arise?
The locale of test enviroment is `en_US.UTF-8`, and this test also
On Mon, 9 Sep 2024 06:10:23 GMT, Alan Bateman wrote:
> In addition to the locale, can you confirm that you are testing an images
> build and not an exploded build?
Mine configure command is show as below, the tested jdk located in
`/tmp/tone/run/jtreg/jdk-repo/build/linux-aarch64-server-releas
On Sun, 8 Sep 2024 15:30:21 GMT, SendaoYan wrote:
> Hi all,
> The newly added testcase
> `serviceability/jvmti/vthread/TestPinCaseWithCFLH/TestPinCaseWithCFLH.java`
> fails with `-Xcomp` jvm option. The jvm option `-Xcomp` will make
> `BackgroundCompilation` false. In this test, disable `Bac
On Mon, 9 Sep 2024 08:37:58 GMT, Alan Bateman wrote:
> Can you say if there are any other modifications to the JDK that is being
> tested? I'm wondering if anyone else can duplicate this.
No, there is no any modification of the tested JDK. This failure only occur on
specific environments, seem
On Sun, 8 Sep 2024 15:30:21 GMT, SendaoYan wrote:
> Hi all,
> The newly added testcase
> `serviceability/jvmti/vthread/TestPinCaseWithCFLH/TestPinCaseWithCFLH.java`
> fails with `-Xcomp` jvm option. The jvm option `-Xcomp` will make
> `BackgroundCompilation` false. In this test, disable `Bac
On Sun, 8 Sep 2024 15:30:21 GMT, SendaoYan wrote:
> Hi all,
> The newly added testcase
> `serviceability/jvmti/vthread/TestPinCaseWithCFLH/TestPinCaseWithCFLH.java`
> fails with `-Xcomp` jvm option. The jvm option `-Xcomp` will make
> `BackgroundCompilation` false. In this test, disable `Bac
On Mon, 9 Sep 2024 09:18:24 GMT, Alan Bateman wrote:
> I assume the sleep or System.gc is just delaying the install of the
> transformer. I think this issue will require more investigation. The "main"
> method hasn't run so I assume the issue is nothing to do with virtual threads
> and the dia
On Mon, 9 Sep 2024 06:28:45 GMT, Alan Bateman wrote:
>> This PR proposes to add a JDK-specific monitoring and management interface
>> for the virtual thread scheduler. The interface is named
>> [VirtualThreadSchedulerMXBean](https://download.java.net/java/early_access/loom/docs/api/jdk.manageme
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Mon, 9 Sep 2024 10:29:55 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> previ
On Thu, 22 Aug 2024 20:08:43 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Mon, 9 Sep 2024 11:55:52 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> previ
On Mon, 9 Sep 2024 11:55:52 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> previ
On Fri, 30 Aug 2024 18:10:44 GMT, Albert Mingkun Yang wrote:
>> FWIW, the ParallelGC does something very similar to what you propose, except
>> that it walks bitmaps instead of paring the space to find the self-forwarded
>> objects. It then has a check inside object_iterate to make sure that it
On Fri, 30 Aug 2024 07:42:39 GMT, Thomas Stuefe wrote:
>> Yes. This silent setting of UseCompactObjectHeaders ended up hiding why we
>> got CDS failures. I would also suggest that we change this to FLAG_SET_ERGO.
>
> Seems we run all into the same thoughts :)
>
> I added
>
> Suggestion:
>
>
On Thu, 22 Aug 2024 19:50:21 GMT, Albert Mingkun Yang wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix hash shift for 32 bit builds
>
> src/hotspot/share/gc/shared/gcForwarding.hpp line 36:
>
>> 34: * Implemen
On Sat, 7 Sep 2024 05:27:12 GMT, Kim Barrett wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also includ
On Thu, 5 Sep 2024 16:10:05 GMT, Gerard Ziemski wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes
On Fri, 23 Aug 2024 11:38:39 GMT, Hamlin Li wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix bit counts in GCForwarding
>
> src/hotspot/share/oops/oop.inline.hpp line 94:
>
>> 92:
>> 93: void oopDesc::init_mar
On Tue, 27 Aug 2024 07:43:07 GMT, Hamlin Li wrote:
>> @Hamlin-Li : AFAIK, porting to linux-riscv platform has NOT been started
>> yet. To avoid duplicate work, please let me know if anyone is interested or
>> has been working on it :-)
>
> Yes, I'm interested in it. Thanks for raising the discu
On Mon, 26 Aug 2024 21:52:58 GMT, Chris Plummer wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix bit counts in GCForwarding
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Oop.java line 169:
>
>> 1
On Fri, 30 Aug 2024 08:06:31 GMT, Stefan Karlsson wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix bit counts in GCForwarding
>
> src/hotspot/share/cds/filemap.cpp line 2507:
>
>> 2505: }
>> 2506:
>> 2507:
On Mon, 9 Sep 2024 15:00:09 GMT, Stefan Karlsson wrote:
> could be any value that is not a valid field offset
I understand that that "random value" needs to satisfy this condition.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/20677#discussion_r1750433800
On Mon, 9 Sep 2024 12:21:19 GMT, Thomas Schatzl wrote:
>> Roman Kennke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Try to avoid lea in loadNklass (aarch64)
>> - Fix release build error
>
> src/hotspot/share/oops/oop.hpp line 134:
On Mon, 9 Sep 2024 14:47:28 GMT, Stefan Karlsson wrote:
>> src/hotspot/share/cds/filemap.cpp line 2508:
>>
>>> 2506:
>>> 2507: if (compact_headers() != UseCompactObjectHeaders) {
>>> 2508: log_info(cds)("The shared archive file's UseCompactObjectHeaders
>>> setting (%s)"
>>
>> Printing
On Mon, 9 Sep 2024 12:49:05 GMT, Roman Kennke wrote:
>>> If we get a promotion failure in the young gen, we are leaving the dead
>>> objects marked as forwarded.
>>
>> True; need to do sth like `obj->init_mark();` for the non-self-forwarded
>> case. The postcondition is that no forwarded objs
On Mon, 9 Sep 2024 12:59:36 GMT, Roman Kennke wrote:
> That %zu is SIZE_FORMAT, right?
Yes. Reviewers have lately encouraged people to use %zu instead of SIZE_FORMAT.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/20677#discussion_r1750482486
On Mon, 26 Aug 2024 21:30:51 GMT, Chris Plummer wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix bit counts in GCForwarding
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Oop.java line 85:
>
>> 83
On Mon, 9 Sep 2024 14:32:49 GMT, Roman Kennke wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Oop.java line 169:
>>
>>> 167: } else {
>>> 168: visitor.doMetadata(klass, true);
>>> 169: }
>>
>> Why is there no `visitor.doMetadata()` call for the compa
On Mon, 9 Sep 2024 00:13:25 GMT, David Holmes wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also inclu
On Sat, 7 Sep 2024 05:24:29 GMT, Kim Barrett wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also includ
On Mon, 9 Sep 2024 13:36:26 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/utilities/chunkedList.hpp line 31:
>>
>>> 29: #include "utilities/debug.hpp"
>>> 30:
>>> 31: template class ChunkedList : public CHeapObj {
>>
>> Parameter name should be updated. Suggest `mem_tag`.
>
> How about
On Mon, 9 Sep 2024 00:04:58 GMT, David Holmes wrote:
>> src/hotspot/share/gc/shared/taskqueue.hpp line 119:
>>
>>> 117: // TaskQueueSuper collects functionality common to all
>>> GenericTaskQueue instances.
>>> 118:
>>> 119: template
>>
>> MemTag parameter name should probably be changed her
On Sat, 7 Sep 2024 05:21:50 GMT, Kim Barrett wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also includ
On Thu, 5 Sep 2024 16:10:05 GMT, Gerard Ziemski wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes a cleanup of all the related parameter names and local
>
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes a cleanup of all the related parameter names and local
>
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Thu, 5 Sep 2024 13:25:17 GMT, Severin Gehwolf wrote:
>> Please review this fix for cgroups-based metrics reporting in the
>> `jdk.internal.platform` package. This fix is supposed to address wrong
>> reporting of certain limits if the limits aren't set at the leaf nodes.
>>
>> For example, o
On Mon, 9 Sep 2024 16:51:35 GMT, Chris Plummer wrote:
>> There is no dedicated klass field anymore, the Klass* is encoded in the
>> mark, and we would need to extract it. What is the purpose of the visitors?
>> Do they need to see the klass/compressedKlass, or is it sufficient to visit
>> the
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes a cleanup of all the related parameter names and local
>
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes a cleanup of all the related parameter names and local
>
On Mon, 9 Sep 2024 18:34:10 GMT, Chris Plummer wrote:
>> I've been looking into this. It's a bit hard to follow but I think you do
>> need to do something more here. Can you run ClhsdbInspect.java and send me
>> the output. In specific I need to know if the log includes the following:
>>
>>
>
On Mon, 9 Sep 2024 17:45:47 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> previ
On Mon, 9 Sep 2024 11:55:52 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> previ
On Mon, 9 Sep 2024 10:02:53 GMT, Thomas Schatzl wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix bit counts in GCForwarding
>
> src/hotspot/share/oops/compressedKlass.hpp line 43:
>
>> 41:
>> 42: // Tiny-cla
On Mon, 9 Sep 2024 18:15:38 GMT, Coleen Phillimore wrote:
>> Roman Kennke has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Print as warning when UCOH doesn't match in CDS archive
>> - Improve initialization of mark-word in CDS ArchiveH
On Mon, 9 Sep 2024 20:04:22 GMT, Stefan Karlsson wrote:
>> src/hotspot/share/oops/typeArrayKlass.cpp line 175:
>>
>>> 173: size_t TypeArrayKlass::oop_size(oop obj) const {
>>> 174: // In this assert, we cannot safely access the Klass* with compact
>>> headers.
>>> 175: assert(UseCompactObje
This test fails periodically. It only prints the exception message when it
fails. It should print the entire stack trace so we have a better idea of why
it is failing.
Testing: This test is not run until tier5 CI testing, so I'm running all tier5
svc tests.
-
Commit messages:
- P
> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>
> **Overview**
>
> - A new `-XX:+AOTClassLinking` flag is added. See [JEP
> 498](https://bugs.openjdk.org/browse/JDK-8315737) and the
> [CSR](https://bugs.openjdk.org/bro
On Mon, 9 Sep 2024 05:15:20 GMT, David Holmes wrote:
>> I tried to separate the "types" from the "values". I think this makes it
>> easy to see how many types there are.
>
> Sorry I don't follow. This is just like a printf call
I changed it according to your suggestion.
-
PR Revie
On Mon, 9 Sep 2024 17:13:11 GMT, Gerard Ziemski wrote:
> The template parameter rename I was planning on doing in a followup issue,
> however, if you really want, I can make the fix here too.
Personally I'd be okay with doing it here as one final commit that can be
viewed in isolation.
--
On Tue, 10 Sep 2024 00:53:32 GMT, Ioi Lam wrote:
>> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>>
>> **Overview**
>>
>> - A new `-XX:+AOTClassLinking` flag is added. See [JEP
>> 498](https://bugs.openjdk.org/browse/
54 matches
Mail list logo
