Re: RFR: 8319873: Add windows implementation for jcmd System.map and System.dump_map

2024-08-20 Thread Thomas Stuefe
On Thu, 15 Aug 2024 13:45:16 GMT, Simon Tooke wrote: > This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) to > Windows. > > System.map and System.dump_map are implemented using the Windows API and > provide roughly the same information in the same format. Most of the h

Re: RFR: 8319873: Add windows implementation for jcmd System.map and System.dump_map

2024-08-20 Thread Thomas Stuefe
On Tue, 20 Aug 2024 06:36:26 GMT, Thomas Stuefe wrote: >> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301) >> to Windows. >> >> System.map and System.dump_map are implemented using the Windows API and >> provide roughly the same information in the same format. Most o

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2024-08-20 Thread Pavel Rappo
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote: >> JDK .properties files still use ISO-8859-1 encoding with escape sequences. >> It would improve readability to see the native characters instead of escape >> sequences (especially for the L10n process). The majority of files changed >> are l

Re: RFR: 8338482: com/sun/jdi/ThreadMemoryLeakTest.java requires that compressed oops are enabled

2024-08-20 Thread Kevin Walls
On Fri, 16 Aug 2024 05:41:01 GMT, Chris Plummer wrote: > com/sun/jdi/ThreadMemoryLeakTest.java purposely runs with a small heap so it > is easier to detect a memory leak with an OOME. Running without compressed > oops uses more memory leading to an OOME even though there is no leak. We > shoul

[jdk23] RFR: 8338139: {ClassLoading, Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods

2024-08-20 Thread Stefan Karlsson
Hi all, This pull request contains a backport of commit [9775d571](https://github.com/openjdk/jdk/commit/9775d57168695dc0d758e017fe5069d93d593f3e) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Stefan Karlsson on 20 Aug 2024 and was

Re: [jdk23] RFR: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods

2024-08-20 Thread Kevin Walls
On Tue, 20 Aug 2024 12:47:59 GMT, Stefan Karlsson wrote: > Hi all, > > This pull request contains a backport of commit > [9775d571](https://github.com/openjdk/jdk/commit/9775d57168695dc0d758e017fe5069d93d593f3e) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit

8315884: New Object to ObjectMonitor mapping causes linux-aarch64 musl to fail

2024-08-20 Thread Vitaly Provodin
Hi all Recently we at JetBrains became getting the following build failure for Linux aarch64 musl ===8<--- . . . Compiling up to 55 files for jdk.jpackage /mnt/agent/work/f25b6e4d8156543c/src/hotspot/share/runtime/synchronizer.cpp: In stat

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v2]

2024-08-20 Thread Naoto Sato
On Tue, 20 Aug 2024 09:07:54 GMT, Pavel Rappo wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Replace InputStreamReader with BufferedReader > > src/jdk.jartool/share/classes/sun/tools/jar/resources/jar_pt_BR.propertie

Re: RFR: 8338139: {ClassLoading, Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods [v2]

2024-08-20 Thread Daniel D . Daugherty
On Tue, 20 Aug 2024 06:13:18 GMT, Stefan Karlsson wrote: >> So in this test case: >> `-Xlog:gc,gc+init` >> you have it so that `true` is returned. >> >> With this line of code: >> ``` >>const bool is_gc_exact_match = ts->contains(LogTag::_gc) && ts->ntags() >> == 1; >> >> I would thin

Re: [jdk23] RFR: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods

2024-08-20 Thread Daniel D . Daugherty
On Tue, 20 Aug 2024 12:47:59 GMT, Stefan Karlsson wrote: > Hi all, > > This pull request contains a backport of commit > [9775d571](https://github.com/openjdk/jdk/commit/9775d57168695dc0d758e017fe5069d93d593f3e) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit

Re: [jdk23] RFR: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods

2024-08-20 Thread Stefan Karlsson
On Tue, 20 Aug 2024 12:47:59 GMT, Stefan Karlsson wrote: > Hi all, > > This pull request contains a backport of commit > [9775d571](https://github.com/openjdk/jdk/commit/9775d57168695dc0d758e017fe5069d93d593f3e) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit

[jdk23] Integrated: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods

2024-08-20 Thread Stefan Karlsson
On Tue, 20 Aug 2024 12:47:59 GMT, Stefan Karlsson wrote: > Hi all, > > This pull request contains a backport of commit > [9775d571](https://github.com/openjdk/jdk/commit/9775d57168695dc0d758e017fe5069d93d593f3e) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit

Re: RFR: 8337408: Use GetTempPath2 API instead of GetTempPath [v2]

2024-08-20 Thread Alan Bateman
On Thu, 15 Aug 2024 20:28:28 GMT, Dhamoder Nalla wrote: >> Use the GetTempPath2 APIs instead of the GetTempPath APIs in native code >> across the OpenJDK repository to retrieve the temporary directory path, as >> GetTempPath2 provides enhanced security. While GetTempPath may still >> function

Re: RFR: 8205957: setfldw001/TestDescription.java fails with bad field value

2024-08-20 Thread Leonid Mesnik
On Wed, 14 Aug 2024 19:34:26 GMT, Leonid Mesnik wrote: > The summary of the problem. Test is intermittently failing because can't get > expected field watch event. > The test is failing to get event in the 'setfmodw001b' thread with Xcomp only. > I verified that frame with the method 'run' of se

Re: RFR: 8205957: setfldw001/TestDescription.java fails with bad field value

2024-08-20 Thread Dean Long
On Wed, 14 Aug 2024 19:34:26 GMT, Leonid Mesnik wrote: > The summary of the problem. Test is intermittently failing because can't get > expected field watch event. > The test is failing to get event in the 'setfmodw001b' thread with Xcomp only. > I verified that frame with the method 'run' of se

Re: RFR: 8205957: setfldw001/TestDescription.java fails with bad field value [v2]

2024-08-20 Thread Leonid Mesnik
> The summary of the problem. Test is intermittently failing because can't get > expected field watch event. > The test is failing to get event in the 'setfmodw001b' thread with Xcomp only. > I verified that frame with the method 'run' of setfmodw001b is compiled when > line > 118: setfmodw001.se

Re: RFR: 8205957: setfldw001/TestDescription.java fails with bad field value [v2]

2024-08-20 Thread Leonid Mesnik
On Tue, 20 Aug 2024 17:28:12 GMT, Dean Long wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed identation. > > src/hotspot/share/runtime/javaCalls.cpp line 403: > >> 401: } else { >> 402: //

Re: RFR: 8205957: setfldw001/TestDescription.java fails with bad field value [v2]

2024-08-20 Thread Dean Long
On Tue, 20 Aug 2024 17:38:01 GMT, Leonid Mesnik wrote: >> The summary of the problem. Test is intermittently failing because can't get >> expected field watch event. >> The test is failing to get event in the 'setfmodw001b' thread with Xcomp >> only. >> I verified that frame with the method 'ru

Re: RFR: 8205957: setfldw001/TestDescription.java fails with bad field value [v2]

2024-08-20 Thread Leonid Mesnik
On Tue, 20 Aug 2024 18:38:49 GMT, Serguei Spitsyn wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed identation. > > Marked as reviewed by sspitsyn (Reviewer). @sspitsyn, @dean-long Thank you for review -

Integrated: 8205957: setfldw001/TestDescription.java fails with bad field value

2024-08-20 Thread Leonid Mesnik
On Wed, 14 Aug 2024 19:34:26 GMT, Leonid Mesnik wrote: > The summary of the problem. Test is intermittently failing because can't get > expected field watch event. > The test is failing to get event in the 'setfmodw001b' thread with Xcomp only. > I verified that frame with the method 'run' of se

Re: RFR: 8205957: setfldw001/TestDescription.java fails with bad field value [v2]

2024-08-20 Thread Serguei Spitsyn
On Tue, 20 Aug 2024 17:38:01 GMT, Leonid Mesnik wrote: >> The summary of the problem. Test is intermittently failing because can't get >> expected field watch event. >> The test is failing to get event in the 'setfmodw001b' thread with Xcomp >> only. >> I verified that frame with the method 'ru

Re: RFR: 8337517: Redacted Heap Dumps [v2]

2024-08-20 Thread William Kemper
On Thu, 1 Aug 2024 21:46:04 GMT, Henry Lin wrote: >> Adds a command line option `-redact` to `jcmd` and `-XX:+HeapDumpRedacted` >> enabling redacted heap dumps. When enabled, the output binary heap dump has >> zeroes written out in place of the original primitive values in the object >> fields

Re: RFR: 8337408: Use GetTempPath2 API instead of GetTempPath [v2]

2024-08-20 Thread Dhamoder Nalla
On Tue, 20 Aug 2024 16:17:24 GMT, Alan Bateman wrote: >> Dhamoder Nalla has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix missing code > > src/java.base/windows/native/libjava/java_props_md.c line 327: > >> 325: typedef DWORD (WINAPI

Re: RFR: 8338257: UTF8 lengths should be size_t not int

2024-08-20 Thread David Holmes
On Thu, 15 Aug 2024 20:44:52 GMT, Coleen Phillimore wrote: >> This work has been split out from JDK-8328877: [JNI] The JNI Specification >> needs to address the limitations of integer UTF-8 String lengths >> >> The modified UTF-8 format used by the VM can require up to six bytes to >> represen

Re: RFR: 8338482: com/sun/jdi/ThreadMemoryLeakTest.java requires that compressed oops are enabled

2024-08-20 Thread Chris Plummer
On Fri, 16 Aug 2024 05:41:01 GMT, Chris Plummer wrote: > com/sun/jdi/ThreadMemoryLeakTest.java purposely runs with a small heap so it > is easier to detect a memory leak with an OOME. Running without compressed > oops uses more memory leading to an OOME even though there is no leak. We > shoul

Integrated: 8338482: com/sun/jdi/ThreadMemoryLeakTest.java requires that compressed oops are enabled

2024-08-20 Thread Chris Plummer
On Fri, 16 Aug 2024 05:41:01 GMT, Chris Plummer wrote: > com/sun/jdi/ThreadMemoryLeakTest.java purposely runs with a small heap so it > is easier to detect a memory leak with an OOME. Running without compressed > oops uses more memory leading to an OOME even though there is no leak. We > shoul