On Sat, 20 Jul 2024 06:33:09 GMT, Daniel Lundén wrote:
>> We are seeing quite a few timeouts for
>> `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing,
>> possibly related to
>> [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should
>> disable running `Clhsd
On Sat, 20 Jul 2024 06:33:09 GMT, Daniel Lundén wrote:
>> We are seeing quite a few timeouts for
>> `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing,
>> possibly related to
>> [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should
>> disable running `Clhsd
> Hi all,
>
> This is a small patch to address
> [8327054](https://bugs.openjdk.org/browse/JDK-8327054) making
> `CodeCache::write_perf_map` aware of which output stream errors and warning
> message should be going to.
>
> Testing:
> - [x] Added test case passes.
>
> Thanks,
> Sonia
Soni
On Mon, 22 Jul 2024 13:45:49 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This is a small patch to address
>> [8327054](https://bugs.openjdk.org/browse/JDK-8327054) making
>> `CodeCache::write_perf_map` aware of which output stream errors and warning
>> message should be going to.
>>
On Mon, 22 Jul 2024 13:45:49 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This is a small patch to address
>> [8327054](https://bugs.openjdk.org/browse/JDK-8327054) making
>> `CodeCache::write_perf_map` aware of which output stream errors and warning
>> message should be going to.
>>
On Mon, 22 Jul 2024 13:45:49 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This is a small patch to address
>> [8327054](https://bugs.openjdk.org/browse/JDK-8327054) making
>> `CodeCache::write_perf_map` aware of which output stream errors and warning
>> message should be going to.
>>
On Thu, 18 Jul 2024 15:00:41 GMT, Daniel Lundén wrote:
> We are seeing quite a few timeouts for
> `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing,
> possibly related to
> [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable
> running `ClhsdbDump
> Short version:
> Stop testing this test with -Xcomp by adding requires vm.compMode != "Xcomp"
>
> Make additional typo fixes and tidyups while here, it's just shocking.
>
> TestDescription.java contains the test definition, so the "requires" goes
> there, with a comment.
>
> Updates to from00
> Hi all,
>
> This is a small patch to address
> [8327054](https://bugs.openjdk.org/browse/JDK-8327054) making
> `CodeCache::write_perf_map` aware of which output stream errors and warning
> message should be going to.
>
> Testing:
> - [x] Added test case passes.
>
> Thanks,
> Sonia
Soni
On Mon, 22 Jul 2024 14:41:16 GMT, Kevin Walls wrote:
>> Sonia Zaldana Calles has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adding comment
>
> test/hotspot/jtreg/serviceability/dcmd/compiler/PerfMapTest.java line 124:
>
>> 122:
On Mon, 22 Jul 2024 15:33:27 GMT, Sonia Zaldana Calles
wrote:
>> test/hotspot/jtreg/serviceability/dcmd/compiler/PerfMapTest.java line 124:
>>
>>> 122: OutputAnalyzer output = new
>>> JMXExecutor().execute("Compiler.perfmap %s".formatted(path));
>>> 123: output.shouldCo
On Mon, 22 Jul 2024 15:13:08 GMT, Kevin Walls wrote:
>> Short version:
>> Stop testing this test with -Xcomp by adding requires vm.compMode != "Xcomp"
>>
>> Make additional typo fixes and tidyups while here, it's just shocking.
>>
>> TestDescription.java contains the test definition, so the "re
On Thu, 11 Jul 2024 21:08:20 GMT, Kevin Walls wrote:
> Short version:
> Stop testing this test with -Xcomp by adding requires vm.compMode != "Xcomp"
>
> Make additional typo fixes and tidyups while here, it's just shocking.
>
> TestDescription.java contains the test definition, so the "requires
On Mon, 22 Jul 2024 16:56:00 GMT, Severin Gehwolf wrote:
> Please review this fix for cgroups-based metrics reporting in the
> `jdk.internal.platform` package. This fix is supposed to address wrong
> reporting of certain limits if the limits aren't set at the leaf nodes.
>
> For example, on cg
Please review this fix for cgroups-based metrics reporting in the
`jdk.internal.platform` package. This fix is supposed to address wrong
reporting of certain limits if the limits aren't set at the leaf nodes.
For example, on cg v2, the memory limit interface file is `memory.max`.
Consider a cgr
On Fri, 19 Jul 2024 01:44:16 GMT, Chris Plummer wrote:
> Fix issue with `` argument.
Can I get a 2nd review please? Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/20246#issuecomment-2243506993
On Fri, 19 Jul 2024 01:44:16 GMT, Chris Plummer wrote:
> Fix issue with `` argument.
+1
-
Marked as reviewed by stuefe (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20246#pullrequestreview-2192244620
On Fri, 19 Jul 2024 18:41:10 GMT, Chris Plummer wrote:
> The test sometimes fails because the InterruptException doesn't arrive during
> the 100ms that the thread sleeps. My suspicion is that the interrupt is being
> delayed for some external reason, like temporary load on the host. I'm
> bump
On Fri, 19 Jul 2024 01:44:16 GMT, Chris Plummer wrote:
> Fix issue with `` argument.
Thanks David and Thomas!
-
PR Comment: https://git.openjdk.org/jdk/pull/20246#issuecomment-2243584280
On Fri, 19 Jul 2024 01:44:16 GMT, Chris Plummer wrote:
> Fix issue with `` argument.
This pull request has now been integrated.
Changeset: b144910e
Author:Chris Plummer
URL:
https://git.openjdk.org/jdk/commit/b144910ebb74be5a12dae57263f2a93452535f02
Stats: 1 line in 1 file chang
On Fri, 17 May 2024 19:32:31 GMT, Chris Plummer wrote:
>> This PR adds ranked monitor support to the debug agent. The debug agent has
>> a large number of monitors, and it's really hard to know which order to grab
>> them in, and for that matter which monitors might already be held at any
>> g
On Fri, 19 Jul 2024 18:41:10 GMT, Chris Plummer wrote:
> The test sometimes fails because the InterruptException doesn't arrive during
> the 100ms that the thread sleeps. My suspicion is that the interrupt is being
> delayed for some external reason, like temporary load on the host. I'm
> bump
On Fri, 19 Jul 2024 18:41:10 GMT, Chris Plummer wrote:
> The test sometimes fails because the InterruptException doesn't arrive during
> the 100ms that the thread sleeps. My suspicion is that the interrupt is being
> delayed for some external reason, like temporary load on the host. I'm
> bump
> Hi all,
>
> This PR addresses [8334492](https://bugs.openjdk.org/browse/JDK-8334492)
> enabling jcmd diagnostic commands that issue an output file to accept the
> `%p` pattern in the file name and substitute it for the PID.
>
> This PR addresses the following diagnostic commands:
> - [x] C
> Hi all,
>
> This PR addresses [8334492](https://bugs.openjdk.org/browse/JDK-8334492)
> enabling jcmd diagnostic commands that issue an output file to accept the
> `%p` pattern in the file name and substitute it for the PID.
>
> This PR addresses the following diagnostic commands:
> - [x] C
On Sun, 21 Jul 2024 10:08:38 GMT, Thomas Stuefe wrote:
>> Sonia, my bad if you already know this stuff but since it's fairly esoteric
>> knowledge nowadays I'd like to help you out in advance: Thomas is proposing
>> the usage of a X macro https://en.wikipedia.org/wiki/X_macro
>>
>> These can b
On Sat, 20 Jul 2024 08:02:34 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/services/diagnosticArgument.hpp line 66:
>>
>>> 64: public:
>>> 65: char *_name;
>>> 66: };
>>
>> Something is off about this. What is the lifetime of this object?
>>
>> You don't free it. Running a command in a
On Mon, 22 Jul 2024 16:31:32 GMT, Kevin Walls wrote:
> I think it was returning an "exit value" of -1, the
> test/lib/jdk/test/lib/process/OutputBuffer.java default.
Correct, that was the exit value.
> But yes just don't check exit code for a JMX Executor, and jcmd would return
> zero but we
Fix deadlock with debug agent callbackLock. Details in first comment.
Tested by running all jdi, jdwp, and jdb tests with and without virtual threads
about 40 times. The testing was initially done with my hack to force the self
suspend (see the first comment in the CR), and then I did final test
On Mon, 22 Jul 2024 20:32:35 GMT, Chris Plummer wrote:
> Fix deadlock with debug agent callbackLock. Details in first comment.
>
> Tested by running all jdi, jdwp, and jdb tests with and without virtual
> threads about 40 times. The testing was initially done with my hack to force
> the self s
On Mon, 22 Jul 2024 15:36:47 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This is a small patch to address
>> [8327054](https://bugs.openjdk.org/browse/JDK-8327054) making
>> `CodeCache::write_perf_map` aware of which output stream errors and warning
>> message should be going to.
>>
On Mon, 22 Jul 2024 15:36:47 GMT, Sonia Zaldana Calles
wrote:
>> Hi all,
>>
>> This is a small patch to address
>> [8327054](https://bugs.openjdk.org/browse/JDK-8327054) making
>> `CodeCache::write_perf_map` aware of which output stream errors and warning
>> message should be going to.
>>
32 matches
Mail list logo
