On Thu, 30 May 2024 14:13:34 GMT, Inigo Mediavilla Saiz
wrote:
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
In
https://github.com/openjdk/jdk/pull/19482/commits/ae690b255c9456f3db534be11fbc932648907ead
I've :
- Removed the duplicated "Carrying" se
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Remove duplicated Carrying statement and indent vthread stack
-
Changes:
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request with a new target base due
to a merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request c
On Fri, 31 May 2024 08:07:36 GMT, Serguei Spitsyn wrote:
>> The following RFE was fixed recently:
>> [8324680](https://bugs.openjdk.org/browse/JDK-8324680): Replace NULL with
>> nullptr in JVMTI generated code
>>
>> It replaced all the `NULL`'s in the generated spec with`nullptr`. JVMTI
>> age
On Fri, 31 May 2024 12:29:59 GMT, SendaoYan wrote:
> Hi all,
> This trivial fix, delete the extra empty line before `getOopMaps` function
> in `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/CodeBlob.java`
> file.
> No risk.
This pull request has now been integrated.
Changeset:
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Add missing header
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1
On Mon, 3 Jun 2024 08:30:15 GMT, Inigo Mediavilla Saiz wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add missing
On Fri, 31 May 2024 02:07:25 GMT, David Holmes wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> I'd probably give preference to the stack of the virtual thread, as the stack
> of the carrier when a vthread is mounted is generally quite uninte
On Mon, 3 Jun 2024 08:31:46 GMT, Thomas Stuefe wrote:
> I also find the duplication of the stack printing code unfortunate. It would
> be nice to reuse`JavaThread::print_vthread_stack_on`. I don't understand why
> it cannot be const?
Just what I was about to query :) I'm not sure what the cons
On Fri, 31 May 2024 12:29:59 GMT, SendaoYan wrote:
> Hi all,
> This trivial fix, delete the extra empty line before `getOopMaps` function
> in `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/CodeBlob.java`
> file.
> No risk.
Thanks all for the review and sponsor.
-
On Mon, 3 Jun 2024 08:30:15 GMT, Inigo Mediavilla Saiz wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add missing
On Mon, 3 Jun 2024 09:01:52 GMT, Andrey Turbanov wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add missing header
>
> test/hotspot/jtreg/serviceability/dcmd/thread/PrintVirtualThreadTest.java
> line 84:
On Fri, 3 May 2024 16:05:30 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that enforces
>> memory/cp
> The following RFE was fixed recently:
> [8324680](https://bugs.openjdk.org/browse/JDK-8324680): Replace NULL with
> nullptr in JVMTI generated code
>
> It replaced all the `NULL`'s in the generated spec with`nullptr`. JVMTI
> agents can be developed in C or C++.
> This update is to make it cle
On Mon, 3 Jun 2024 08:01:25 GMT, David Holmes wrote:
> The general rules are to either say "a null pointer" (possibly with capital A
> depending on context), or just "null". And in most cases you could choose
> either. I made various suggestions but really it is up to you. It is hard to
> get
On Thu, 30 May 2024 19:14:43 GMT, Magnus Ihse Bursie wrote:
> The original way of building static libraries in the JDK was to use the
> configure argument --enable-static-build, which set the value of the make
> variable STATIC_BUILD. (Note that this is not the same as the source code
> defini
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with two
additional commits since the last revision:
- Update
test/hotspot/jtreg/serviceability/dcmd/thread/PrintVirtualThreadTest.java
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Add indentation for virtual thread stack
-
Changes:
- all: https://git.
On Mon, 3 Jun 2024 11:22:12 GMT, Inigo Mediavilla Saiz wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Update
>
On Mon, 3 Jun 2024 08:34:11 GMT, David Holmes wrote:
>> I also find the duplication of the stack printing code unfortunate. It would
>> be nice to reuse`JavaThread::print_vthread_stack_on`. I don't understand why
>> it cannot be const?
>
>> I also find the duplication of the stack printing code
On Mon, 3 Jun 2024 11:26:27 GMT, Inigo Mediavilla Saiz wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add indentat
On Mon, 3 Jun 2024 11:26:27 GMT, Inigo Mediavilla Saiz wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add indentat
> Print the stack traces of mounted virtual threads when calling `jcmd
> Thread.print`.
Inigo Mediavilla Saiz has updated the pull request incrementally with one
additional commit since the last revision:
Print mounted virtual thread after carrier
-
Changes:
- all: https://gi
On Mon, 3 Jun 2024 13:13:55 GMT, Alan Bateman wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add indentation for virtual thread stack
>
> I don't think showing the frames of the mounted virtual thread bef
On Tue, 21 May 2024 17:10:15 GMT, Sebastian Lövdahl wrote:
>> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid
>> (Kubernetes debug container)
>
> Sebastian Lövdahl has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Remo
On Tue, 21 May 2024 17:10:15 GMT, Sebastian Lövdahl wrote:
>> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid
>> (Kubernetes debug container)
>
> Sebastian Lövdahl has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Remo
On Sat, 1 Jun 2024 00:22:45 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: refactored def and use of process_pending_interp_only()
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/Ca
On Sat, 1 Jun 2024 07:41:29 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which addresses
>> https://bugs.openjdk.org/browse/JDK-8333130?
>>
>> There are a couple of tests `NativeMethodPrefixApp` and `RetransformApp`
>> under `test/jdk/java/lang/instrument/` wh
On Tue, 21 May 2024 17:10:15 GMT, Sebastian Lövdahl wrote:
>> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid
>> (Kubernetes debug container)
>
> Sebastian Lövdahl has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Remo
On Tue, 21 May 2024 17:10:15 GMT, Sebastian Lövdahl wrote:
>> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid
>> (Kubernetes debug container)
>
> Sebastian Lövdahl has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Remo
On Mon, 3 Jun 2024 09:58:38 GMT, Serguei Spitsyn wrote:
>> The following RFE was fixed recently:
>> [8324680](https://bugs.openjdk.org/browse/JDK-8324680): Replace NULL with
>> nullptr in JVMTI generated code
>>
>> It replaced all the `NULL`'s in the generated spec with`nullptr`. JVMTI
>> agen
On Sat, 1 Jun 2024 21:11:26 GMT, Leonid Mesnik wrote:
>> The fix removes finalization cleanup from vmTestbase.
>> The last to classes that use it are: DebugeeBinder and SocketIOPipe.
>> The DebugeeBinder is used in jdi and jdwp tests and is always linked with
>> debuggee process. So the DebugeeP
> Please, review the following `interp-only` issue related to carrier threads.
> There are 3 problems fixed here:
> - The `EnterInterpOnlyModeClosure::do_threads` is taking the
> `JvmtiThreadState` with the `jt->jvmti_thread_state()` which is incorrect
> when we have a deal with a carrier threa
On Fri, 31 May 2024 23:55:20 GMT, Serguei Spitsyn wrote:
>> Please, review the following `interp-only` issue related to carrier threads.
>> There are 3 problems fixed here:
>> - The `EnterInterpOnlyModeClosure::do_threads` is taking the
>> `JvmtiThreadState` with the `jt->jvmti_thread_state()`
> The fix removes finalization cleanup from vmTestbase.
> The last to classes that use it are: DebugeeBinder and SocketIOPipe.
> The DebugeeBinder is used in jdi and jdwp tests and is always linked with
> debuggee process. So the DebugeeProcess.waitFor() is the good place to close
> binder and fr
On Fri, 31 May 2024 19:58:34 GMT, Chris Plummer wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> moved return out of try/catch
>
> test/hotspot/jtreg/vmTestbase/nsk/share/aod/DummyTargetApplication.java line
> 68:
On Mon, 3 Jun 2024 22:08:46 GMT, Chris Plummer wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed try/finally
>
> test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeProcess.java line 201:
>
>> 199: tr
On Tue, 21 May 2024 17:10:15 GMT, Sebastian Lövdahl wrote:
>> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid
>> (Kubernetes debug container)
>
> Sebastian Lövdahl has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Remo
On Mon, 3 Jun 2024 22:55:24 GMT, Serguei Spitsyn wrote:
>> Please, review the following `interp-only` issue related to carrier threads.
>> There are 3 problems fixed here:
>> - The `EnterInterpOnlyModeClosure::do_threads` is taking the
>> `JvmtiThreadState` with the `jt->jvmti_thread_state()`
On Mon, 3 Jun 2024 23:02:28 GMT, Leonid Mesnik wrote:
>> The fix removes finalization cleanup from vmTestbase.
>> The last to classes that use it are: DebugeeBinder and SocketIOPipe.
>> The DebugeeBinder is used in jdi and jdwp tests and is always linked with
>> debuggee process. So the DebugeeP
On Mon, 3 Jun 2024 20:24:49 GMT, Alex Menkov wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alex's input - simplify the test by using ClassFileInstaller
>
> test/jdk/java/lang/instrument/NativeMethodPrefixApp.java
> Can I please get a review of this test-only change which addresses
> https://bugs.openjdk.org/browse/JDK-8333130?
>
> There are a couple of tests `NativeMethodPrefixApp` and `RetransformApp`
> under `test/jdk/java/lang/instrument/` which launch the app/test with a
> `-javaagent:` pointing to
On Mon, 3 Jun 2024 22:03:13 GMT, Chris Plummer wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: consistency and stylistical corrections
>
> src/hotspot/share/prims/jvmti.xml line 1007:
>
>> 1005: exp
On Mon, 3 Jun 2024 13:31:16 GMT, Inigo Mediavilla Saiz wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd
>> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Print mounte
On Tue, 4 Jun 2024 05:27:48 GMT, David Holmes wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Print mounted virtual thread after carrier
>
> src/hotspot/share/runtime/javaThread.cpp line 1832:
>
>> 1830:
On Fri, 17 May 2024 03:49:21 GMT, Quan Anh Mai wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: corrected the nullptr clarification
>
> src/hotspot/share/prims/jvmti.xml line 1007:
>
>> 1005: explici
On Tue, 4 Jun 2024 04:48:04 GMT, David Holmes wrote:
>> src/hotspot/share/prims/jvmti.xml line 1007:
>>
>>> 1005: explicitly deallocate. This is indicated in the individual
>>>
>>> 1006: function descriptions. Empty lists, arrays, sequences, etc are
>>> 1007: returned as a null po
On Mon, 3 Jun 2024 22:55:24 GMT, Serguei Spitsyn wrote:
>> Please, review the following `interp-only` issue related to carrier threads.
>> There are 3 problems fixed here:
>> - The `EnterInterpOnlyModeClosure::do_threads` is taking the
>> `JvmtiThreadState` with the `jt->jvmti_thread_state()`
48 matches
Mail list logo
