On Sat, 28 Oct 2023 15:27:20 GMT, Quan Anh Mai wrote:
>> Sorry I was unclear: what is the advantage of a reference here? Is it just
>> to avoid copying
>
> @dholmes-ora Yes it helps avoid copying, especially if the copy constructor
> is non-trivial. And I think it is more idiomatic in C++ to us
On Tue, 24 Oct 2023 10:48:01 GMT, Afshin Zafari wrote:
>> The `find` method now is
>> ```C++
>> template
>> int find(T* token, bool f(T*, E)) const {
>> ...
>>
>> Any other functions which use this are also changed.
>> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and
On Tue, 29 Aug 2023 09:29:56 GMT, Johan Sjölen wrote:
> I still approve of this patch as it's better than what we had before. There
> are a lot of suggested improvements that can be done either in this PR or in
> a future RFE. `git blame` shows that this hasn't been touched since 2008, so
> I
On Sun, 29 Oct 2023 14:12:00 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java
> on linux-aarch64 in Xcomp mode.
>
> The test is already ProblemListed in -Xcomp mode for linux-x64.
Marked as reviewed by jpai (Reviewe
A trivial fix to ProblemList
serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java
on linux-aarch64 in Xcomp mode.
The test is already ProblemListed in -Xcomp mode for linux-x64.
-
Commit messages:
- 8319067: ProblemList
serviceability/AsyncGetCallTrace/MyPackage/ASGCTBase
On Sun, 29 Oct 2023 14:12:00 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java
> on linux-aarch64 in Xcomp mode.
>
> The test is already ProblemListed in -Xcomp mode for linux-x64.
This pull request has now been inte
