On Mon, 30 Jan 2023 09:30:36 GMT, Johan Sjölen wrote:
>> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
>> share/prims/. Unfortunately the script that does the change isn't perfect,
>> and so we
>> need to comb through these manually to make sure nothing has gone wr
> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
> share/prims/. Unfortunately the script that does the change isn't perfect,
> and so we
> need to comb through these manually to make sure nothing has gone wrong. I
> also review these changes but things slip past my
On Tue, 31 Jan 2023 10:11:34 GMT, Johan Sjölen wrote:
>> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
>> share/prims/. Unfortunately the script that does the change isn't perfect,
>> and so we
>> need to comb through these manually to make sure nothing has gone wr
On Wed, 25 Jan 2023 11:47:05 GMT, Johan Sjölen wrote:
> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory
> share/prims/. Unfortunately the script that does the change isn't perfect,
> and so we
> need to comb through these manually to make sure nothing has gone wrong.
On Mon, 30 Jan 2023 21:20:55 GMT, Chris Plummer wrote:
>> It's "not everything else".
>>
>> https://docs.oracle.com/en/java/javase/19/core/serialization-filtering1.html
>>
>> "If a class name doesn’t match any filter, then it is allowed. If you want
>> to allow only certain class names, then y
> The default setting for the ObjectInputFilter for JMX, introduced in jdk20,
> is too restrictive.
> javax.management.Attribute and AttributeList classes are also needed, and
> Query related classes.
>
> There are a number of Query-related classes, so adding javax.management.* is
> appropriate
On Mon, 30 Jan 2023 20:24:16 GMT, Serguei Spitsyn wrote:
>> Kevin Walls has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - filter properties update: more classes logged as ALLOWED during wider
>> testing
>> - Add a Notification test
>
>
On Tue, 31 Jan 2023 14:30:29 GMT, Justin King wrote:
> Redo [JDK-8301378](https://bugs.openjdk.org/browse/JDK-8301378), this time
> also fixing the serviceability code.
Waiting on GHA to confirm if I fixed the serviceability code correctly.
-
PR: https://git.openjdk.org/jdk/pull/1
Redo [JDK-8301378](https://bugs.openjdk.org/browse/JDK-8301378), this time also
fixing the serviceability code.
-
Commit messages:
- Redo removal of virtual methods in CodeHeap
Changes: https://git.openjdk.org/jdk/pull/12345/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=1
Deprecate the Java Management Extension (JMX) Subject Delegation feature for
removal in a future release.
Given no known usage, there is no replacement feature for JMX Subject
Delegation.
CSR is https://bugs.openjdk.org/browse/JDK-8298967
-
Commit messages:
- 8298966: Deprecate J
On Tue, 31 Jan 2023 14:30:29 GMT, Justin King wrote:
> Redo [JDK-8301378](https://bugs.openjdk.org/browse/JDK-8301378), this time
> also fixing the serviceability code.
Looks good this time.
-
PR: https://git.openjdk.org/jdk/pull/12345
On Tue, 31 Jan 2023 14:29:38 GMT, Kevin Walls wrote:
>> The default setting for the ObjectInputFilter for JMX, introduced in jdk20,
>> is too restrictive.
>> javax.management.Attribute and AttributeList classes are also needed, and
>> Query related classes.
>>
>> There are a number of Query-re
On Tue, 31 Jan 2023 14:30:29 GMT, Justin King wrote:
> Redo [JDK-8301378](https://bugs.openjdk.org/browse/JDK-8301378), this time
> also fixing the serviceability code.
Good. But someone in Oracle have to test it before you push.
-
Marked as reviewed by kvn (Reviewer).
PR: https:
On Tue, 31 Jan 2023 14:30:29 GMT, Justin King wrote:
> Redo [JDK-8301378](https://bugs.openjdk.org/browse/JDK-8301378), this time
> also fixing the serviceability code.
Cannot directly commit, so I will request integration and let prospective
sponsors do any additional testing before sponsorin
On Tue, 31 Jan 2023 04:48:45 GMT, David Holmes wrote:
>> classFileParser drops stack map frames for JDK classes (when verification is
>> not required).
>> As a result JvmtiClassFileReconstituter cannot restore the attribute for
>> class redefinition.
>> Note that if the class is in CDS archive,
On Fri, 27 Jan 2023 05:20:28 GMT, Leonid Mesnik wrote:
>> PR adds fix "8284027: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/ is
>> failing" to new test and remove duplication.
>>
>> Test allthr002 ported as
>> serviceability/jvmti/negative/GetAllThreadsNullTest/GetAllThreadsNullTest.java
>
> L
On Tue, 31 Jan 2023 14:29:38 GMT, Kevin Walls wrote:
>> The default setting for the ObjectInputFilter for JMX, introduced in jdk20,
>> is too restrictive.
>> javax.management.Attribute and AttributeList classes are also needed, and
>> Query related classes.
>>
>> There are a number of Query-re
On Mon, 23 Jan 2023 21:02:51 GMT, Chris Plummer wrote:
> jdb creates a ThreadStartRequest and ThreadDeathRequest so it can track all
> created threads. It creates them with the SUSPEND_ALL policy. This is
> unnecessary since jdb always immediately resumes all threads after doing the
> thread b
On Tue, 31 Jan 2023 07:38:57 GMT, Alan Bateman wrote:
> I guess I would assume that an agent/tool modifying a class would require it
> to be regenerated.
This is my understanding too. My understanding is that eliding the
StackMapTable attribute when there is no split-verifier is an optimizatio
On Wed, 1 Feb 2023 04:10:15 GMT, Serguei Spitsyn wrote:
> My understanding is that eliding the StackMapTable attribute when there is no
> split-verifier is an optimization which can cause problems for agents/tools.
Sure we can keep the attribute, but I have to question why these agents/tools
On Tue, 24 Jan 2023 03:17:01 GMT, Chris Plummer wrote:
>> classFileParser drops stack map frames for JDK classes (when verification is
>> not required).
>> As a result JvmtiClassFileReconstituter cannot restore the attribute for
>> class redefinition.
>> Note that if the class is in CDS archive
On Tue, 24 Jan 2023 00:16:10 GMT, Alex Menkov wrote:
> classFileParser drops stack map frames for JDK classes (when verification is
> not required).
> As a result JvmtiClassFileReconstituter cannot restore the attribute for
> class redefinition.
> Note that if the class is in CDS archive, the f
On Tue, 31 Jan 2023 14:30:29 GMT, Justin King wrote:
> Redo [JDK-8301378](https://bugs.openjdk.org/browse/JDK-8301378), this time
> also fixing the serviceability code.
I ran tier1-3 and -Xcomp testing and it passed. Except
serviceability/sa/ClhsdbDumpheap.java timed out with -Xcomp but we saw
On Wed, 1 Feb 2023 04:32:34 GMT, David Holmes wrote:
> > My understanding is that eliding the StackMapTable attribute when there is
> > no split-verifier is an optimization which can cause problems for
> > agents/tools.
>
> Sure we can keep the attribute, but I have to question why these agent
24 matches
Mail list logo
