Re: RFR: JDK-8301077: Replace NULL with nullptr in share/services/ [v2]

2023-01-27 Thread Coleen Phillimore
On Thu, 26 Jan 2023 15:02:54 GMT, Johan Sjölen wrote: >> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory >> share/services/. Unfortunately the script that does the change isn't >> perfect, and so we >> need to comb through these manually to make sure nothing has gone

Re: RFR: JDK-8301077: Replace NULL with nullptr in share/services/ [v2]

2023-01-27 Thread Johan Sjölen
On Thu, 26 Jan 2023 15:02:54 GMT, Johan Sjölen wrote: >> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory >> share/services/. Unfortunately the script that does the change isn't >> perfect, and so we >> need to comb through these manually to make sure nothing has gone

Integrated: JDK-8301077: Replace NULL with nullptr in share/services/

2023-01-27 Thread Johan Sjölen
On Wed, 25 Jan 2023 11:47:18 GMT, Johan Sjölen wrote: > Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory > share/services/. Unfortunately the script that does the change isn't perfect, > and so we > need to comb through these manually to make sure nothing has gone wro

Re: RFR: 8301132: Test update for deprecated sprintf in Xcode 14 [v2]

2023-01-27 Thread Mikael Vidstedt
On Fri, 27 Jan 2023 05:27:41 GMT, Xue-Lei Andrew Fan wrote: >> The sprintf is deprecated in Xcode 14 because of security concerns. The >> issue was addressed in >> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812)/[JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378)/[JDK-8299635]

Withdrawn: 8296546: Add @spec tags to API

2023-01-27 Thread duke
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote: > Please review a "somewhat automated" change to insert `@spec` tags into doc > comments, as appropriate, to leverage the recent new javadoc feature to > generate a new page listing the references to all external specifications > listed

Integrated: 8301132: Test update for deprecated sprintf in Xcode 14

2023-01-27 Thread Xue-Lei Andrew Fan
On Thu, 26 Jan 2023 06:38:00 GMT, Xue-Lei Andrew Fan wrote: > The sprintf is deprecated in Xcode 14 because of security concerns. The issue > was addressed in > [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812)/[JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378)/[JDK-8299635](ht

Re: RFR: 8300810: Get rid of unused JDI removeListener() methods

2023-01-27 Thread Alex Menkov
On Mon, 23 Jan 2023 20:58:20 GMT, Chris Plummer wrote: > Remove removeListener() methods. They are not called. Marked as reviewed by amenkov (Reviewer). - PR: https://git.openjdk.org/jdk/pull/12151

Re: RFR: JDK-8301076: Replace NULL with nullptr in share/prims/

2023-01-27 Thread Alex Menkov
On Wed, 25 Jan 2023 11:47:05 GMT, Johan Sjölen wrote: > Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory > share/prims/. Unfortunately the script that does the change isn't perfect, > and so we > need to comb through these manually to make sure nothing has gone wrong.

RFR: 8301279: update for deprecated sprintf for management components

2023-01-27 Thread Xue-Lei Andrew Fan
The sprintf is deprecated in Xcode 14 because of security concerns. The issue was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building failure, and [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378)/[JDK-8299635](https://bugs.openjdk.org/browse/JDK-8299635

RFR: Merge jdk20

2023-01-27 Thread Jesper Wilhelmsson
Forwardport JDK 20 -> JDK 21 - Commit messages: - Merge remote-tracking branch 'jdk20/master' into Merge_jdk20 - 8301206: Fix issue with LocaleData after JDK-8300719 - 8300953: ClassDesc::ofInternalName missing @since tag - 8300719: JDK 20 RDP2 L10n resource files update The webr

Integrated: Merge jdk20

2023-01-27 Thread Jesper Wilhelmsson
On Fri, 27 Jan 2023 21:00:03 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 20 -> JDK 21 This pull request has now been integrated. Changeset: 5c59de52 Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/5c59de52a31da937663ad2cef055213489b0516e Stats: 1078 lines

Re: RFR: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes

2023-01-27 Thread Alex Menkov
On Tue, 24 Jan 2023 00:16:10 GMT, Alex Menkov wrote: > classFileParser drops stack map frames for JDK classes (when verification is > not required). > As a result JvmtiClassFileReconstituter cannot restore the attribute for > class redefinition. > Note that if the class is in CDS archive, the f

RFR: 8298907: nsk JDI tests pass if the debuggee failed to launch

2023-01-27 Thread Leonid Mesnik
Updated run() to return exitCode and make testExitCode non-static to don't use it in run() - Commit messages: - fixed cp - 8298907: nsk JDI tests pass if the debuggee failed to launch Changes: https://git.openjdk.org/jdk/pull/12270/files Webrev: https://webrevs.openjdk.org/?repo=

Re: RFR: 8291555: Implement alternative fast-locking scheme [v5]

2023-01-27 Thread Daniel D . Daugherty
On Thu, 26 Jan 2023 12:34:18 GMT, Roman Kennke wrote: >> This change adds a fast-locking scheme as an alternative to the current >> stack-locking implementation. It retains the advantages of stack-locking >> (namely fast locking in uncontended code-paths), while avoiding the overload >> of the

Re: RFR: 8291555: Implement alternative fast-locking scheme [v4]

2023-01-27 Thread Daniel D . Daugherty
On Wed, 18 Jan 2023 20:10:21 GMT, Roman Kennke wrote: >> This change adds a fast-locking scheme as an alternative to the current >> stack-locking implementation. It retains the advantages of stack-locking >> (namely fast locking in uncontended code-paths), while avoiding the overload >> of the

Re: RFR: 8298907: nsk JDI tests pass if the debuggee failed to launch

2023-01-27 Thread Chris Plummer
On Fri, 27 Jan 2023 23:24:43 GMT, Leonid Mesnik wrote: > Updated run() to return exitCode and make testExitCode non-static to don't > use it in run() Thanks for cleaning this up. The changes look good. Did you experiment with any of the tests to make sure an invalid arg passed to the debuggee

Withdrawn: 8298046: Fix hidden but significant trailing whitespace in properties files for serviceability code

2023-01-27 Thread duke
On Fri, 2 Dec 2022 16:42:57 GMT, Magnus Ihse Bursie wrote: > According to [the > specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader)) > trailing whitespaces in the values of properties files are (somewhat > surprisingly) ac

Re: RFR: 8298907: nsk JDI tests pass if the debuggee failed to launch [v2]

2023-01-27 Thread Leonid Mesnik
> Updated run() to return exitCode and make testExitCode non-static to don't > use it in run() Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: cp updated - Changes: - all: https://git.openjdk.org/jdk/pull/12270/files

Re: RFR: 8298907: nsk JDI tests pass if the debuggee failed to launch [v2]

2023-01-27 Thread Leonid Mesnik
On Fri, 27 Jan 2023 23:39:11 GMT, Chris Plummer wrote: > Thanks for cleaning this up. The changes look good. Did you experiment with > any of the tests to make sure an invalid arg passed to the debuggee results > in a failure? You can add the arg to the start of `-debugee.vmkeys` in > TestDesc

Re: RFR: 8298907: nsk JDI tests pass if the debuggee failed to launch [v2]

2023-01-27 Thread Chris Plummer
On Sat, 28 Jan 2023 00:47:47 GMT, Leonid Mesnik wrote: >> Updated run() to return exitCode and make testExitCode non-static to don't >> use it in run() > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > cp updated Marked as