Re: RFR: 8296709: WARNING: JNI call made without checking exceptions

2022-11-11 Thread Lutz Schmidt
On Fri, 11 Nov 2022 06:26:19 GMT, Christoph Langer wrote: >> This small change fixes a warning that may pop up during runtime. May I >> please request reviews? Thank you! > > Maybe you could also call "bin/java -Xcheck:jni > -agentlib:jdwp=transport=dt_socket,server=y,suspend=n -version" which

Re: RFR: 8295861: get rid of list argument in debug agent's removeNode() API

2022-11-11 Thread Kevin Walls
On Fri, 11 Nov 2022 03:17:58 GMT, Chris Plummer wrote: > Get rid of `list` argument in debug agent's `removeNode()` API. The list is > stored in the node, so no need to pass it in. Marked as reviewed by kevinw (Committer). - PR: https://git.openjdk.org/jdk/pull/11101

Re: RFR: 8296546: Add @spec tags to API

2022-11-11 Thread Daniel Fuchs
On Thu, 10 Nov 2022 21:56:26 GMT, Jonathan Gibbons wrote: > On the same text but linking to different RFCs: that's tantamount to a bug > somewhere. The spec for `@spec` dictates that the URLs and titles should be > in 1-1 correspondence, and this is supposed to be enforced in the docket. In >

Re: RFR: 8295315: [REDO] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files

2022-11-11 Thread Kevin Walls
On Thu, 10 Nov 2022 22:42:10 GMT, Ioi Lam wrote: > Here's redo for https://github.com/openjdk/jdk/pull/10687. This PR has two > commits: > - 739b79afb1965b625b2002187ac3fd43f385a639 is the same as in the original PR > - 78455c024ec5c00f1a0ce6c0e13df477c3063fe1 fixes the bug in the original PR. >

Re: RFR: 8296546: Add @spec tags to API

2022-11-11 Thread Daniel Fuchs
On Fri, 11 Nov 2022 11:45:43 GMT, Lance Andersen wrote: > It would probably be easier for the reviewers and for you if the PR could be > broken out by areas into separate PRs Leaving out the non-public and non-exported classes would also reduce the PR size. - PR: https://git.open

Re: RFR: 8296546: Add @spec tags to API

2022-11-11 Thread Lance Andersen
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote: > Please review a "somewhat automated" change to insert `@spec` tags into doc > comments, as appropriate, to leverage the recent new javadoc feature to > generate a new page listing the references to all external specifications > listed

RFR: 8296886: Fix various include sort order issues

2022-11-11 Thread Stefan Karlsson
The sorted blocks of includes have deteriorated to the point that I felt compelled to clean up some of the issues. One of the more prevalent issues is that files in src/hotspot/share/include are not properly sorted. There has been some discussion that that was done on purpose, but it just adds

Re: RFR: 8291555: Replace stack-locking with fast-locking

2022-11-11 Thread Roman Kennke
On Fri, 28 Oct 2022 01:47:23 GMT, David Holmes wrote: >> \-\-\-\-\- Original Message \-\-\-\-\- >>> From\: \"John R Rose\" \ >>> To\: hotspot\-dev at openjdk\.org\, serviceability\-dev at openjdk\.org\, >>> shenandoah\-dev at openjdk\.org >>> Sent\: Thursday\, October 27\, 2022 10\:41\:44 PM >>>

Re: RFR: 8296886: Fix various include sort order issues

2022-11-11 Thread Erik Österlund
On Fri, 11 Nov 2022 14:26:20 GMT, Stefan Karlsson wrote: > The sorted blocks of includes have deteriorated to the point that I felt > compelled to clean up some of the issues. > > One of the more prevalent issues is that files in src/hotspot/share/include > are not properly sorted. There has b

Re: RFR: 8296709: WARNING: JNI call made without checking exceptions [v2]

2022-11-11 Thread Lutz Schmidt
> This small change fixes a warning that may pop up during runtime. May I > please request reviews? Thank you! Lutz Schmidt has updated the pull request incrementally with one additional commit since the last revision: 8296709: add testcase with active jdwp agent - Changes: -

Re: RFR: 8296709: WARNING: JNI call made without checking exceptions [v2]

2022-11-11 Thread Lutz Schmidt
On Fri, 11 Nov 2022 15:33:20 GMT, Lutz Schmidt wrote: >> This small change fixes a warning that may pop up during runtime. May I >> please request reviews? Thank you! > > Lutz Schmidt has updated the pull request incrementally with one additional > commit since the last revision: > > 8296709

RFR: 8296875: Generational ZGC: Refactor loom code

2022-11-11 Thread Erik Österlund
The current loom code makes some assumptions about GC that will not work with generational ZGC. We should make this code more GC agnostic, and provide a better interface for talking to the GC. In particular, 1) All GCs have a way of encoding oops inside of the heap differently to oops outside o

Re: RFR: 8296709: WARNING: JNI call made without checking exceptions [v3]

2022-11-11 Thread Lutz Schmidt
> This small change fixes a warning that may pop up during runtime. May I > please request reviews? Thank you! Lutz Schmidt has updated the pull request incrementally with one additional commit since the last revision: 8296709: fix testcase naming - Changes: - all: https://git

Re: RFR: 8296875: Generational ZGC: Refactor loom code

2022-11-11 Thread Erik Österlund
On Fri, 11 Nov 2022 16:16:18 GMT, Erik Österlund wrote: > The current loom code makes some assumptions about GC that will not work with > generational ZGC. We should make this code more GC agnostic, and provide a > better interface for talking to the GC. > > In particular, > 1) All GCs have a

Re: RFR: 8296709: WARNING: JNI call made without checking exceptions [v3]

2022-11-11 Thread Christoph Langer
On Fri, 11 Nov 2022 16:26:59 GMT, Lutz Schmidt wrote: >> This small change fixes a warning that may pop up during runtime. May I >> please request reviews? Thank you! > > Lutz Schmidt has updated the pull request incrementally with one additional > commit since the last revision: > > 8296709

Re: RFR: 8296886: Fix various include sort order issues

2022-11-11 Thread Kim Barrett
On Fri, 11 Nov 2022 14:26:20 GMT, Stefan Karlsson wrote: > The sorted blocks of includes have deteriorated to the point that I felt > compelled to clean up some of the issues. > > One of the more prevalent issues is that files in src/hotspot/share/include > are not properly sorted. There has b

Re: RFR: 8296875: Generational ZGC: Refactor loom code

2022-11-11 Thread Fei Yang
On Fri, 11 Nov 2022 19:41:56 GMT, Erik Österlund wrote: > Nice to have PR 1. It's gonna take a long time until we see 11. Nice PR number :-) May I ask if you could also add handling for riscv while you are at it? We have ported loom to this platform recently [1]. [1] https://git.openjd