Re: RFR: JDK-8311076: RedefineClasses doesn't check for ConstantPool overflow [v2]

2024-02-09 Thread Coleen Phillimore
On Fri, 9 Feb 2024 20:42:14 GMT, Alex Menkov wrote: >> The fix adds check that merged constant pool does not overflow u2 (two-byte >> unsigned). >> The check is added after merging `the_class` and `scratch_class` constant >> pools, but before rewriting constant pool references. >> >> testing:

Re: RFR: JDK-8311076: RedefineClasses doesn't check for ConstantPool overflow [v2]

2024-02-09 Thread Alex Menkov
On Fri, 9 Feb 2024 03:27:54 GMT, Coleen Phillimore wrote: >> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 1828: >> >>> 1826: // ensure merged constant pool size does not overflow u2 >>> 1827: if (merge_cp_length > 0x) { >>> 1828: return JVMTI_ERROR_INTERNAL; >> >> Doesn't i

Re: RFR: JDK-8311076: RedefineClasses doesn't check for ConstantPool overflow [v2]

2024-02-09 Thread Leonid Mesnik
On Fri, 9 Feb 2024 20:42:14 GMT, Alex Menkov wrote: >> The fix adds check that merged constant pool does not overflow u2 (two-byte >> unsigned). >> The check is added after merging `the_class` and `scratch_class` constant >> pools, but before rewriting constant pool references. >> >> testing:

Re: RFR: JDK-8311076: RedefineClasses doesn't check for ConstantPool overflow [v2]

2024-02-09 Thread Alex Menkov
> The fix adds check that merged constant pool does not overflow u2 (two-byte > unsigned). > The check is added after merging `the_class` and `scratch_class` constant > pools, but before rewriting constant pool references. > > testing: > - sanity tier1; > - all RedefineClasses/RetransformClass