Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v7]

2025-06-23 Thread Johan Sjölen
On Thu, 19 Jun 2025 08:03:20 GMT, Johan Sjölen wrote: >> Hi, >> >> The constant pool currently has a lot of methods specific to extracting >> parts of the operands array. What this array actually is, is a sequence of >> bootstrap method attribute entries, where each entry has the following >

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v7]

2025-06-19 Thread Serguei Spitsyn
On Thu, 19 Jun 2025 08:03:20 GMT, Johan Sjölen wrote: >> Hi, >> >> The constant pool currently has a lot of methods specific to extracting >> parts of the operands array. What this array actually is, is a sequence of >> bootstrap method attribute entries, where each entry has the following >

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v6]

2025-06-19 Thread Johan Sjölen
On Thu, 19 Jun 2025 07:33:46 GMT, Serguei Spitsyn wrote: >> Johan Sjölen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Double check your changes next time! > > src/hotspot/share/prims/jvmtiClassFileReconstituter.cpp line 414: > >> 412

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v7]

2025-06-19 Thread Johan Sjölen
> Hi, > > The constant pool currently has a lot of methods specific to extracting > parts of the operands array. What this array actually is, is a sequence of > bootstrap method attribute entries, where each entry has the following > components: > > ```c++ > struct BSMAE { > u2 bootstrap_me

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v5]

2025-06-19 Thread Serguei Spitsyn
On Thu, 19 Jun 2025 07:06:54 GMT, Johan Sjölen wrote: >> src/hotspot/share/oops/constantPool.cpp line 1944: >> >>> 1942: BSMAttributeEntry* e2 = bsm_attribute_entry(idx2); >>> 1943: int k1 = e1->bootstrap_method_index(); >>> 1944: int k2 = cp2->e2->bootstrap_method_index(); >> >> I'm kind

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v6]

2025-06-19 Thread Serguei Spitsyn
On Thu, 19 Jun 2025 07:35:33 GMT, Johan Sjölen wrote: >> Hi, >> >> The constant pool currently has a lot of methods specific to extracting >> parts of the operands array. What this array actually is, is a sequence of >> bootstrap method attribute entries, where each entry has the following >

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v6]

2025-06-19 Thread Johan Sjölen
> Hi, > > The constant pool currently has a lot of methods specific to extracting > parts of the operands array. What this array actually is, is a sequence of > bootstrap method attribute entries, where each entry has the following > components: > > ```c++ > struct BSMAE { > u2 bootstrap_me

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v5]

2025-06-19 Thread Johan Sjölen
On Wed, 18 Jun 2025 17:51:14 GMT, Serguei Spitsyn wrote: >> Johan Sjölen has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Matias's comments >> - Apply Sergei's comments > > src/hotspot/share/oops/constantPool.cpp line 1944: > >> 1942:

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v5]

2025-06-18 Thread Serguei Spitsyn
On Wed, 18 Jun 2025 12:37:07 GMT, Johan Sjölen wrote: >> Hi, >> >> The constant pool currently has a lot of methods specific to extracting >> parts of the operands array. What this array actually is, is a sequence of >> bootstrap method attribute entries, where each entry has the following >

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v4]

2025-06-18 Thread Johan Sjölen
On Mon, 9 Jun 2025 13:58:09 GMT, Johan Sjölen wrote: >> Hi, >> >> The constant pool currently has a lot of methods specific to extracting >> parts of the operands array. What this array actually is, is a sequence of >> bootstrap method attribute entries, where each entry has the following >>

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v5]

2025-06-18 Thread Johan Sjölen
> Hi, > > The constant pool currently has a lot of methods specific to extracting > parts of the operands array. What this array actually is, is a sequence of > bootstrap method attribute entries, where each entry has the following > components: > > ```c++ > struct BSMAE { > u2 bootstrap_me

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v4]

2025-06-18 Thread Johan Sjölen
On Wed, 18 Jun 2025 02:28:32 GMT, Serguei Spitsyn wrote: >> Johan Sjölen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Move it to public > > src/hotspot/share/oops/constantPool.cpp line 1953: > >> 1951: k1 = bsm_attribute_entry(

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v4]

2025-06-17 Thread Serguei Spitsyn
On Mon, 9 Jun 2025 13:58:09 GMT, Johan Sjölen wrote: >> Hi, >> >> The constant pool currently has a lot of methods specific to extracting >> parts of the operands array. What this array actually is, is a sequence of >> bootstrap method attribute entries, where each entry has the following >>

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v4]

2025-06-17 Thread Serguei Spitsyn
On Mon, 9 Jun 2025 13:58:09 GMT, Johan Sjölen wrote: >> Hi, >> >> The constant pool currently has a lot of methods specific to extracting >> parts of the operands array. What this array actually is, is a sequence of >> bootstrap method attribute entries, where each entry has the following >>

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v4]

2025-06-17 Thread Matias Saavedra Silva
On Mon, 9 Jun 2025 13:58:09 GMT, Johan Sjölen wrote: >> Hi, >> >> The constant pool currently has a lot of methods specific to extracting >> parts of the operands array. What this array actually is, is a sequence of >> bootstrap method attribute entries, where each entry has the following >>

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v4]

2025-06-17 Thread Coleen Phillimore
On Mon, 9 Jun 2025 13:58:09 GMT, Johan Sjölen wrote: >> Hi, >> >> The constant pool currently has a lot of methods specific to extracting >> parts of the operands array. What this array actually is, is a sequence of >> bootstrap method attribute entries, where each entry has the following >>

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v4]

2025-06-09 Thread Johan Sjölen
> Hi, > > The constant pool currently has a lot of methods specific to extracting > parts of the operands array. What this array actually is, is a sequence of > bootstrap method attribute entries, where each entry has the following > components: > > ```c++ > struct BSMAE { > u2 bootstrap_me

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v3]

2025-06-09 Thread Johan Sjölen
> Hi, > > The constant pool currently has a lot of methods specific to extracting > parts of the operands array. What this array actually is, is a sequence of > bootstrap method attribute entries, where each entry has the following > components: > > ```c++ > struct BSMAE { > u2 bootstrap_me

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v2]

2025-06-09 Thread Johan Sjölen
On Thu, 22 May 2025 17:55:07 GMT, Johan Sjölen wrote: >> Hi, >> >> The constant pool currently has a lot of methods specific to extracting >> parts of the operands array. What this array actually is, is a sequence of >> bootstrap method attribute entries, where each entry has the following >

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v2]

2025-05-29 Thread Coleen Phillimore
On Thu, 22 May 2025 17:55:07 GMT, Johan Sjölen wrote: >> Hi, >> >> The constant pool currently has a lot of methods specific to extracting >> parts of the operands array. What this array actually is, is a sequence of >> bootstrap method attribute entries, where each entry has the following >

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v2]

2025-05-29 Thread Coleen Phillimore
On Tue, 20 May 2025 20:24:25 GMT, Chris Plummer wrote: >> The references are still correct, as we haven't changed the struct layout. >> We're also not planning on doing so. I don't think that there is a bug here. > > Ok. It's just unusual to see constants like these that are needed by SA but >

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v2]

2025-05-22 Thread Johan Sjölen
> Hi, > > The constant pool currently has a lot of methods specific to extracting > parts of the operands array. What this array actually is, is a sequence of > bootstrap method attribute entries, where each entry has the following > components: > > ```c++ > struct BSMAE { > u2 bootstrap_me

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v2]

2025-05-22 Thread Johan Sjölen
On Wed, 21 May 2025 17:28:12 GMT, Lois Foltan wrote: >> Johan Sjölen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Lois's comments > > src/hotspot/share/oops/constantPool.hpp line 80: > >> 78: }; >> 79: >> 80: class BSMAttributeEntry

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct [v2]

2025-05-22 Thread Johan Sjölen
On Thu, 22 May 2025 17:52:41 GMT, Johan Sjölen wrote: >> Hi, >> >> The constant pool currently has a lot of methods specific to extracting >> parts of the operands array. What this array actually is, is a sequence of >> bootstrap method attribute entries, where each entry has the following >

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct

2025-05-21 Thread Lois Foltan
On Mon, 19 May 2025 07:35:16 GMT, Johan Sjölen wrote: > Hi, > > The constant pool currently has a lot of methods specific to extracting > parts of the operands array. What this array actually is, is a sequence of > bootstrap method attribute entries, where each entry has the following > comp

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct

2025-05-20 Thread Chris Plummer
On Tue, 20 May 2025 06:34:20 GMT, Johan Sjölen wrote: >> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ConstantPool.java >> line 126: >> >>> 124: private static int INDY_BSM_OFFSET = 0; >>> 125: private static int INDY_ARGC_OFFSET = 1; >>> 126: private static int INDY_ARGV_OFFS

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct

2025-05-19 Thread Johan Sjölen
On Mon, 19 May 2025 17:49:59 GMT, Chris Plummer wrote: >> Hi, >> >> The constant pool currently has a lot of methods specific to extracting >> parts of the operands array. What this array actually is, is a sequence of >> bootstrap method attribute entries, where each entry has the following

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct

2025-05-19 Thread Johan Sjölen
On Mon, 19 May 2025 07:35:16 GMT, Johan Sjölen wrote: > Hi, > > The constant pool currently has a lot of methods specific to extracting > parts of the operands array. What this array actually is, is a sequence of > bootstrap method attribute entries, where each entry has the following > comp

Re: RFR: 8357220: Introduce a BSMAttributeEntry struct

2025-05-19 Thread Chris Plummer
On Mon, 19 May 2025 07:35:16 GMT, Johan Sjölen wrote: > Hi, > > The constant pool currently has a lot of methods specific to extracting > parts of the operands array. What this array actually is, is a sequence of > bootstrap method attribute entries, where each entry has the following > comp

RFR: 8357220: Introduce a BSMAttributeEntry struct

2025-05-19 Thread Johan Sjölen
Hi, The constant pool currently has a lot of methods specific to extracting parts of the operands array. What this array actually is, is a sequence of bootstrap method attribute entries, where each entry has the following components: ```c++ struct BSMAE { u2 bootstrap_method_index; u2 argu