Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread [v2]

2025-01-27 Thread Chris Plummer
On Fri, 24 Jan 2025 20:22:07 GMT, Chris Plummer wrote: >> If you run hotspot with -XX:+DeoptimizeObjectsALot, it will create one or >> more DeoptimizeObjectsALotThread threads. This is one of many JavaThread >> subclasses that SA needs to know about, but in this case it does not. When >> SA tr

Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread [v2]

2025-01-24 Thread Dean Long
On Fri, 24 Jan 2025 23:23:43 GMT, Chris Plummer wrote: > I don't see how that relates to this change. It sounds more like a general > suggestion to overhaul of how vmStructs is implemented. It relates because if something like that was available then we could register types that are local to a

Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread [v2]

2025-01-24 Thread Chris Plummer
On Fri, 24 Jan 2025 22:52:19 GMT, Dean Long wrote: > > > Overall the changes seem fine, however it would be nice if the > > > vmStructs.cpp registration mechanism was modular and extensible, instead > > > of monolithic. That would make it easier to register private types, or > > > even types o

Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread [v2]

2025-01-24 Thread Kevin Walls
On Fri, 24 Jan 2025 20:22:07 GMT, Chris Plummer wrote: >> If you run hotspot with -XX:+DeoptimizeObjectsALot, it will create one or >> more DeoptimizeObjectsALotThread threads. This is one of many JavaThread >> subclasses that SA needs to know about, but in this case it does not. When >> SA tr

Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread [v2]

2025-01-24 Thread Dean Long
On Thu, 23 Jan 2025 22:30:48 GMT, Chris Plummer wrote: > > Overall the changes seem fine, however it would be nice if the > > vmStructs.cpp registration mechanism was modular and extensible, instead of > > monolithic. That would make it easier to register private types, or even > > types outsi

Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread [v2]

2025-01-24 Thread Chris Plummer
On Fri, 24 Jan 2025 20:13:29 GMT, Chris Plummer wrote: >> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/Threads.java >> line 168: >> >>> 166: JvmtiAgentThread, NotificationThread, MonitorDeflationThread, >>> 167: StringDedupThread, AttachListenerThread, >>> Deoptimize

Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread [v2]

2025-01-24 Thread Chris Plummer
> If you run hotspot with -XX:+DeoptimizeObjectsALot, it will create one or > more DeoptimizeObjectsALotThread threads. This is one of many JavaThread > subclasses that SA needs to know about, but in this case it does not. When SA > tries to create a mirror of one of these threads, it fails with

Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread

2025-01-24 Thread Chris Plummer
On Fri, 24 Jan 2025 10:19:30 GMT, Kevin Walls wrote: >> If you run hotspot with -XX:+DeoptimizeObjectsALot, it will create one or >> more DeoptimizeObjectsALotThread threads. This is one of many JavaThread >> subclasses that SA needs to know about, but in this case it does not. When >> SA trie

Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread

2025-01-24 Thread Kevin Walls
On Thu, 23 Jan 2025 20:15:35 GMT, Chris Plummer wrote: > If you run hotspot with -XX:+DeoptimizeObjectsALot, it will create one or > more DeoptimizeObjectsALotThread threads. This is one of many JavaThread > subclasses that SA needs to know about, but in this case it does not. When SA > tries

Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread

2025-01-24 Thread Kevin Walls
On Thu, 23 Jan 2025 20:15:35 GMT, Chris Plummer wrote: > If you run hotspot with -XX:+DeoptimizeObjectsALot, it will create one or > more DeoptimizeObjectsALotThread threads. This is one of many JavaThread > subclasses that SA needs to know about, but in this case it does not. When SA > tries

Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread

2025-01-23 Thread Leonid Mesnik
On Thu, 23 Jan 2025 20:15:35 GMT, Chris Plummer wrote: > If you run hotspot with -XX:+DeoptimizeObjectsALot, it will create one or > more DeoptimizeObjectsALotThread threads. This is one of many JavaThread > subclasses that SA needs to know about, but in this case it does not. When SA > tries

Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread

2025-01-23 Thread David Holmes
On Thu, 23 Jan 2025 20:15:35 GMT, Chris Plummer wrote: > If you run hotspot with -XX:+DeoptimizeObjectsALot, it will create one or > more DeoptimizeObjectsALotThread threads. This is one of many JavaThread > subclasses that SA needs to know about, but in this case it does not. When SA > tries

Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread

2025-01-23 Thread Chris Plummer
On Thu, 23 Jan 2025 22:03:45 GMT, Dean Long wrote: > Overall the changes seem fine, however it would be nice if the vmStructs.cpp > registration mechanism was modular and extensible, instead of monolithic. > That would make it easier to register private types, or even types outside of > libjvm

Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread

2025-01-23 Thread Dean Long
On Thu, 23 Jan 2025 20:15:35 GMT, Chris Plummer wrote: > If you run hotspot with -XX:+DeoptimizeObjectsALot, it will create one or > more DeoptimizeObjectsALotThread threads. This is one of many JavaThread > subclasses that SA needs to know about, but in this case it does not. When SA > tries

Re: RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread

2025-01-23 Thread Dean Long
On Thu, 23 Jan 2025 20:15:35 GMT, Chris Plummer wrote: > If you run hotspot with -XX:+DeoptimizeObjectsALot, it will create one or > more DeoptimizeObjectsALotThread threads. This is one of many JavaThread > subclasses that SA needs to know about, but in this case it does not. When SA > tries

RFR: 8348239: SA does not know about DeoptimizeObjectsALotThread

2025-01-23 Thread Chris Plummer
If you run hotspot with -XX:+DeoptimizeObjectsALot, it will create one or more DeoptimizeObjectsALotThread threads. This is one of many JavaThread subclasses that SA needs to know about, but in this case it does not. When SA tries to create a mirror of one of these threads, it fails with: std