On Tue, 24 Dec 2024 22:22:28 GMT, Kim Barrett wrote:
>> Only this small piece would be appropriate for backport to 24. I suggest
>> splitting this out into its own bug,
>> fixing it in isolation, and backporting that.
>
> The purpose of this Makefile seems to be to build ctw.jar. So far as I ca
On Tue, 24 Dec 2024 03:26:23 GMT, Qizheng Xing wrote:
>> This patch fixes unmatched brackets in some source files.
>
> Qizheng Xing has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.
On Tue, 24 Dec 2024 20:27:37 GMT, Kim Barrett wrote:
>> Hmm, apparently this is not run as part of tier 1-3, which I ran in my
>> patch. I wonder how this test is run. And it means this patch needs to be
>> backported to 24.
>
> Only this small piece would be appropriate for backport to 24.
On Tue, 24 Dec 2024 15:45:24 GMT, Chen Liang wrote:
>> I've tested this by running `make`, and the previous Makefile reports an
>> error like file `test/lib/jtreg/SkippedException.java)` not found. So this
>> fix is necessary.
>>
>> I also checked the git log, this change was introduced in
>>
On Tue, 24 Dec 2024 03:26:23 GMT, Qizheng Xing wrote:
>> This patch fixes unmatched brackets in some source files.
>
> Qizheng Xing has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.
On Tue, 24 Dec 2024 03:28:31 GMT, Qizheng Xing wrote:
>> test/hotspot/jtreg/testlibrary/ctw/Makefile line 50:
>>
>>> 48: $(TESTLIBRARY_DIR)/jdk/test/lib/util \
>>> 49: $(TESTLIBRARY_DIR)/jtreg \
>>> 50: -maxdepth 1 -name '*.java')
>>
>> I wonder why this hasn't caused problems and b
On Tue, 24 Dec 2024 03:26:23 GMT, Qizheng Xing wrote:
>> This patch fixes unmatched brackets in some source files.
>
> Qizheng Xing has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.
On Mon, 23 Dec 2024 22:16:01 GMT, Phil Race wrote:
>> I was also wondering how this was tested.
>
> FYI, the way to test this is ..
> cd test/jdk
> jtreg sanity/client/SwingSet/src/TableDemoTest.java
>
> I tried converting all ^M to \n in this file another repo and comparing with
> your patch b
On Mon, 23 Dec 2024 17:11:14 GMT, Justin Lu wrote:
>> Qizheng Xing has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.19.2).
>> - Do not touch files in test.
>> - Do not touch up
On Mon, 23 Dec 2024 19:13:09 GMT, Kim Barrett wrote:
>> Qizheng Xing has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.19.2).
>> - Do not touch files in test.
>> - Do not touch
On Mon, 23 Dec 2024 14:00:54 GMT, Erik Joelsson wrote:
>> Qizheng Xing has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.19.2).
>> - Do not touch files in test.
>> - Do not touc
> This patch fixes unmatched brackets in some source files.
Qizheng Xing has updated the pull request incrementally with three additional
commits since the last revision:
- Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.19.2).
- Do not touch files in test.
- Do not touch upstream dat
On Mon, 23 Dec 2024 18:57:39 GMT, Kim Barrett wrote:
>> Qizheng Xing has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.19.2).
>> - Do not touch files in test.
>> - Do not touch
13 matches
Mail list logo
