Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-13 Thread Leonid Mesnik
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote: >> Unnecessary duplication of small utility method. There should be only one >> Util.newObjectName(). > > Kevin Walls has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrel

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-13 Thread Kevin Walls
On Fri, 13 Dec 2024 19:57:14 GMT, Leonid Mesnik wrote: > Thanks for describing. Thanks for confirming. The fewer of these methods the better! > src/java.management/share/classes/javax/management/ObjectName.java line 1225: > >> 1223: if (name.getClass().equals(ObjectName.class)) >> 1224

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-13 Thread Leonid Mesnik
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote: >> Unnecessary duplication of small utility method. There should be only one >> Util.newObjectName(). > > Kevin Walls has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrel

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-13 Thread Kevin Walls
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote: >> Unnecessary duplication of small utility method. There should be only one >> Util.newObjectName(). > > Kevin Walls has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrel

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-12 Thread Leonid Mesnik
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote: >> Unnecessary duplication of small utility method. There should be only one >> Util.newObjectName(). > > Kevin Walls has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrel

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-12 Thread Kevin Walls
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote: >> Unnecessary duplication of small utility method. There should be only one >> Util.newObjectName(). > > Kevin Walls has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrel

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-12 Thread Alex Menkov
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote: >> Unnecessary duplication of small utility method. There should be only one >> Util.newObjectName(). > > Kevin Walls has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrel

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-12 Thread Chris Plummer
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote: >> Unnecessary duplication of small utility method. There should be only one >> Util.newObjectName(). > > Kevin Walls has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrel

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-12 Thread Kevin Walls
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote: >> Unnecessary duplication of small utility method. There should be only one >> Util.newObjectName(). > > Kevin Walls has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrel

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-12 Thread Kevin Walls
On Wed, 11 Dec 2024 22:46:14 GMT, Chris Plummer wrote: >> Right, there are two Util classes, and some classes use both... >> e.g. ObjectName.java uses com.sun.jmx.mbeanserver.Util (for >> Util.wildmatch()), >> and I want to use newObjectName from sun.management.Util. > >> Right, there are two U

Re: RFR: 8345987: java.management has two Util.newObjectName methods (remove one) [v2]

2024-12-12 Thread Kevin Walls
> Unnecessary duplication of small utility method. There should be only one > Util.newObjectName(). Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request