On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote:
>> Unnecessary duplication of small utility method. There should be only one
>> Util.newObjectName().
>
> Kevin Walls has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrel
On Fri, 13 Dec 2024 19:57:14 GMT, Leonid Mesnik wrote:
> Thanks for describing.
Thanks for confirming. The fewer of these methods the better!
> src/java.management/share/classes/javax/management/ObjectName.java line 1225:
>
>> 1223: if (name.getClass().equals(ObjectName.class))
>> 1224
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote:
>> Unnecessary duplication of small utility method. There should be only one
>> Util.newObjectName().
>
> Kevin Walls has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrel
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote:
>> Unnecessary duplication of small utility method. There should be only one
>> Util.newObjectName().
>
> Kevin Walls has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrel
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote:
>> Unnecessary duplication of small utility method. There should be only one
>> Util.newObjectName().
>
> Kevin Walls has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrel
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote:
>> Unnecessary duplication of small utility method. There should be only one
>> Util.newObjectName().
>
> Kevin Walls has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrel
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote:
>> Unnecessary duplication of small utility method. There should be only one
>> Util.newObjectName().
>
> Kevin Walls has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrel
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote:
>> Unnecessary duplication of small utility method. There should be only one
>> Util.newObjectName().
>
> Kevin Walls has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrel
On Thu, 12 Dec 2024 09:54:03 GMT, Kevin Walls wrote:
>> Unnecessary duplication of small utility method. There should be only one
>> Util.newObjectName().
>
> Kevin Walls has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrel
On Wed, 11 Dec 2024 22:46:14 GMT, Chris Plummer wrote:
>> Right, there are two Util classes, and some classes use both...
>> e.g. ObjectName.java uses com.sun.jmx.mbeanserver.Util (for
>> Util.wildmatch()),
>> and I want to use newObjectName from sun.management.Util.
>
>> Right, there are two U
> Unnecessary duplication of small utility method. There should be only one
> Util.newObjectName().
Kevin Walls has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request
On Wed, 11 Dec 2024 21:15:19 GMT, Kevin Walls wrote:
> Right, there are two Util classes, and some classes use both... e.g.
> ObjectName.java uses com.sun.jmx.mbeanserver.Util (for Util.wildmatch()), and
> I want to use newObjectName from sun.management.Util.
In that case I'd probably just use
On Wed, 11 Dec 2024 18:55:11 GMT, Chris Plummer wrote:
>> Unnecessary duplication of small utility method. There should be only one
>> Util.newObjectName().
>
> src/java.management/share/classes/javax/management/ObjectName.java line 40:
>
>> 38: import java.util.Map;
>> 39:
>> 40: import stat
On Wed, 11 Dec 2024 13:55:24 GMT, Kevin Walls wrote:
> Unnecessary duplication of small utility method. There should be only one
> Util.newObjectName().
src/java.management/share/classes/javax/management/ObjectName.java line 40:
> 38: import java.util.Map;
> 39:
> 40: import static sun.manag
Unnecessary duplication of small utility method. There should be only one
Util.newObjectName().
-
Commit messages:
- 8345987: java.management has two Util.newObjectName methods (remove one)
Changes: https://git.openjdk.org/jdk/pull/22681/files
Webrev: https://webrevs.openjdk.org
15 matches
Mail list logo
