On Thu, 31 Oct 2024 02:34:04 GMT, David Holmes wrote:
>> Thank you for the review.
>
> @justin-curtis-lu for future reference note that hotspot generally requires
> two reviews per PR before integration. This was a very simple change but not
> "trivial" in the sense documented in the developer
On Wed, 30 Oct 2024 20:31:44 GMT, Justin Lu wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address other cases in Hotspot
>
> Thank you for the review.
@justin-curtis-lu for future reference note that hotspot gener
On Tue, 29 Oct 2024 00:19:29 GMT, Justin Lu wrote:
>> A trivial JNI refactoring in Hotspot to use `ExceptionCheck()` over
>> `ExceptionOccurred()` when the usage is treating the return value as a
>> boolean. This is part of the bigger umbrella issue:
>> [JDK-8341542](https://bugs.openjdk.org/b
On Tue, 29 Oct 2024 00:19:29 GMT, Justin Lu wrote:
>> A trivial JNI refactoring in Hotspot to use `ExceptionCheck()` over
>> `ExceptionOccurred()` when the usage is treating the return value as a
>> boolean. This is part of the bigger umbrella issue:
>> [JDK-8341542](https://bugs.openjdk.org/b
On Mon, 28 Oct 2024 03:12:55 GMT, David Holmes wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address other cases in Hotspot
>
> @justin-curtis-lu you have missed a large number of usages:
>
> ./share/prims/nativeE
> A trivial JNI refactoring in Hotspot to use `ExceptionCheck()` over
> `ExceptionOccurred()` when the usage is treating the return value as a
> boolean. This is part of the bigger umbrella issue:
> [JDK-8341542](https://bugs.openjdk.org/browse/JDK-8341542).
>
>
>
>> ExceptionCheck
>>
On Fri, 25 Oct 2024 21:51:53 GMT, Justin Lu wrote:
> A trivial JNI refactoring in Hotspot to use `ExceptionCheck()` over
> `ExceptionOccurred()` when the usage is treating the return value as a
> boolean. This is part of the bigger umbrella issue:
> [JDK-8341542](https://bugs.openjdk.org/brows
A trivial JNI refactoring in Hotspot to use `ExceptionCheck()` over
`ExceptionOccurred()` when the usage is treating the return value as a boolean.
This is part of the bigger umbrella issue:
[JDK-8341542](https://bugs.openjdk.org/browse/JDK-8341542).
> ExceptionCheck
> We introduce a
