On Thu, 12 Sep 2024 15:52:41 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also in
On Thu, 12 Sep 2024 15:52:41 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also in
On Thu, 12 Sep 2024 15:52:41 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also in
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes a cleanup of all the related function/template
> paramet
On Thu, 12 Sep 2024 15:40:35 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also in
On Thu, 12 Sep 2024 15:32:57 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also in
On Thu, 12 Sep 2024 15:32:57 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also in
On Thu, 12 Sep 2024 13:31:28 GMT, Afshin Zafari wrote:
> ## Again, if we want to replace mem type with mem tag. The regexp search for
> mem.*type gives this:
> 47 results - 19 files
Done.
> The `MemTracker::record_virtual_memory_type` can be changed to
> `MemTracker::record_virtual_memory_tag
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes a cleanup of all the related function/template
> paramet
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes a cleanup of all the related function/template
> paramet
On Wed, 11 Sep 2024 14:03:17 GMT, Gerard Ziemski wrote:
>> Gerard Ziemski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Coleen's feedback
>
> Are we sure we want `mt` for non-type parameter name in templates? We have
> these existing
On Thu, 12 Sep 2024 11:54:49 GMT, David Holmes wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.inline.hpp line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2016, 2019, Red Hat, Inc. All rights reserved.
>>
>> I don't think we're meant to update other companies' copyrights?
>
> That is
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes a cleanup of all the related function/template
> paramet
On Tue, 10 Sep 2024 20:53:46 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also in
On Tue, 10 Sep 2024 20:53:46 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also in
On Thu, 12 Sep 2024 08:35:16 GMT, Johan Sjölen wrote:
>> Gerard Ziemski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Coleen's feedback
>
> src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.inline.hpp line 2:
>
>> 1: /*
>> 2: * Cop
On Wed, 11 Sep 2024 14:03:17 GMT, Gerard Ziemski wrote:
>> Gerard Ziemski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Coleen's feedback
>
> Are we sure we want `mt` for non-type parameter name in templates? We have
> these existing
On Tue, 10 Sep 2024 20:53:46 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also in
On Tue, 10 Sep 2024 20:53:46 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also in
On Tue, 10 Sep 2024 20:53:46 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also in
On Wed, 11 Sep 2024 01:03:55 GMT, David Holmes wrote:
> EDIT: Oh dear. I see I have been under a misapprehension about these template
> parameters, I tend to always thing such things are type parameters but they
> are not. MT would make sense for a type parameter, but mt would be more
> sensib
On Tue, 10 Sep 2024 20:53:46 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also in
On Tue, 10 Sep 2024 21:58:39 GMT, Kim Barrett wrote:
> Side note: why are template parameter names all capitals?
I think it is an artifact of them usually being a single letter to represent a
Type and thus a capital. But then we sometimes use more than a single-letter
and decided to capitalize
On Tue, 10 Sep 2024 21:58:39 GMT, Kim Barrett wrote:
> Type template parameters should follow the style guide rules for type names.
> I've not noticed many (any?) cases of noncompliance.
... other than ConcurrentHashTable (sigh!)
-
PR Comment: https://git.openjdk.org/jdk/pull/2087
On Tue, 10 Sep 2024 14:15:53 GMT, Gerard Ziemski wrote:
> Is everyone OK with `MT` as the template parameter name? Another obvious
> choice is `MEM_TAG`
>
> Side note: why are template parameter names all capitals? To help distinguish
> them from "regular" parameters? Do we still want that nam
On Tue, 10 Sep 2024 20:53:46 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also in
On Tue, 10 Sep 2024 20:53:46 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also in
On Tue, 10 Sep 2024 20:28:01 GMT, Coleen Phillimore wrote:
>> Gerard Ziemski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix test
>
> src/hotspot/share/nmt/memTracker.hpp line 265:
>
>> 263:
>> 264: // MallocLimt: Given an alloca
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes a cleanup of all the related parameter names and local
>
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes a cleanup of all the related parameter names and local
>
On Mon, 9 Sep 2024 19:02:25 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also inc
On Mon, 9 Sep 2024 19:02:25 GMT, Gerard Ziemski wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also inc
On Tue, 10 Sep 2024 05:57:08 GMT, David Holmes wrote:
> > The template parameter rename I was planning on doing in a followup issue,
> > however, if you really want, I can make the fix here too.
>
> Personally I'd be okay with doing it here as one final commit that can be
> viewed in isolation
On Mon, 9 Sep 2024 17:13:11 GMT, Gerard Ziemski wrote:
> The template parameter rename I was planning on doing in a followup issue,
> however, if you really want, I can make the fix here too.
Personally I'd be okay with doing it here as one final commit that can be
viewed in isolation.
--
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes a cleanup of all the related parameter names and local
>
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes a cleanup of all the related parameter names and local
>
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes a cleanup of all the related parameter names and local
>
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes a cleanup of all the related parameter names and local
>
On Thu, 5 Sep 2024 16:10:05 GMT, Gerard Ziemski wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes
On Sat, 7 Sep 2024 05:21:50 GMT, Kim Barrett wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also includ
On Mon, 9 Sep 2024 00:04:58 GMT, David Holmes wrote:
>> src/hotspot/share/gc/shared/taskqueue.hpp line 119:
>>
>>> 117: // TaskQueueSuper collects functionality common to all
>>> GenericTaskQueue instances.
>>> 118:
>>> 119: template
>>
>> MemTag parameter name should probably be changed her
On Mon, 9 Sep 2024 13:36:26 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/utilities/chunkedList.hpp line 31:
>>
>>> 29: #include "utilities/debug.hpp"
>>> 30:
>>> 31: template class ChunkedList : public CHeapObj {
>>
>> Parameter name should be updated. Suggest `mem_tag`.
>
> How about
On Sat, 7 Sep 2024 05:24:29 GMT, Kim Barrett wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also includ
On Mon, 9 Sep 2024 00:13:25 GMT, David Holmes wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also inclu
On Thu, 5 Sep 2024 16:10:05 GMT, Gerard Ziemski wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes
On Sat, 7 Sep 2024 05:27:12 GMT, Kim Barrett wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also includ
On Thu, 5 Sep 2024 16:10:05 GMT, Gerard Ziemski wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes
On Sat, 7 Sep 2024 05:11:25 GMT, Kim Barrett wrote:
>> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>>
>> `MEMFLAGS` implies that we can use more than one at the same time, but those
>> are exclusive values, so `MemTag` is a more suitable name.
>>
>> This fix also includ
On Thu, 5 Sep 2024 16:10:05 GMT, Gerard Ziemski wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes
On Thu, 5 Sep 2024 16:10:05 GMT, Gerard Ziemski wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those
> are exclusive values, so `MemTag` is a more suitable name.
>
> This fix also includes
Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`.
`MEMFLAGS` implies that we can use more than one at the same time, but those
are exclusive values, so `MemTag` is a more suitable name.
This fix also includes a cleanup of all the related parameter names and local
variable name
51 matches
Mail list logo
